1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] wine [293158] disable 'fortify' to prevent crashes (mga#6723)
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20wine%20%5B293158%5D%20disable%20%27fortify%27%20to%20prevent%20crashes%0A%09%28mga%236723%29&In-Reply-To=%3C50634836.5030309%40mageia.org%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="018941.html">
<LINK REL="Next" HREF="018954.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] wine [293158] disable 'fortify' to prevent crashes (mga#6723)</H1>
<B>Anssi Hannula</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20wine%20%5B293158%5D%20disable%20%27fortify%27%20to%20prevent%20crashes%0A%09%28mga%236723%29&In-Reply-To=%3C50634836.5030309%40mageia.org%3E"
TITLE="[Mageia-dev] wine [293158] disable 'fortify' to prevent crashes (mga#6723)">anssi at mageia.org
</A><BR>
<I>Wed Sep 26 20:23:50 CEST 2012</I>
<P><UL>
<LI>Previous message: <A HREF="018941.html">[Mageia-dev] [changelog] [RPM] cauldron core/release perl-App-Module-Locate-0.500.0-1.mga3
</A></li>
<LI>Next message: <A HREF="018954.html">[Mageia-dev] rpmrc [5221] build with -fPIC on x86_64 too (pok, mdv)
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#18953">[ date ]</a>
<a href="thread.html#18953">[ thread ]</a>
<a href="subject.html#18953">[ subject ]</a>
<a href="author.html#18953">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>12.09.2012 22:13, <A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A> kirjoitti:
><i> Log Message
</I>><i>
</I>><i> disable 'fortify' to prevent crashes (mga#6723)
</I>[...
><i> Modified: cauldron/wine/current/SPECS/wine.spec
</I>><i> ===================================================================
</I>><i> --- cauldron/wine/current/SPECS/wine.spec 2012-09-12 19:02:56 UTC (rev 293157)
</I>><i> +++ cauldron/wine/current/SPECS/wine.spec 2012-09-12 19:13:38 UTC (rev 293158)
</I>><i> @@ -25,7 +25,7 @@
</I>><i> Name: wine
</I>><i> Version: 1.5.12
</I>><i> %define pre 0
</I>><i> -%define rel 1
</I>><i> +%define rel 2
</I>><i> %if %pre
</I>><i> Release: %mkrel 0.%pre.%rel
</I>><i> %define o_ver %version-%pre
</I>><i> @@ -245,6 +245,10 @@
</I>><i>
</I>><i> %build
</I>><i> autoreconf
</I>><i> +# disable fortify as it breaks wine
</I>><i> +# <A HREF="http://bugs.winehq.org/show_bug.cgi?id=24606#c22">http://bugs.winehq.org/show_bug.cgi?id=24606#c22</A>
</I>><i> +# <A HREF="http://bugs.winehq.org/show_bug.cgi?id=25073">http://bugs.winehq.org/show_bug.cgi?id=25073</A>
</I>><i> +export CFLAGS="`echo $RPM_OPT_FLAGS | sed -e 's/-Wp,-D_FORTIFY_SOURCE=2//'` -Wno-error"
</I>><i> %configure2_5x --with-x \
</I>><i> --with-pulse \
</I>><i> %ifarch x86_64
</I>
Strange, wine configure script already disables fortify since 1.3.6 (Oct
2010), so something weird must be going on:
<A HREF="http://source.winehq.org/git/wine.git/?a=commitdiff;h=105793bff75f6a869bd9ccfb390b2f88fa861235">http://source.winehq.org/git/wine.git/?a=commitdiff;h=105793bff75f6a869bd9ccfb390b2f88fa861235</A>
... ok, it is actually because we use -Wp,-D_FORTIFY_SOURCE=2 instead of
-D_FORTIFY_SOURCE=2 and -U_FORTIFY_SOURCE=2 fails to override the
former. So I sent a patch to wine-patches@, no idea if they agree:
<A HREF="http://www.winehq.org/pipermail/wine-patches/2012-September/118257.html">http://www.winehq.org/pipermail/wine-patches/2012-September/118257.html</A>
Also, a cleaner way to disable fortify is
%define _fortify_cflags %nil
--
Anssi Hannula
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="018941.html">[Mageia-dev] [changelog] [RPM] cauldron core/release perl-App-Module-Locate-0.500.0-1.mga3
</A></li>
<LI>Next message: <A HREF="018954.html">[Mageia-dev] rpmrc [5221] build with -fPIC on x86_64 too (pok, mdv)
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#18953">[ date ]</a>
<a href="thread.html#18953">[ thread ]</a>
<a href="subject.html#18953">[ subject ]</a>
<a href="author.html#18953">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
