summaryrefslogtreecommitdiffstats
path: root/zarb-ml/mageia-dev/2012-September/018502.html
blob: 5b95ee957ca208b601628a1101fa3b47f4e81423 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
 <HEAD>
   <TITLE> [Mageia-dev] [soft-commits] [5686] For non-local media,	iurt is suppressing the urpmi. cfg file while creating
   </TITLE>
   <LINK REL="Index" HREF="index.html" >
   <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B5686%5D%20For%20non-local%20media%2C%0A%09iurt%20is%20suppressing%20the%20urpmi.%20cfg%20file%20while%20creating&In-Reply-To=%3C877gs7qxy5.fsf%40lebrac.rtp-net.org%3E">
   <META NAME="robots" CONTENT="index,nofollow">
   <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
   <LINK REL="Previous"  HREF="018500.html">
   <LINK REL="Next"  HREF="018490.html">
 </HEAD>
 <BODY BGCOLOR="#ffffff">
   <H1>[Mageia-dev] [soft-commits] [5686] For non-local media,	iurt is suppressing the urpmi. cfg file while creating</H1>
    <B>Arnaud Patard (Rtp)</B> 
    <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B5686%5D%20For%20non-local%20media%2C%0A%09iurt%20is%20suppressing%20the%20urpmi.%20cfg%20file%20while%20creating&In-Reply-To=%3C877gs7qxy5.fsf%40lebrac.rtp-net.org%3E"
       TITLE="[Mageia-dev] [soft-commits] [5686] For non-local media,	iurt is suppressing the urpmi. cfg file while creating">arnaud.patard at rtp-net.org
       </A><BR>
    <I>Thu Sep  6 11:53:38 CEST 2012</I>
    <P><UL>
        <LI>Previous message: <A HREF="018500.html">[Mageia-dev] [soft-commits] [5686] For non-local media, iurt is suppressing the urpmi. cfg file while creating
</A></li>
        <LI>Next message: <A HREF="018490.html">[Mageia-dev] meeting
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#18502">[ date ]</a>
              <a href="thread.html#18502">[ thread ]</a>
              <a href="subject.html#18502">[ subject ]</a>
              <a href="author.html#18502">[ author ]</a>
         </LI>
       </UL>
    <HR>  
<!--beginarticle-->
<PRE>Thierry Vignaud &lt;<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">thierry.vignaud at gmail.com</A>&gt; writes:

&gt;<i> On 5 September 2012 18:05, Thierry Vignaud &lt;<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">thierry.vignaud at gmail.com</A>&gt; wrote:
</I>&gt;&gt;&gt;<i> Log Message
</I>&gt;&gt;&gt;<i>
</I>&gt;&gt;&gt;<i> For non-local media, iurt is suppressing the urpmi.cfg file while creating
</I>&gt;&gt;&gt;<i> the chroot.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i> Wrong, it's always removed
</I>&gt;&gt;<i>
</I>&gt;&gt;&gt;<i> This has the side effect of forcing people to use things like
</I>&gt;&gt;&gt;<i> --chrooted-urpmi even if the iurt configuration is fine (since it managed
</I>&gt;&gt;&gt;<i> to create the chroot). So, add media while creating the build chroot for
</I>&gt;&gt;&gt;<i> non-local media, as long as --chrooted-urpmi has not been used.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i> Anyway this is insane IMHO: new logic is:
</I>&gt;&gt;<i> - add media
</I>&gt;&gt;<i> - install pkgs
</I>&gt;&gt;<i> - remove media
</I>&gt;&gt;<i> - readd media
</I>&gt;&gt;<i>
</I>&gt;&gt;<i> Either you should use --chrooted-urpmi (instead of re-implementing it)
</I>&gt;&gt;<i> or you should just not remove the media in the first place when using
</I>&gt;&gt;<i> use__urpmi_root,
</I>&gt;&gt;<i> aka if using remote media
</I>&gt;<i>
</I>&gt;<i> Ping?
</I>&gt;<i> Does this patch works for your usage?
</I>@@ -440,8 +428,11 @@ sub build_chroot {
     }

     # remove files used by --urpmi-root
-    sudo($config, &quot;--rm&quot;, &quot;$tmp_chroot/etc/urpmi/urpmi.cfg&quot;);
-    sudo($config, &quot;--rm&quot;, &quot;$tmp_chroot/var/lib/urpmi/*&quot;);
+    #if (!$urpmi-&gt;{use__urpmi_root} || $run-&gt;{chrooted_urpmi}) {
+    if (!($urpmi-&gt;{use__urpmi_root} &amp;&amp; !$run-&gt;{chrooted_urpmi})) {
+       sudo($config, &quot;--rm&quot;, &quot;$tmp_chroot/etc/urpmi/urpmi.cfg&quot;);
+       sudo($config, &quot;--rm&quot;, &quot;$tmp_chroot/var/lib/urpmi/*&quot;);
+    }

I thought about similar change too. My usage is avoiding to do something like :
$ iurt --chrooted-urpmi -m core/release -- <A HREF="http://127.0.0.1/">http://127.0.0.1/</A> -r cauldron &lt;arch&gt; &lt;src.rpm&gt;

when you already have this very same media in the iurt
configuration. So, I guess this change will fix it. Unfortunately, it
may bring troubles in some corner cases.

For instance:

Someone installs iurt and then creates a chroot with:
$ iurt -r cauldron &lt;arch&gt; -c

(repository url <A HREF="http://127.0.0.1/">http://127.0.0.1/</A>)

Now, tries to rebuild with:

$ iurt --chrooted-urpmi -m myother/release -- <A HREF="http://10.0.0.1/">http://10.0.0.1/</A> -r cauldron &lt;arch&gt; &lt;src.rpm&gt;

With your proposed change, the urpmi.cfg file won't be the same. I don't
know if it matters in practice but I wanted to avoid any regressions as
most as possible.

Arnaud
</PRE>



<!--endarticle-->
    <HR>
    <P><UL>
        <!--threads-->
	<LI>Previous message: <A HREF="018500.html">[Mageia-dev] [soft-commits] [5686] For non-local media, iurt is suppressing the urpmi. cfg file while creating
</A></li>
	<LI>Next message: <A HREF="018490.html">[Mageia-dev] meeting
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#18502">[ date ]</a>
              <a href="thread.html#18502">[ thread ]</a>
              <a href="subject.html#18502">[ subject ]</a>
              <a href="author.html#18502">[ author ]</a>
         </LI>
       </UL>

<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>