1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [5686] For non-local media, iurt is suppressing the urpmi. cfg file while creating
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B5686%5D%20For%20non-local%20media%2C%0A%20iurt%20is%20suppressing%20the%20urpmi.%20cfg%20file%20while%20creating&In-Reply-To=%3C50485C96.6060000%40colin.guthr.ie%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="018499.html">
<LINK REL="Next" HREF="018502.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [5686] For non-local media, iurt is suppressing the urpmi. cfg file while creating</H1>
<B>Colin Guthrie</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B5686%5D%20For%20non-local%20media%2C%0A%20iurt%20is%20suppressing%20the%20urpmi.%20cfg%20file%20while%20creating&In-Reply-To=%3C50485C96.6060000%40colin.guthr.ie%3E"
TITLE="[Mageia-dev] [soft-commits] [5686] For non-local media, iurt is suppressing the urpmi. cfg file while creating">mageia at colin.guthr.ie
</A><BR>
<I>Thu Sep 6 10:19:34 CEST 2012</I>
<P><UL>
<LI>Previous message: <A HREF="018499.html">[Mageia-dev] [soft-commits] [5686] For non-local media, iurt is suppressing the urpmi. cfg file while creating
</A></li>
<LI>Next message: <A HREF="018502.html">[Mageia-dev] [soft-commits] [5686] For non-local media, iurt is suppressing the urpmi. cfg file while creating
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#18500">[ date ]</a>
<a href="thread.html#18500">[ thread ]</a>
<a href="subject.html#18500">[ subject ]</a>
<a href="author.html#18500">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>'Twas brillig, and Thierry Vignaud at 06/09/12 09:08 did gyre and gimble:
><i> +++ b/lib/Iurt/Chroot.pm
</I>><i> @@ -300,23 +300,11 @@ sub check_chroot_need_update {
</I>><i>
</I>><i> sub create_build_chroot {
</I>><i> my ($chroot, $chroot_ref, $run, $config) = @_;
</I>><i> - my $ret = 0;
</I>><i> if ($run->{storage} eq 'btrfs') {
</I>><i> - $ret = create_build_chroot_btrfs($chroot, $chroot_ref, $run, $config);
</I>><i> + return create_build_chroot_btrfs($chroot, $chroot_ref, $run, $config);
</I>><i> } else {
</I>><i> - $ret = create_build_chroot_tar($chroot, $chroot_ref, $run, $config);
</I>><i> + return create_build_chroot_tar($chroot, $chroot_ref, $run, $config);
</I>><i> }
</I>
Not sure if it fits your own coding style, but I would leave the "else"
out here as it's redundant.
Col
--
Colin Guthrie
colin(at)mageia.org
<A HREF="http://colin.guthr.ie/">http://colin.guthr.ie/</A>
Day Job:
Tribalogic Limited <A HREF="http://www.tribalogic.net/">http://www.tribalogic.net/</A>
Open Source:
Mageia Contributor <A HREF="http://www.mageia.org/">http://www.mageia.org/</A>
PulseAudio Hacker <A HREF="http://www.pulseaudio.org/">http://www.pulseaudio.org/</A>
Trac Hacker <A HREF="http://trac.edgewall.org/">http://trac.edgewall.org/</A>
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="018499.html">[Mageia-dev] [soft-commits] [5686] For non-local media, iurt is suppressing the urpmi. cfg file while creating
</A></li>
<LI>Next message: <A HREF="018502.html">[Mageia-dev] [soft-commits] [5686] For non-local media, iurt is suppressing the urpmi. cfg file while creating
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#18500">[ date ]</a>
<a href="thread.html#18500">[ thread ]</a>
<a href="subject.html#18500">[ subject ]</a>
<a href="author.html#18500">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
