1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [6240] various optimizations from mdv svn
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6240%5D%20various%20optimizations%20from%0A%09mdv%20svn&In-Reply-To=%3CCAONrEtY8u9qkf2ca1yRDMVyjYhFDwMKaZPg0ybrAsnpNLMtA%3Dw%40mail.gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="019363.html">
<LINK REL="Next" HREF="019375.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [6240] various optimizations from mdv svn</H1>
<B>Thierry Vignaud</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6240%5D%20various%20optimizations%20from%0A%09mdv%20svn&In-Reply-To=%3CCAONrEtY8u9qkf2ca1yRDMVyjYhFDwMKaZPg0ybrAsnpNLMtA%3Dw%40mail.gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [6240] various optimizations from mdv svn">thierry.vignaud at gmail.com
</A><BR>
<I>Mon Oct 15 23:50:41 CEST 2012</I>
<P><UL>
<LI>Previous message: <A HREF="019363.html">[Mageia-dev] Mageia 3 planning
</A></li>
<LI>Next message: <A HREF="019375.html">[Mageia-dev] Mageia 2 - Security issiue
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#19367">[ date ]</a>
<a href="thread.html#19367">[ thread ]</a>
<a href="subject.html#19367">[ subject ]</a>
<a href="author.html#19367">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On 15 October 2012 22:47, <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>> wrote:
><i> --- rpm/urpmi/trunk/NEWS 2012-10-15 17:51:47 UTC (rev 6239)
</I>><i> +++ rpm/urpmi/trunk/NEWS 2012-10-15 20:47:50 UTC (rev 6240)
</I>><i> @@ -1,5 +1,6 @@
</I>><i> - do not use aria2 deprecated option (Sam Bailey, mga#7781)
</I>><i> -- do not offer to remove DKMS modules for current kernel (mga#5092
</I>><i> +- do not offer to remove DKMS modules for current kernel (mga#5092)
</I>><i> +- aria2 optimisations from mdv svn
</I>><i>
</I>><i> Version 7.9 - 11 October 2012, by Thierry Vignaud
</I>><i>
</I>><i>
</I>><i> Modified: rpm/urpmi/trunk/urpm/download.pm
</I>><i> ===================================================================
</I>><i> --- rpm/urpmi/trunk/urpm/download.pm 2012-10-15 17:51:47 UTC (rev 6239)
</I>><i> +++ rpm/urpmi/trunk/urpm/download.pm 2012-10-15 20:47:50 UTC (rev 6240)
</I>><i> @@ -93,13 +93,6 @@
</I>><i> $urpm->{log}(N("%s is not available, falling back on %s",
</I>><i> $requested_downloader, $preferred));
</I>><i> }
</I>><i> }
</I>><i> - # in some cases, we may want not to use metalink (aria2) since it can
</I>><i> - # cause issues, see #53434 for example
</I>><i> - if ($metalink_disabled && member($preferred, @metalink_downloaders)) {
</I>><i> - $urpm->{log}("not using $preferred since metalink has been disabled");
</I>><i> - my @no_metalink = urpm::util::difference2(\@available,
</I>><i> \@metalink_downloaders);
</I>><i> - $preferred = $no_metalink[0];
</I>><i> - }
</I>><i>
</I>><i> if ($$use_metalink && !member($preferred, @metalink_downloaders)) {
</I>><i> $warned{not_using_metalink}++ or
</I>><i> @@ -699,19 +692,24 @@
</I>><i>
</I>><i> my $aria2c_command = join(" ", map { "'$_'" }
</I>><i> "/usr/bin/aria2c", $options->{debug} ? ('--log',
</I>><i> "$options->{dir}/.aria2.log") : @{[]},
</I>><i> - "--auto-file-renaming=false",
</I>><i> + '--auto-file-renaming=false',
</I>><i> '--ftp-pasv',
</I>><i> - "--follow-metalink=mem",
</I>><i> + '--summary-interval=0',
</I>><i> + '--follow-metalink=mem',
</I>><i> $medium->{mirrorlist} ? (
</I>><i> - '--metalink-enable-unique-protocol=false', # so that it can try both ftp
</I>><i> and http access on the same server. aria2 will only do this on first calls
</I>><i> - '--max-tries=1', # nb: not using $options->{retry}
</I>><i> + '--metalink-enable-unique-protocol=true', # do not try to connect to the
</I>><i> same server using the same protocol
</I>><i> + '--metalink-preferred-protocol=http', # try http as first protocol as
</I>><i> they're stateless and
</I>><i> + # will put less strain on ie. the
</I>><i> ftp servers which connections
</I>><i> + # are statefull for, causing
</I>><i> unhappy mirror admins complaining
</I>><i> + # about increase of connections,
</I>><i> increasing resource usage.
</I>><i> + '--max-tries=5', # nb: not using $options->{retry}
</I>><i> '--lowest-speed-limit=20K', "--timeout", 3,
</I>><i> '--split=3', # maximum number of servers to use for one download
</I>><i> '--uri-selector=adaptive', "--server-stat-if=$stat_file",
</I>><i> "--server-stat-of=$stat_file",
</I>><i> - $options->{is_versioned} ? @{[]} : '--max-file-not-found=3', #
</I>><i> number of not found errors on different servers before aborting file
</I>><i> download
</I>><i> + $options->{is_versioned} ? @{[]} : '--max-file-not-found=9', #
</I>><i> number of not found errors on different servers before aborting file
</I>><i> download
</I>
You should have keep their changelog isntead of "optimizations", like:
"- reenable aria2 + metalink for downloading metadata by default to
make it more reliable
- try tune aria2 download parameters for faster and more reliable options
- suppress aria2's printing of summaries to avoid it confusing urpmi
parsing the output"
Please edit NEWS (as well as SVN log)
Also it would have been better to commit them one at a time.
Have you tested them?
><i> '--connect-timeout=6', # $CONNECT_TIMEOUT,
</I>><i> ) : @{[]},
</I>><i> - "-Z", "-j1",
</I>><i> + '-Z', '-j1',
</I>
That bit was unneeded. But that's OK.
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="019363.html">[Mageia-dev] Mageia 3 planning
</A></li>
<LI>Next message: <A HREF="019375.html">[Mageia-dev] Mageia 2 - Security issiue
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#19367">[ date ]</a>
<a href="thread.html#19367">[ thread ]</a>
<a href="subject.html#19367">[ subject ]</a>
<a href="author.html#19367">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
