1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [6435] Added a first log viewer module.
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6435%5D%20Added%20a%20first%20log%20viewer%0A%09module.&In-Reply-To=%3C50A0E02B.5080503%40colin.guthr.ie%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="019958.html">
<LINK REL="Next" HREF="019954.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [6435] Added a first log viewer module.</H1>
<B>Colin Guthrie</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6435%5D%20Added%20a%20first%20log%20viewer%0A%09module.&In-Reply-To=%3C50A0E02B.5080503%40colin.guthr.ie%3E"
TITLE="[Mageia-dev] [soft-commits] [6435] Added a first log viewer module.">mageia at colin.guthr.ie
</A><BR>
<I>Mon Nov 12 12:40:27 CET 2012</I>
<P><UL>
<LI>Previous message: <A HREF="019958.html">[Mageia-dev] [soft-commits] [6435] Added a first log viewer module.
</A></li>
<LI>Next message: <A HREF="019954.html">[Mageia-dev] [soft-commits] [6435] Added a first log viewer module.
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#19949">[ date ]</a>
<a href="thread.html#19949">[ thread ]</a>
<a href="subject.html#19949">[ subject ]</a>
<a href="author.html#19949">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>'Twas brillig, and Guillaume Rousse at 12/11/12 08:44 did gyre and gimble:
><i> Le 11/11/2012 19:13, <A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A> a écrit :
</I>>><i> +package LogViewer;
</I>>><i> +
</I>>><i> +use strict;
</I>>><i> +use POSIX;
</I>><i> never load the POSIX module this way. Either import it without importing
</I>><i> any symbol in your namespace, either import just the symbols you need.
</I>><i> See POSIX(3pm) for details.
</I>><i>
</I>><i> [..]
</I>>><i> + $::isWizard = 1;
</I>><i> ugly syntax.
</I>><i>
</I>><i> [..]
</I>>><i> +#- check services
</I>>><i> +my ) . Data::Dumper->Dump([ $service ], [qw(*services)]) . q(
</I>>><i> +foreach (split(':', $options{SERVICES})) {
</I>>><i> + next unless $services{$_};
</I>>><i> + $r .= "Service $_ ($services{$_} is not running)\\n" unless -e
</I>>><i> "/var/lock/subsys/$_";
</I>>><i> +}
</I>><i> You shouldn't leave debugging statement in your code. Moreover, I doubt
</I>><i> this is syntactically correct. Do you use Test::Compile to check your
</I>><i> code compiles correctly ?
</I>
Also /var/log/subsys is almost dead under systemd anyway. It's still
used by a few legacy initscripts that systemd calls, but I'm not sure
where this is going.
Also, if you are implementing a new log viewer module, is this going to
use the systemd journal rather than implementing it's own complex logic
for parsing compressed text files? I've not looked at the code, but it
would be *awesome* if this is what was happening :)
It's very easy to use the journal APIs (either by linking the library,
using python bindings - not sure if there are external perl bindings
yet, but I wouldn't be surprised if there are - or simply calling
journalctl on the command line and parsing the result. It offers an easy
to parse JSON format so even going via this route should be trivial if
official bindings do not exist). You can get all logs between certain
dates and for particular services with ease, without having to look in
the right file or grep for the right binary. i.e. all the building
blocks are in place for you :)
Col
--
Colin Guthrie
colin(at)mageia.org
<A HREF="http://colin.guthr.ie/">http://colin.guthr.ie/</A>
Day Job:
Tribalogic Limited <A HREF="http://www.tribalogic.net/">http://www.tribalogic.net/</A>
Open Source:
Mageia Contributor <A HREF="http://www.mageia.org/">http://www.mageia.org/</A>
PulseAudio Hacker <A HREF="http://www.pulseaudio.org/">http://www.pulseaudio.org/</A>
Trac Hacker <A HREF="http://trac.edgewall.org/">http://trac.edgewall.org/</A>
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="019958.html">[Mageia-dev] [soft-commits] [6435] Added a first log viewer module.
</A></li>
<LI>Next message: <A HREF="019954.html">[Mageia-dev] [soft-commits] [6435] Added a first log viewer module.
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#19949">[ date ]</a>
<a href="thread.html#19949">[ thread ]</a>
<a href="subject.html#19949">[ subject ]</a>
<a href="author.html#19949">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|