1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6416%5D%20Initial%20commit%20of%20Admin%0A%09Panel.&In-Reply-To=%3C50996B15.1030803%40gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="019816.html">
<LINK REL="Next" HREF="019821.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.</H1>
<B>Guillaume Rousse</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6416%5D%20Initial%20commit%20of%20Admin%0A%09Panel.&In-Reply-To=%3C50996B15.1030803%40gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.">guillomovitch at gmail.com
</A><BR>
<I>Tue Nov 6 20:55:01 CET 2012</I>
<P><UL>
<LI>Previous message: <A HREF="019816.html">[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</A></li>
<LI>Next message: <A HREF="019821.html">[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#19820">[ date ]</a>
<a href="thread.html#19820">[ thread ]</a>
<a href="subject.html#19820">[ subject ]</a>
<a href="author.html#19820">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>Le 06/11/2012 16:33, Matteo Pasotti a écrit :
><i> -----BEGIN PGP SIGNED MESSAGE-----
</I>><i> Hash: SHA1
</I>><i>
</I>><i> On 06/11/2012 13:16, Guillaume Rousse wrote:
</I>>><i> information in every single file, whereas a single top-level README
</I>>><i> file would be enough.
</I>>><i>
</I>><i> Hello Guillaume,
</I>><i>
</I>><i> GPLv2 says:
</I>><i> It is safest to attach them to the start of each source file to most
</I>><i> effectively convey the exclusion of warranty; and each file should
</I>><i> have at least the "copyright" line and a pointer to where the full
</I>><i> notice is found.
</I>><i>
</I>><i> <A HREF="http://www.gnu.org/licenses/gpl-2.0.html">http://www.gnu.org/licenses/gpl-2.0.html</A>
</I>Come on, you really think someone will sue you because running your code
crashed his system, and you have to be that "safe" ? It's a pain to have
to skip multiple lines of legal bullshit before reaching the code, and
you'll need to update a gazillion files in just a few monthes because
we'll change year.
[..]
>>><i> +use Data::Dumper;
</I>>><i> Unused anywere. Don't load debug-related modules in production
</I>>><i> coed.
</I>>><i>
</I>><i> afaik, apanel is not "in production" so what's your concern?.
</I>Don't bloat memory by loading unused modules. Keep your debug code in
your working directory, not in svn.
[..]
>>><i> + +sub ask_for_authentication { + my @args = @ARGV; + my
</I>>>><i> $command = wrap_command($0); + unshift(@args, $command->[2]);
</I>>>><i> + exec { $command->[0] } $command->[1], @args or die ("command
</I>>>><i> %s missing", $command->[0]); + die "You must be root to run
</I>>>><i> this program" if $>; +}
</I>>><i> You're duplicating the condition from previous function here. die
</I>>><i> "You must be root to run this program" if
</I>>><i> !require_root_capability();
</I>>><i>
</I>><i> Don't blame me too much for readability and duplications, please.
</I>><i> I was inspired by /usr/lib/libDrakX/common.pm and other modules that
</I>><i> are not very readable and that contain similar duplications.
</I>I wouldn't consider drakxtools a reference for readability...
--
BOFH excuse #23:
improperly oriented keyboard
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="019816.html">[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</A></li>
<LI>Next message: <A HREF="019821.html">[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#19820">[ date ]</a>
<a href="thread.html#19820">[ thread ]</a>
<a href="subject.html#19820">[ subject ]</a>
<a href="author.html#19820">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
