1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6416%5D%20Initial%20commit%20of%20Admin%0A%09Panel.&In-Reply-To=%3C5098FF94.5010004%40gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="019803.html">
<LINK REL="Next" HREF="019810.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.</H1>
<B>Guillaume Rousse</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6416%5D%20Initial%20commit%20of%20Admin%0A%09Panel.&In-Reply-To=%3C5098FF94.5010004%40gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.">guillomovitch at gmail.com
</A><BR>
<I>Tue Nov 6 13:16:20 CET 2012</I>
<P><UL>
<LI>Previous message: <A HREF="019803.html">[Mageia-dev] Back to our weekly meetings
</A></li>
<LI>Next message: <A HREF="019810.html">[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#19802">[ date ]</a>
<a href="thread.html#19802">[ thread ]</a>
<a href="subject.html#19802">[ subject ]</a>
<a href="author.html#19802">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>Le 06/11/2012 12:09, <A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A> a écrit :
><i> Revision
</I>><i> 6416
</I>><i> Author
</I>><i> tuxta
</I>><i> Date
</I>><i> 2012-11-06 12:09:51 +0100 (Tue, 06 Nov 2012)
</I>><i>
</I>><i>
</I>><i> Log Message
</I>><i>
</I>><i> Initial commit of Admin Panel.
</I>><i> Has basic functionality that you might expect from the core program, escalates priviledges, loads categories and modules dynamically from configuration file, launches modules and returns to the panel once the module has completed. Works within ncurses, gtk and qt environments using the native widget set.
</I>><i>
</I>><i>
</I>><i> Added Paths
</I>><i>
</I>><i> * AdminPanel/trunk/
</I>><i> * AdminPanel/trunk/Auth.pm <#AdminPaneltrunkAuthpm>
</I>><i> * AdminPanel/trunk/Category.pm <#AdminPaneltrunkCategorypm>
</I>><i> * AdminPanel/trunk/ConfigReader.pm <#AdminPaneltrunkConfigReaderpm>
</I>><i> * AdminPanel/trunk/MainDisplay.pm <#AdminPaneltrunkMainDisplaypm>
</I>><i> * AdminPanel/trunk/Module.pm <#AdminPaneltrunkModulepm>
</I>><i> * AdminPanel/trunk/SettingsReader.pm <#AdminPaneltrunkSettingsReaderpm>
</I>><i> * AdminPanel/trunk/apanel.pl <#AdminPaneltrunkapanelpl>
</I>><i> * AdminPanel/trunk/categories.conf <#AdminPaneltrunkcategoriesconf>
</I>><i> * AdminPanel/trunk/extras/
</I>><i> * AdminPanel/trunk/extras/README <#AdminPaneltrunkextrasREADME>
</I>><i> * AdminPanel/trunk/extras/org.freedesktop.policykit.pkexec.policy
</I>><i> <#AdminPaneltrunkextrasorgfreedesktoppolicykitpkexecpolicy>
</I>><i> * AdminPanel/trunk/images/
</I>><i> * AdminPanel/trunk/images/logo_mageia.png
</I>><i> <#AdminPaneltrunkimageslogo_mageiapng>
</I>><i> * AdminPanel/trunk/images/mageia.png <#AdminPaneltrunkimagesmageiapng>
</I>><i> * AdminPanel/trunk/images/quit.png <#AdminPaneltrunkimagesquitpng>
</I>><i> * AdminPanel/trunk/modules/
</I>><i> * AdminPanel/trunk/modules/test.cpp <#AdminPaneltrunkmodulestestcpp>
</I>><i> * AdminPanel/trunk/settings.conf <#AdminPaneltrunksettingsconf>
</I>><i>
</I>><i> Added: AdminPanel/trunk/Auth.pm
</I>><i> ===================================================================
</I>><i> --- AdminPanel/trunk/Auth.pm (rev 0)
</I>><i> +++ AdminPanel/trunk/Auth.pm 2012-11-06 11:09:51 UTC (rev 6416)
</I>><i> @@ -0,0 +1,50 @@
</I>><i> +# Copyright 2012 Matteo Pasotti
</I>><i> +#
</I>><i> +# This file is part of mcc2
</I>><i> +#
</I>><i> +# mcc2 is free software: you can redistribute it and/or modify
</I>><i> +# it under the terms of the GNU General Public License as published by
</I>><i> +# the Free Software Foundation, either version 2 of the License, or
</I>><i> +# (at your option) any later version.
</I>><i> +#
</I>><i> +# mcc2 is distributed in the hope that it will be useful,
</I>><i> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
</I>><i> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
</I>><i> +# GNU General Public License for more details.
</I>><i> +#
</I>><i> +# You should have received a copy of the GNU General Public License
</I>><i> +# along with mcc2. If not, see <<A HREF="http://www.gnu.org/licenses/">http://www.gnu.org/licenses/</A>>.
</I>I'm not convinced of the interest of repeating license and copyright
information in every single file, whereas a single top-level README file
would be enough.
><i> +
</I>><i> +package Auth;
</I>I'm convinced tough than using a shared top-level namespace, for
instance AdminPanel or Mageia::AdminPanel, would be a better idea to
express the idea than this module is a part of a software, than a loose
comment such as "This file is part of mcc2".
package Mageia::AdminPanel::Auth;
><i> +
</I>><i> +require Exporter;
</I>><i> <A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">+ at ISA</A> = qw(Exporter);
</I>You'd rather use a modern perl idiom:
use base qw(Exporter)
or
use parent qw(Exporter);
><i> <A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">+ at EXPORT</A> = qw(require_root_capability
</I>><i> + ask_for_authentication);
</I>><i> +
</I>><i> +use strict;
</I>><i> +use warnings;
</I>><i> +use diagnostics;
</I>Those pragmas should come first, before package variables
><i> +use Data::Dumper;
</I>Unused anywere. Don't load debug-related modules in production coed.
><i> +sub require_root_capability {
</I>><i> + return 0 if(!$>);
</I>><i> + return 1;
</I>><i> +}
</I>Perl best practice: use english name for magic variables, for readability:
use English qw(-no_match_vars );
return 0 if (!$EUID);
And your condition could be expressed in a single statement:
sub require_root_capability {
return $EUID == 0;
}
><i> +
</I>><i> +sub ask_for_authentication {
</I>><i> + my @args = @ARGV;
</I>><i> + my $command = wrap_command($0);
</I>><i> + unshift(@args, $command->[2]);
</I>><i> + exec { $command->[0] } $command->[1], @args or die ("command %s missing", $command->[0]);
</I>><i> + die "You must be root to run this program" if $>;
</I>><i> +}
</I>You're duplicating the condition from previous function here.
die "You must be root to run this program" if
!require_root_capability();
Morevoer, you'd better test before executing the command:
die "You must be root to run this program" if
!require_root_capability();
exec { $command->[0] } $command->[1], @args
or die ("command %s missing", $command->[0]);
><i> +sub wrap_command {
</I>><i> + my $currenv = "env";
</I>><i> + my $wrapper = "pkexec";
</I>><i> + my $app = $0;
</I>><i> + my $command = [$wrapper, $currenv, $app];
</I>><i> + ($command);
</I>><i> +}
</I>Perl best practice: use explicit return statement, for better readability:
return ($command);
Using temporary variables for constant isn't very useful here, the whole
function would probably be more readable this way:
sub wrap_command {
my ($app) = @_;
return (['pkexec', 'env', $app]);
}
I don't understand the need for list contexte here, tough.
BTW, your indentation isn't consistent between various files.
--
BOFH excuse #445:
Browser's cookie is corrupted -- someone's been nibbling on it.
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="019803.html">[Mageia-dev] Back to our weekly meetings
</A></li>
<LI>Next message: <A HREF="019810.html">[Mageia-dev] [soft-commits] [6416] Initial commit of Admin Panel.
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#19802">[ date ]</a>
<a href="thread.html#19802">[ thread ]</a>
<a href="subject.html#19802">[ subject ]</a>
<a href="author.html#19802">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
