1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [packages-commits] [189967] - version upgrade
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bpackages-commits%5D%20%5B189967%5D%20-%20version%20upgrade&In-Reply-To=%3C4F05FE43.2060602%40gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="010990.html">
<LINK REL="Next" HREF="011005.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [packages-commits] [189967] - version upgrade</H1>
<B>Guillaume Rousse</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bpackages-commits%5D%20%5B189967%5D%20-%20version%20upgrade&In-Reply-To=%3C4F05FE43.2060602%40gmail.com%3E"
TITLE="[Mageia-dev] [packages-commits] [189967] - version upgrade">guillomovitch at gmail.com
</A><BR>
<I>Thu Jan 5 20:47:15 CET 2012</I>
<P><UL>
<LI>Previous message: <A HREF="010990.html">[Mageia-dev] [packages-commits] [189967] - version upgrade
</A></li>
<LI>Next message: <A HREF="011005.html">[Mageia-dev] [packages-commits] [189967] - version upgrade
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#10992">[ date ]</a>
<a href="thread.html#10992">[ thread ]</a>
<a href="subject.html#10992">[ subject ]</a>
<a href="author.html#10992">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>Le 05/01/2012 20:36, Matteo a écrit :
><i> -----BEGIN PGP SIGNED MESSAGE-----
</I>><i> Hash: SHA1
</I>><i>
</I>><i> Il 03/01/2012 17:30, Guillaume Rousse ha scritto:
</I>>><i> Le 03/01/2012 17:18, Jani Välimaa a écrit :
</I>>>>><i> @@ -11,7 +11,7 @@
</I>>>>><i> Group: System/Kernel and hardware
</I>>>>><i> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-buildroot
</I>>>>><i> URL: <A HREF="http://www.codemonkey.org.uk/projects/x86info/">http://www.codemonkey.org.uk/projects/x86info/</A>
</I>>>>><i> -Source0: %{name}-%{realver}%{?cvsdate:-%{cvsdate}}.tar.bz2
</I>>>>><i> +Source0: %{name}-%{realver}%{?cvsdate:-%{cvsdate}}.tgz
</I>>>>><i> Patch0: x86info-1.17-intel-flags.patch
</I>>>>><i> Patch1: x86info-1.17-intel-caches.patch
</I>>>>><i> Patch2: x86info-1.17-cpuid-with-ecx-input.patch
</I>>>>><i> @@ -33,17 +33,18 @@
</I>>>>><i> %setup -q -n %{name}-%{realver}
</I>>>>><i>
</I>>>>><i> %build
</I>>>>><i> -make CFLAGS="%{optflags}"
</I>>>>><i> +#make CFLAGS="%{optflags}"
</I>>>>><i> +%make
</I>>>>><i>
</I>>>>><i> %install
</I>>>>><i> -rm -rf %{buildroot}
</I>>>>><i> -install -d %{buildroot}%{_bindir}
</I>>>>><i> -install -d %{buildroot}%{_mandir}/man1
</I>>>>><i> -install -m755 %{name} %{buildroot}%{_bindir}/
</I>>>>><i> -install -m755 %{name}.1 %{buildroot}%{_mandir}/man1/
</I>>>>><i> +%__rm -rf %{buildroot}
</I>>>>><i> +%__install -d %{buildroot}%{_bindir}
</I>>>>><i> +%__install -d %{buildroot}%{_mandir}/man1
</I>>>>><i> +%__install -m755 %{name} %{buildroot}%{_bindir}/
</I>>>>><i> +%__install -m755 %{name}.1 %{buildroot}%{_mandir}/man1/
</I>>>>><i>
</I>>>><i>
</I>>>><i> I think this is pretty much opposite what everyone else is doing. IMHO
</I>>>><i> this also makes .spec harder to read.
</I>>><i> Morevoer, it mixes pure cosmetics changes, as some of those macros just
</I>>><i> expand to the command itself, as install vs %__install,
</I>><i> Hi Guillaume,
</I>><i> I'm sorry, but I don't think that /usr/bin/install it's equal to
</I>><i> 'install'. There are technical reasons to avoid these macros? Can you
</I>><i> suggest me some reference, please? I'm not able to find nothing about
</I>><i> this topic.
</I>Just readability, and consistency with other packages. There is no
advantage to justify this additional complexity here.
><i> with behaviour
</I>>><i> changes, as other macros expand to the command with additional
</I>>><i> arguments, as make vs %make, which is actually make -j.
</I>>><i>
</I>><i> So if I need to invoke make -j what should I do?
</I>><i> Again, excuse me -I'm not so skilled- but why should I avoid to call
</I>><i> make using -j option?
</I>><i>
</I>><i> Be patient, please :-)
</I>You shouldn't. You're supposed to use %make, not 'make' nor '%__make'.
The problem is just to mix cosmetic and non-cosmetic changes in a single
commit.
--
BOFH excuse #281:
The co-locator cannot verify the frame-relay gateway to the ISDN server.
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="010990.html">[Mageia-dev] [packages-commits] [189967] - version upgrade
</A></li>
<LI>Next message: <A HREF="011005.html">[Mageia-dev] [packages-commits] [189967] - version upgrade
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#10992">[ date ]</a>
<a href="thread.html#10992">[ thread ]</a>
<a href="subject.html#10992">[ subject ]</a>
<a href="author.html#10992">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
