1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] Cleaning up GNOME spec files
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20Cleaning%20up%20GNOME%20spec%20files&In-Reply-To=%3C20120215155426.GD1564%40bkor.dhs.org%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="011998.html">
<LINK REL="Next" HREF="012000.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] Cleaning up GNOME spec files</H1>
<B>Olav Vitters</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20Cleaning%20up%20GNOME%20spec%20files&In-Reply-To=%3C20120215155426.GD1564%40bkor.dhs.org%3E"
TITLE="[Mageia-dev] Cleaning up GNOME spec files">olav at vitters.nl
</A><BR>
<I>Wed Feb 15 16:54:26 CET 2012</I>
<P><UL>
<LI>Previous message: <A HREF="011998.html">[Mageia-dev] Cleaning up GNOME spec files
</A></li>
<LI>Next message: <A HREF="012000.html">[Mageia-dev] Cleaning up GNOME spec files
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#11999">[ date ]</a>
<a href="thread.html#11999">[ thread ]</a>
<a href="subject.html#11999">[ subject ]</a>
<a href="author.html#11999">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On Wed, Feb 15, 2012 at 04:43:04PM +0100, Guillaume Rousse wrote:
><i> Le 15/02/2012 15:05, Olav Vitters a écrit :
</I>><i> >What I look at while cleaning up:
</I>><i> >- remove BuildRoot:
</I>><i> >- remove unneeded post/pre
</I>><i> >- ensure everything uses tabs
</I>><i> That's not really cleaning up, that's enforcing your own cosmetic
</I>><i> preferences. Whereas you're perfectly legitimate to manage your own
</I>><i> spec files the way you want, this is slightly more ennoying for
</I>><i> files shipped in those packages, notably the one generated from spec
</I>><i> files through herein documents (for instance, apache, logrotate,
</I>><i> cron files, etc...)
</I>><i>
</I>><i> I'd rally prefer to have a bit more consistency here, not depending
</I>><i> about individual maintainer preferences. Of course, if I'm reacting
</I>><i> here, it's because everyone know than tab sucks :P
</I>
You only mean my tabs comment I assume? I remembered that everything
should be tabs (during mentoring). If up to the maintainer, of course I
won't change it anymore, except if inconsistent.
I noticed some spec files have mostly tabs, except for a few lines. But
have also changed whole spec files to use tabs. Most of the spec files I
look at use tabs.
--
Regards,
Olav
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="011998.html">[Mageia-dev] Cleaning up GNOME spec files
</A></li>
<LI>Next message: <A HREF="012000.html">[Mageia-dev] Cleaning up GNOME spec files
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#11999">[ date ]</a>
<a href="thread.html#11999">[ thread ]</a>
<a href="subject.html#11999">[ subject ]</a>
<a href="author.html#11999">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|