1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6620%5D%20obsoleted%20by%20pod-syntax.t&In-Reply-To=%3CCAONrEtbyh%2BYY1eqDn9jFGDMf%3DG7WErYj9479qfWpCCcNG7cykQ%40mail.gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="020690.html">
<LINK REL="Next" HREF="020692.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t</H1>
<B>Thierry Vignaud</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B6620%5D%20obsoleted%20by%20pod-syntax.t&In-Reply-To=%3CCAONrEtbyh%2BYY1eqDn9jFGDMf%3DG7WErYj9479qfWpCCcNG7cykQ%40mail.gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t">thierry.vignaud at gmail.com
</A><BR>
<I>Sun Dec 9 17:09:21 CET 2012</I>
<P><UL>
<LI>Previous message: <A HREF="020690.html">[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t
</A></li>
<LI>Next message: <A HREF="020692.html">[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#20691">[ date ]</a>
<a href="thread.html#20691">[ thread ]</a>
<a href="subject.html#20691">[ subject ]</a>
<a href="author.html#20691">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On 9 December 2012 17:04, Guillaume Rousse <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">guillomovitch at gmail.com</A>> wrote:
>><i> Yours does nothing:
</I>>><i> t/pod-coverage.t ................................................
</I>>><i> skipped: Author test, set $ENV{TEST_AUTHOR} to a true value to run
</I>>><i> t/pod-spelling.t ................................................
</I>>><i> skipped: Author test, set $ENV{TEST_AUTHOR} to a true value to run
</I>>><i> t/pod-syntax.t ..................................................
</I>>><i> skipped: Author test, set $ENV{TEST_AUTHOR} to a true value to run
</I>><i>
</I>><i> They work if you set the variable, as explicitely reported. That's perfectly
</I>><i> useless to run those tests anywhere else as on developper machine, and
</I>><i> especially during package build. And that's a standard practice in perl
</I>><i> community.
</I>
No, I want pod errors to be found prior submitting them.
And I don't want to manually run several tests.
Before all I had to do was to run "make test" and it reported me
any errors before commiting.
Now it doesn't anymore.
><i> And your claim are quite unfair, given than the previous test didn't
</I>><i> prevented trivial syntax errors to be commited.
</I>
Yes it did.
I provided you the "make test" log proving it.
Yours are not run anymore when running "make test".
What I did fail to mention is that they don't even work with that varible:
[<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at localhost</A> t]# TEST_AUTHOR=test perl pod-coverage.t
You said to run 0 tests at pod-coverage.t line 21.
You don't even have tried them, did you?
><i> Feel free to revert those changes, this kind of discussion isn't worth the
</I>><i> pain.
</I>
Well, if that mean less quality testsuite and if you refuse to answer reviewing,
I'll eventually revert those or at least put back the old working pod test.
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="020690.html">[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t
</A></li>
<LI>Next message: <A HREF="020692.html">[Mageia-dev] [soft-commits] [6620] obsoleted by pod-syntax.t
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#20691">[ date ]</a>
<a href="thread.html#20691">[ thread ]</a>
<a href="subject.html#20691">[ subject ]</a>
<a href="author.html#20691">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
