1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] broken format-error test ?
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20broken%20format-error%20test%20%3F&In-Reply-To=%3CCA%2BCX%2BbhP0jNnQJwxjrA%2BT%3DmBaQGe1q1-g2HXb20HSag6vi-CCw%40mail.gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="018064.html">
<LINK REL="Next" HREF="018071.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] broken format-error test ?</H1>
<B>Pascal Terjan</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20broken%20format-error%20test%20%3F&In-Reply-To=%3CCA%2BCX%2BbhP0jNnQJwxjrA%2BT%3DmBaQGe1q1-g2HXb20HSag6vi-CCw%40mail.gmail.com%3E"
TITLE="[Mageia-dev] broken format-error test ?">pterjan at gmail.com
</A><BR>
<I>Sun Aug 12 00:55:24 CEST 2012</I>
<P><UL>
<LI>Previous message: <A HREF="018064.html">[Mageia-dev] broken format-error test ?
</A></li>
<LI>Next message: <A HREF="018071.html">[Mageia-dev] broken format-error test ?
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#18065">[ date ]</a>
<a href="thread.html#18065">[ thread ]</a>
<a href="subject.html#18065">[ subject ]</a>
<a href="author.html#18065">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On Sat, Aug 11, 2012 at 11:45 PM, Pascal Terjan <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">pterjan at gmail.com</A>> wrote:
><i> On Sat, Aug 11, 2012 at 11:41 PM, Pascal Terjan <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">pterjan at gmail.com</A>> wrote:
</I>>><i> On Sat, Aug 11, 2012 at 11:32 PM, Guillaume Rousse
</I>>><i> <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">guillomovitch at gmail.com</A>> wrote:
</I>>>><i> Hello list.
</I>>>><i>
</I>>>><i> While trying to rebuild mod_ruby, I get this error:
</I>>>><i> mod_ruby.c:507:5: erreur: le format n'est pas une chaīne littérale et pas
</I>>>><i> d'argument de format [-Werror=format-security]
</I>>>><i>
</I>>>><i> The line 505 is;
</I>>>><i> vsnprintf(buf, BUFSIZ, fmt, args);
</I>>>><i>
</I>>>><i> Apparently, the test fails to recognize the 'fmt' variable as the format...
</I>>><i>
</I>>><i> Well, it complains that fmt is a variable, which is the point of the
</I>>><i> test, so it is not broken
</I>>><i> Only constant formats are allowed
</I>><i>
</I>><i> Ah no sorry, it should accept a variable when there are arguments.
</I>
The full log, which explains the problem:
mod_ruby.c: In function 'ruby_log_error':
mod_ruby.c:507:5: warning: passing argument 5 of 'ap_log_error_' makes
integer from pointer without a cast [enabled by default]
In file included from mod_ruby.h:104:0,
from mod_ruby.c:33:
/usr/include/httpd/http_log.h:372:18: note: expected 'apr_status_t'
but argument is of type 'const struct server_rec *'
mod_ruby.c:507:5: warning: passing argument 6 of 'ap_log_error_' from
incompatible pointer type [enabled by default]
In file included from mod_ruby.h:104:0,
from mod_ruby.c:33:
/usr/include/httpd/http_log.h:372:18: note: expected 'const struct
server_rec *' but argument is of type 'char *'
mod_ruby.c:507:5: error: format not a string literal and no format
arguments [-Werror=format-security]
The error is not on the line 505 but 507:
ap_log_error(file, line, level, 0, s, "mod_ruby: %s", buf);
Which is defined as:
AP_DECLARE(void) ap_log_error_(const char *file, int line, int module_index,
int level, apr_status_t status,
const server_rec *s, const char *fmt, ...)
__attribute__((format(printf,7,8)));
so the call is missing module_index, parameters are shiffted and buf
is considered to be the format.
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="018064.html">[Mageia-dev] broken format-error test ?
</A></li>
<LI>Next message: <A HREF="018071.html">[Mageia-dev] broken format-error test ?
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#18065">[ date ]</a>
<a href="thread.html#18065">[ thread ]</a>
<a href="subject.html#18065">[ subject ]</a>
<a href="author.html#18065">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
