blob: 2d2c2fb0a2551dc948e9f888d4f5f7f3c2a73e56 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [4252] fix removing several notebook pages
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4252%5D%20fix%20removing%20several%0A%09notebook%20pages&In-Reply-To=%3CCA%2BCX%2BbgLsp225D-UeWa0RwFDsFJJ%2BgXXX%3DVve2eAdtPhJ5KxKg%40mail.gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="014760.html">
<LINK REL="Next" HREF="014758.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [4252] fix removing several notebook pages</H1>
<B>Pascal Terjan</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4252%5D%20fix%20removing%20several%0A%09notebook%20pages&In-Reply-To=%3CCA%2BCX%2BbgLsp225D-UeWa0RwFDsFJJ%2BgXXX%3DVve2eAdtPhJ5KxKg%40mail.gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [4252] fix removing several notebook pages">pterjan at gmail.com
</A><BR>
<I>Wed Apr 25 11:35:43 CEST 2012</I>
<P><UL>
<LI>Previous message: <A HREF="014760.html">[Mageia-dev] [soft-commits] [4252] fix removing several notebook pages
</A></li>
<LI>Next message: <A HREF="014758.html">[Mageia-dev] [soft-commits] [4243] services: Whitespace
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#14771">[ date ]</a>
<a href="thread.html#14771">[ thread ]</a>
<a href="subject.html#14771">[ subject ]</a>
<a href="author.html#14771">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On Wed, Apr 25, 2012 at 09:15, Guillaume Rousse <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">guillomovitch at gmail.com</A>> wrote:
><i> Le 25/04/2012 09:56, Thierry Vignaud a écrit :
</I>><i>
</I>>><i> On 24 April 2012 23:17,<<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>>  wrote:
</I>>>><i>
</I>>>><i> fix removing several notebook pages
</I>>><i>
</I>>><i>
</I>>><i> (...)
</I>>><i>
</I>>>><i> --- drakx/trunk/perl-install/diskdrake/hd_gtk.pm        2012-04-24
</I>>>><i> 20:10:47 UTC
</I>>>><i> (rev 4251)
</I>>>><i> +++ drakx/trunk/perl-install/diskdrake/hd_gtk.pm        2012-04-24
</I>>>><i> 21:17:30 UTC
</I>>>><i> (rev 4252)
</I>>>><i> @@ -285,9 +285,15 @@
</I>>>><i>      $may_add->(raid2kind()) if @{$all_hds->{raids}};
</I>>>><i>      $may_add->(loopback2kind()) if @{$all_hds->{loopbacks}};
</I>>>><i>
</I>>>><i> -    @notebook = grep_index {
</I>>>><i> -       my $b = $_->{marked} or $notebook_widget->remove_page($::i);
</I>>>><i> -       $b;
</I>>>><i> +    my $i = 0;
</I>>>><i> +    @notebook = grep {
</I>>>><i> +       if ($_->{marked}) {
</I>>>><i> +           $i++;
</I>>>><i> +           1;
</I>>>><i> +       } else {
</I>>>><i> +           $notebook_widget->remove_page($i);
</I>>>><i> +           0;
</I>>>><i> +       }
</I>>><i>
</I>>><i>
</I>>><i> Wouldn't have been simpler to decrease $::i instead?
</I>
Yes but I really don't like grep_index using a global variable (so not
being reentrant) and I think it would make it even less obvious to
read.
I doubt anyone will add a callback on remove_page using grep_index or
$::i but still I prefer to be safe.
><i> I'm more concerned about the ugly mix between variable affectation (
</I>><i> @notebook = grep {} @list) and additional concerns hidden inside
</I>><i> ($notebook_widget->remove_page($i) ). And explicit loop would be easier to
</I>><i> understand, and less error-prone:
</I>><i>
</I>><i> my @notebook;
</I>><i> my $i = 0;
</I>><i> foreach my $notebook (@list) {
</I>><i>    if ($notebook->{marked}) {
</I>><i>        push @notebook, $notebook;
</I>><i>        $i++;
</I>><i>    } else {
</I>><i>        $notebook_widget->remove_page($i);
</I>><i>    }
</I>><i> }
</I>><i>
</I>
In this case, @list is @notebook so you would need another list (we
are filtering @notebook but removing matching element from
$notebook_widget when removing one from @notebook)
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="014760.html">[Mageia-dev] [soft-commits] [4252] fix removing several notebook pages
</A></li>
<LI>Next message: <A HREF="014758.html">[Mageia-dev] [soft-commits] [4243] services: Whitespace
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#14771">[ date ]</a>
<a href="thread.html#14771">[ thread ]</a>
<a href="subject.html#14771">[ subject ]</a>
<a href="author.html#14771">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
