zarb-ml/mageia-dev/2012-April/013940.html


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
 <HEAD>
   <TITLE> [Mageia-dev] [soft-commits] [3964] Fix partition numbering on	GPT (mga#3091)
   </TITLE>
   <LINK REL="Index" HREF="index.html" >
   <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B3964%5D%20Fix%20partition%20numbering%20on%0A%09GPT%20%28mga%233091%29&In-Reply-To=%3CCAONrEtaY5s-p26Ed5b4ts8MkaWNgWsNUMheVi9oUOt-yt6w6Fw%40mail.gmail.com%3E">
   <META NAME="robots" CONTENT="index,nofollow">
   <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
   <LINK REL="Previous"  HREF="013938.html">
   <LINK REL="Next"  HREF="013943.html">
 </HEAD>
 <BODY BGCOLOR="#ffffff">
   <H1>[Mageia-dev] [soft-commits] [3964] Fix partition numbering on	GPT (mga#3091)</H1>
    <B>Thierry Vignaud</B> 
    <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B3964%5D%20Fix%20partition%20numbering%20on%0A%09GPT%20%28mga%233091%29&In-Reply-To=%3CCAONrEtaY5s-p26Ed5b4ts8MkaWNgWsNUMheVi9oUOt-yt6w6Fw%40mail.gmail.com%3E"
       TITLE="[Mageia-dev] [soft-commits] [3964] Fix partition numbering on	GPT (mga#3091)">thierry.vignaud at gmail.com
       </A><BR>
    <I>Fri Apr  6 09:58:06 CEST 2012</I>
    <P><UL>
        <LI>Previous message: <A HREF="013938.html">[Mageia-dev] Latest upgrade testing
</A></li>
        <LI>Next message: <A HREF="013943.html">[Mageia-dev] [soft-commits] [3964] Fix partition numbering on GPT (mga#3091)
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#13940">[ date ]</a>
              <a href="thread.html#13940">[ thread ]</a>
              <a href="subject.html#13940">[ subject ]</a>
              <a href="author.html#13940">[ author ]</a>
         </LI>
       </UL>
    <HR>  
<!--beginarticle-->
<PRE>On 6 April 2012 00:00,  &lt;<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>&gt; wrote:
&gt;<i> Fix partition numbering on GPT (mga#3091)
</I>
(...)

&gt;<i> @@ -27,9 +28,20 @@
</I>&gt;<i>              $p{start} = $5;
</I>&gt;<i>              $p{size} = $7;
</I>&gt;<i>          }
</I>&gt;<i> -        \%p;
</I>&gt;<i> +        $p{part_number} =&gt; \%p;
</I>&gt;<i>      } c::get_disk_partitions($hd-&gt;{file});
</I>&gt;<i>
</I>&gt;<i> +    my @pt = map {
</I>&gt;<i> +	my $part_number = $_;
</I>&gt;<i> +	if ($parts{$part_number}) {
</I>&gt;<i> +	    $parts{$part_number};
</I>&gt;<i> +	} else {
</I>&gt;<i> +	    my %p;
</I>&gt;<i> +	    $p{part_number} = $part_number;
</I>&gt;<i> +	    \%p;
</I>
This is simpler &amp; more readable:

{ part_number =&gt; $part_number };

anyway it would be maybe simpler go one of the way I attach.
WDYT?

&gt;<i>     [ @pt ], $info;
</I>

And this could be better:

    \@pt, $info;

BTW, a &quot;require common&quot; would be needed b/c of common::sync() even
if all users already loaded it before, for sanity &amp; perl_checker.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.diff
Type: application/octet-stream
Size: 534 bytes
Desc: not available
URL: &lt;/pipermail/mageia-dev/attachments/20120406/427b6f6a/attachment.obj&gt;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2.diff
Type: application/octet-stream
Size: 547 bytes
Desc: not available
URL: &lt;/pipermail/mageia-dev/attachments/20120406/427b6f6a/attachment-0001.obj&gt;
</PRE>


<!--endarticle-->
    <HR>
    <P><UL>
        <!--threads-->
	<LI>Previous message: <A HREF="013938.html">[Mageia-dev] Latest upgrade testing
</A></li>
	<LI>Next message: <A HREF="013943.html">[Mageia-dev] [soft-commits] [3964] Fix partition numbering on GPT (mga#3091)
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#13940">[ date ]</a>
              <a href="thread.html#13940">[ thread ]</a>
              <a href="subject.html#13940">[ subject ]</a>
              <a href="author.html#13940">[ author ]</a>
         </LI>
       </UL>

<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>