summaryrefslogtreecommitdiffstats
path: root/zarb-ml/mageia-dev/2012-April/013882.html
blob: ce77550815caeb4e20f3d6183d6c6d0d37413e3d (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
 <HEAD>
   <TITLE> [Mageia-dev] [soft-commits] [3909] Drop check_chroot
   </TITLE>
   <LINK REL="Index" HREF="index.html" >
   <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B3909%5D%20Drop%20check_chroot&In-Reply-To=%3CCA%2BCX%2BbgXXfNpK93hrmSGikfh8JLVuanchBuXUdxje7BhWS%2BSpQ%40mail.gmail.com%3E">
   <META NAME="robots" CONTENT="index,nofollow">
   <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
   <LINK REL="Previous"  HREF="013876.html">
   <LINK REL="Next"  HREF="013877.html">
 </HEAD>
 <BODY BGCOLOR="#ffffff">
   <H1>[Mageia-dev] [soft-commits] [3909] Drop check_chroot</H1>
    <B>Pascal Terjan</B> 
    <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B3909%5D%20Drop%20check_chroot&In-Reply-To=%3CCA%2BCX%2BbgXXfNpK93hrmSGikfh8JLVuanchBuXUdxje7BhWS%2BSpQ%40mail.gmail.com%3E"
       TITLE="[Mageia-dev] [soft-commits] [3909] Drop check_chroot">pterjan at gmail.com
       </A><BR>
    <I>Wed Apr  4 10:35:21 CEST 2012</I>
    <P><UL>
        <LI>Previous message: <A HREF="013876.html">[Mageia-dev] [soft-commits] [3909] Drop check_chroot
</A></li>
        <LI>Next message: <A HREF="013877.html">[Mageia-dev] [soft-commits] [3888] Request Core instead of Main	when using --distrib
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#13882">[ date ]</a>
              <a href="thread.html#13882">[ thread ]</a>
              <a href="subject.html#13882">[ subject ]</a>
              <a href="author.html#13882">[ author ]</a>
         </LI>
       </UL>
    <HR>  
<!--beginarticle-->
<PRE>On Wed, Apr 4, 2012 at 09:01, Thierry Vignaud &lt;<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">thierry.vignaud at gmail.com</A>&gt;wrote:

&gt;<i> On 4 April 2012 01:01,  &lt;<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>&gt; wrote:
</I>&gt;<i> &gt; Revision 3909 Author pterjan Date 2012-04-04 01:01:59 +0200 (Wed, 04 Apr
</I>&gt;<i> &gt; 2012)
</I>&gt;<i> &gt;
</I>&gt;<i> &gt; Log Message
</I>&gt;<i> &gt;
</I>&gt;<i> &gt; Drop check_chroot
</I>&gt;<i>
</I>&gt;<i> A minor comment: it hasn't actually been dropped
</I>&gt;<i> I think a better changelog would have been:
</I>&gt;<i>
</I>&gt;<i> &quot;(check_chroot) merge it in check_build_chroot()&quot;
</I>&gt;<i>
</I>
Indeed, I'll improve log messages


&gt;<i> Also, you didn't comment the call to create_build_chroot() instead
</I>&gt;<i> of to create_chroot().
</I>&gt;<i>
</I>
Indeed, this was an extension of the change I amended before commit when I
noticed the call with those options that I was moving had a dedicated
function.
I should probably have done another commit

Not that it matters a lot since create_build_chroot() got killed a little
&gt;<i> later but it would make history easier to read in 6 months (which it
</I>&gt;<i> is already not for previous years :-( )
</I>&gt;<i>
</I>-------------- next part --------------
An HTML attachment was scrubbed...
URL: &lt;/pipermail/mageia-dev/attachments/20120404/d21fc6fd/attachment-0001.html&gt;
</PRE>
















<!--endarticle-->
    <HR>
    <P><UL>
        <!--threads-->
	<LI>Previous message: <A HREF="013876.html">[Mageia-dev] [soft-commits] [3909] Drop check_chroot
</A></li>
	<LI>Next message: <A HREF="013877.html">[Mageia-dev] [soft-commits] [3888] Request Core instead of Main	when using --distrib
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#13882">[ date ]</a>
              <a href="thread.html#13882">[ thread ]</a>
              <a href="subject.html#13882">[ subject ]</a>
              <a href="author.html#13882">[ author ]</a>
         </LI>
       </UL>

<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>