1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [3909] Drop check_chroot
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B3909%5D%20Drop%20check_chroot&In-Reply-To=%3CCAONrEtaj0OvzwQtnB8EYwUL-ep7HfErJSMha8OfeqjAsywBTsw%40mail.gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="013875.html">
<LINK REL="Next" HREF="013882.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [3909] Drop check_chroot</H1>
<B>Thierry Vignaud</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B3909%5D%20Drop%20check_chroot&In-Reply-To=%3CCAONrEtaj0OvzwQtnB8EYwUL-ep7HfErJSMha8OfeqjAsywBTsw%40mail.gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [3909] Drop check_chroot">thierry.vignaud at gmail.com
</A><BR>
<I>Wed Apr 4 10:01:08 CEST 2012</I>
<P><UL>
<LI>Previous message: <A HREF="013875.html">[Mageia-dev] [changelog] [RPM] cauldron core/release mysql-workbench-5.2.36-2.mga2
</A></li>
<LI>Next message: <A HREF="013882.html">[Mageia-dev] [soft-commits] [3909] Drop check_chroot
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#13876">[ date ]</a>
<a href="thread.html#13876">[ thread ]</a>
<a href="subject.html#13876">[ subject ]</a>
<a href="author.html#13876">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On 4 April 2012 01:01, <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>> wrote:
><i> Revision 3909 Author pterjan Date 2012-04-04 01:01:59 +0200 (Wed, 04 Apr
</I>><i> 2012)
</I>><i>
</I>><i> Log Message
</I>><i>
</I>><i> Drop check_chroot
</I>
A minor comment: it hasn't actually been dropped
I think a better changelog would have been:
"(check_chroot) merge it in check_build_chroot()"
Also, you didn't comment the call to create_build_chroot() instead
of to create_chroot().
Not that it matters a lot since create_build_chroot() got killed a little
later but it would make history easier to read in 6 months (which it
is already not for previous years :-( )
Thx for cleaning this btw
><i> @@ -414,13 +413,6 @@
</I>><i> sub check_build_chroot {
</I>><i> my ($chroot, $chroot_tar, $run, $config) = @_;
</I>><i>
</I>><i> - check_chroot($chroot, $chroot_tar, $run, $config,
</I>><i> - { packages => $config->{basesystem_packages} });
</I>><i> -}
</I>><i> -
</I>><i> -sub check_chroot {
</I>><i> - my ($chroot, $chroot_tar, $run, $config, $opt) = @_;
</I>><i> -
</I>><i> plog('DEBUG', "checking basesystem tar");
</I>><i>
</I>><i> my (@stat) = stat $chroot_tar;
</I>><i> @@ -429,7 +421,7 @@
</I>><i> plog('WARN', "chroot tarball too old, force rebuild");
</I>><i> sudo($config, '--rm', '-r', $chroot, $chroot_tar);
</I>><i> }
</I>><i> - create_chroot($chroot, $chroot_tar, $run, $config, $opt);
</I>><i> + create_build_chroot($chroot, $chroot_tar, $run, $config);
</I></PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="013875.html">[Mageia-dev] [changelog] [RPM] cauldron core/release mysql-workbench-5.2.36-2.mga2
</A></li>
<LI>Next message: <A HREF="013882.html">[Mageia-dev] [soft-commits] [3909] Drop check_chroot
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#13876">[ date ]</a>
<a href="thread.html#13876">[ thread ]</a>
<a href="subject.html#13876">[ subject ]</a>
<a href="author.html#13876">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
