blob: b1036f3c8de88b20d8dafa3bd497c7e4d7079bdb (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [2134] Do not include chroot path in symlink.
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B2134%5D%20Do%20not%20include%20chroot%20path%0A%09in%20symlink.&In-Reply-To=%3C4EB804A5.2030008%40mandriva.org%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="009392.html">
<LINK REL="Next" HREF="009393.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [2134] Do not include chroot path in symlink.</H1>
<B>Colin Guthrie</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B2134%5D%20Do%20not%20include%20chroot%20path%0A%09in%20symlink.&In-Reply-To=%3C4EB804A5.2030008%40mandriva.org%3E"
TITLE="[Mageia-dev] [soft-commits] [2134] Do not include chroot path in symlink.">cguthrie at mandriva.org
</A><BR>
<I>Mon Nov 7 17:17:41 CET 2011</I>
<P><UL>
<LI>Previous message: <A HREF="009392.html">[Mageia-dev] [soft-commits] [2134] Do not include chroot path in symlink.
</A></li>
<LI>Next message: <A HREF="009393.html">[Mageia-dev] [changelog] [RPM] cauldron core/release digikam-2.3.0-1.mga2
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#9396">[ date ]</a>
<a href="thread.html#9396">[ thread ]</a>
<a href="subject.html#9396">[ subject ]</a>
<a href="author.html#9396">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>'Twas brillig, and Thierry Vignaud at 07/11/11 15:31 did gyre and gimble:
><i> On 7 November 2011 13:58, <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>> wrote:
</I>>><i> Modified: drakx-kbd-mouse-x11/trunk/lib/Xconfig/various.pm
</I>>><i> ===================================================================
</I>>><i> --- drakx-kbd-mouse-x11/trunk/lib/Xconfig/various.pm 2011-11-07 12:48:52 UTC
</I>>><i> (rev 2133)
</I>>><i> +++ drakx-kbd-mouse-x11/trunk/lib/Xconfig/various.pm 2011-11-07 12:58:09 UTC
</I>>><i> (rev 2134)
</I>>><i> @@ -227,8 +227,8 @@
</I>>><i> -r $f or log::l("missing inittab!!!"), return;
</I>>><i> if ($o_runlevel) {
</I>>><i> substInFile { s/^id:\d:initdefault:\s*$/id:$o_runlevel:initdefault:\n/ }
</I>>><i> $f if !$::testing;
</I>>><i> - my $t = "$::prefix/lib/systemd/system/runlevel$o_runlevel.target";
</I>>><i> - if (!$::testing && -f $t) {
</I>>><i> + my $t = "/lib/systemd/system/runlevel$o_runlevel.target";
</I>>><i> + if (!$::testing && -f "$::prefix$t") {
</I>>><i> my $d = "$::prefix/etc/systemd/system/default.target";
</I>>><i> unlink($d);
</I>>><i> symlink($t, $d);
</I>><i>
</I>><i> BTW, you could have come with better names instead of 't' & 'd'....
</I>
I was just following the "convention" that was in the surrounding code
that used a single letter name for the file variable.
As I don't code on this stuff (and certainly am not a perl coder) I
didn't want to change things too much to suite my own preferences for
coding style (which would have been to use more descriptive names) and
followed what appeared to be the status quo.
Col
--
Colin Guthrie
colin(at)mageia.org
<A HREF="http://colin.guthr.ie/">http://colin.guthr.ie/</A>
Day Job:
Tribalogic Limited <A HREF="http://www.tribalogic.net/">http://www.tribalogic.net/</A>
Open Source:
Mageia Contributor <A HREF="http://www.mageia.org/">http://www.mageia.org/</A>
PulseAudio Hacker <A HREF="http://www.pulseaudio.org/">http://www.pulseaudio.org/</A>
Trac Hacker <A HREF="http://trac.edgewall.org/">http://trac.edgewall.org/</A>
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="009392.html">[Mageia-dev] [soft-commits] [2134] Do not include chroot path in symlink.
</A></li>
<LI>Next message: <A HREF="009393.html">[Mageia-dev] [changelog] [RPM] cauldron core/release digikam-2.3.0-1.mga2
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#9396">[ date ]</a>
<a href="thread.html#9396">[ thread ]</a>
<a href="subject.html#9396">[ subject ]</a>
<a href="author.html#9396">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
