1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] get-skype package for submission
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF3FC51.80706%40zen.co.uk%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="005412.html">
<LINK REL="Next" HREF="005439.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] get-skype package for submission</H1>
<B>Barry Jackson</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF3FC51.80706%40zen.co.uk%3E"
TITLE="[Mageia-dev] get-skype package for submission">zen25000 at zen.co.uk
</A><BR>
<I>Sun Jun 12 01:37:53 CEST 2011</I>
<P><UL>
<LI>Previous message: <A HREF="005412.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI>Next message: <A HREF="005439.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#5414">[ date ]</a>
<a href="thread.html#5414">[ thread ]</a>
<a href="subject.html#5414">[ subject ]</a>
<a href="author.html#5414">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On 11/06/11 18:03, Anssi Hannula wrote:
><i> OK, here goes :)
</I>><i>
</I>><i> - I see you didn't get what I meant with the versionized filelist files.
</I>><i> The idea was that if someone updates the package to a new skype
</I>><i> version, the rpmbuild process would fail if one didn't touch the
</I>><i> filelist files. With your changes such a failure doesn't happen.
</I>><i> You need to use lang-%{version}.txt instead, so that when someone
</I>><i> updates %version, it will automatically start failing until the lang
</I>><i> list file is updated/moved.
</I>
I did follow - just had brain fail when implementing it - sorted now.
><i>
</I>><i> - Best to add a comment in the %post script to remind that any new files
</I>><i> need to have a %ghost entry created.
</I>><i> (btw: an alternative idea is to create a post-script and the filelist
</I>><i> at the same time in a single for loop in %build/%install, so that
</I>><i> the lists can never get out of sync as they are created from a single
</I>><i> list; however, your current solution is adequate as well)
</I>
Note added - keep it simple.
><i>
</I>><i> - Why define %tmpextdir instead of using $newtmp directly? Quite
</I>><i> confusing as %variables are defined at build-time while $variables
</I>><i> at run-time.
</I>
Quite ! - Fixed.
><i>
</I>><i> - You don't check for failures. If the mktemp call fails, you extract
</I>><i> the tarball into /root etc.etc.. You need to check for failures on
</I>><i> the mktemp/mkdir/cd commands (mktemp failure can be detected by
</I>><i> checking if $newtmp string is empty), or alternatively run "set -e"
</I>><i> to make the shell exit on failures (this leaves the tmpdir polluted,
</I>><i> but it doesn't matter as much as it is an uncommon failure case and
</I>><i> /tmp is cleaned periodically anyway).
</I>
Added some checks - with clean-up of previously created dirs etc on fail.
><i>
</I>><i> - Dot in Summary.
</I>
?? I don't see one.
><i>
</I>><i> - Noarch seems wrong to me.
</I>
Pass. I wondered about that. It uses 32 bit libs in both arch, and
seems to test OK in both, but I am open to suggestions.
Barry
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: get-skype.spec
URL: </pipermail/mageia-dev/attachments/20110612/addf59a4/attachment.ksh>
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="005412.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI>Next message: <A HREF="005439.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#5414">[ date ]</a>
<a href="thread.html#5414">[ thread ]</a>
<a href="subject.html#5414">[ subject ]</a>
<a href="author.html#5414">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
