1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] get-skype package for submission
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF39FCE.2070809%40iki.fi%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="005411.html">
<LINK REL="Next" HREF="005414.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] get-skype package for submission</H1>
<B>Anssi Hannula</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF39FCE.2070809%40iki.fi%3E"
TITLE="[Mageia-dev] get-skype package for submission">anssi.hannula at iki.fi
</A><BR>
<I>Sat Jun 11 19:03:10 CEST 2011</I>
<P><UL>
<LI>Previous message: <A HREF="005411.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI>Next message: <A HREF="005414.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#5412">[ date ]</a>
<a href="thread.html#5412">[ thread ]</a>
<a href="subject.html#5412">[ subject ]</a>
<a href="author.html#5412">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On 11.06.2011 19:13, Barry Jackson wrote:
><i> On 11/06/11 09:14, Anssi Hannula wrote:
</I>><i> ---------snip---------
</I>>><i> Probably the easiest way is to use a fixed location under
</I>>><i> %{_localstatedir}/lib/%{name} for the tarball instead. Then you can use
</I>>><i> mktemp locally in %post.
</I>>><i>
</I>>><i> Also, is there a need to use -q for mktemp?
</I>>><i>
</I>><i>
</I>><i> Thanks - that works fine and is certainly the least complicated way to
</I>><i> do this. I could have created a script for use in %post while in %pre,
</I>><i> but it would have made the spec harder to read.
</I>><i>
</I>><i> I have dealt with all the points you raised in the attached spec which
</I>><i> is working OK.
</I>><i> Please dissect it and comment again if you see any blunders ;)
</I>><i>
</I>><i> I will update the tar.gz in the bug report with this latest version.
</I>
OK, here goes :)
- I see you didn't get what I meant with the versionized filelist files.
The idea was that if someone updates the package to a new skype
version, the rpmbuild process would fail if one didn't touch the
filelist files. With your changes such a failure doesn't happen.
You need to use lang-%{version}.txt instead, so that when someone
updates %version, it will automatically start failing until the lang
list file is updated/moved.
- Best to add a comment in the %post script to remind that any new files
need to have a %ghost entry created.
(btw: an alternative idea is to create a post-script and the filelist
at the same time in a single for loop in %build/%install, so that
the lists can never get out of sync as they are created from a single
list; however, your current solution is adequate as well)
- Why define %tmpextdir instead of using $newtmp directly? Quite
confusing as %variables are defined at build-time while $variables
at run-time.
- You don't check for failures. If the mktemp call fails, you extract
the tarball into /root etc.etc.. You need to check for failures on
the mktemp/mkdir/cd commands (mktemp failure can be detected by
checking if $newtmp string is empty), or alternatively run "set -e"
to make the shell exit on failures (this leaves the tmpdir polluted,
but it doesn't matter as much as it is an uncommon failure case and
/tmp is cleaned periodically anyway).
- Dot in Summary.
- Noarch seems wrong to me.
--
Anssi Hannula
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="005411.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI>Next message: <A HREF="005414.html">[Mageia-dev] get-skype package for submission
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#5412">[ date ]</a>
<a href="thread.html#5412">[ thread ]</a>
<a href="subject.html#5412">[ subject ]</a>
<a href="author.html#5412">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
