1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] Some more new rpmlint warning on upload
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20Some%20more%20new%20rpmlint%20warning%20on%20upload&In-Reply-To=%3C1311766669.2114.50.camel%40akroma.ephaone.org%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="007049.html">
<LINK REL="Next" HREF="007059.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] Some more new rpmlint warning on upload</H1>
<B>Michael Scherer</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20Some%20more%20new%20rpmlint%20warning%20on%20upload&In-Reply-To=%3C1311766669.2114.50.camel%40akroma.ephaone.org%3E"
TITLE="[Mageia-dev] Some more new rpmlint warning on upload">misc at zarb.org
</A><BR>
<I>Wed Jul 27 13:37:48 CEST 2011</I>
<P><UL>
<LI>Previous message: <A HREF="007049.html">[Mageia-dev] [RPM] cauldron core/release php-pear-Horde_Crypt-1.0.3-3.mga2
</A></li>
<LI>Next message: <A HREF="007059.html">[Mageia-dev] Some more new rpmlint warning on upload
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#7057">[ date ]</a>
<a href="thread.html#7057">[ thread ]</a>
<a href="subject.html#7057">[ subject ]</a>
<a href="author.html#7057">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>Hi,
while investigating something almost unrelated I ran rpmlint on the
whole distribution and noticed there is several problems that should not
be there.
So I propose to add the following warning in the list of error blocking
upload :
* non-standard-group
This one cause problem in rpmdrake display ( among others ), as this add
category with 1 single package. There is no false positives.
* empty-%postun / empty-%post
While these do not do any harm, they are likely the sign of a package
that was not properly cleaned. So by blocking upload, we ensure that's
clean enough.
* useless-provides
that's when foo provide foo. There is no case where it would needed.
* invalid-desktopfile
rpmlint run desktop-file-validate, and any invalid file is detected.
Invalid file will in the best case work fine, and in the worst case, not
work. So better be safe and fix the file.
There is also some more controversial :
* file-not-in-%lang
this will result in more disk space used for file that are not needed
( like locales, etc ). However, this can be annoying to fix, and not a
widespread errors.
*
while having foo.c~ or #.foo.c are not causing problem, this usually
take space for nothing. But since the problem is often in upstream
tarball, this can be tricky to fix.
* version-control-internal-file
same as previous, but there is maybe some use case, that should then be
added to exception
* standard-dir-owned-by-package
some package ( like gromacs ) do created /usr/bin/. This is unclean and
should be blocked. On the other hand, the problem are mostly theoric
( like "having a directory with 2 differents modes or owners ).
* unknown-lsb-keyword
as we use lsb in initscript ( and systemd support it ), I think this one
could be quite important. For example :
heartbeat.i586: W: unknown-lsb-keyword # Should-stop: openhpid
This likely hide real bugs. I would also add :
* missing-lsb-keyword
* malformed-line-in-lsb-comment-block
I also found some stuff that would cause real problem :
hunspell-ca.noarch: W:
world-writable /usr/share/doc/hunspell-ca/LICENSES-en.txt 0666
Yet, there is maybe some good case to have a file to be world writable ?
Or :
hdf-java.i586: W: non-readable /usr/share/java/fits.jar 0700
There is also some good case to have a file non-readable, but in /usr,
there is none. ( and in this case, this seems like the package is broken
)
So, to summarize, the proposal is :
- block upload on :
* missing-lsb-keyword
* malformed-line-in-lsb-comment-block
* useless-provides
* non-standard-group
* empty-%postun
* empty-%post
* invalid-desktopfile
* unknown-lsb-keyword
* standard-dir-owned-by-package
discuss for blocking :
* backup-file-in-package
* version-control-internal-file
discuss and find a list of exceptions for :
* world-writable
* non-readable
( especially the non-readable part ).
If no one protest, the 1st list will be added before I take my vacation,
in a few days.
--
Michael Scherer
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="007049.html">[Mageia-dev] [RPM] cauldron core/release php-pear-Horde_Crypt-1.0.3-3.mga2
</A></li>
<LI>Next message: <A HREF="007059.html">[Mageia-dev] Some more new rpmlint warning on upload
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#7057">[ date ]</a>
<a href="thread.html#7057">[ thread ]</a>
<a href="subject.html#7057">[ subject ]</a>
<a href="author.html#7057">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
