1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] [soft-commits] [2359] coding style update (perl_checker)
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B2359%5D%20coding%20style%20update%0A%09%28perl_checker%29&In-Reply-To=%3CCANa9xwsSs8QDB4Bdf1TqSNMf5ud5EKYo-iMHEE8VJ9s-_iUTFg%40mail.gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="010333.html">
<LINK REL="Next" HREF="010342.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] [soft-commits] [2359] coding style update (perl_checker)</H1>
<B>Romain d'Alverny</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B2359%5D%20coding%20style%20update%0A%09%28perl_checker%29&In-Reply-To=%3CCANa9xwsSs8QDB4Bdf1TqSNMf5ud5EKYo-iMHEE8VJ9s-_iUTFg%40mail.gmail.com%3E"
TITLE="[Mageia-dev] [soft-commits] [2359] coding style update (perl_checker)">rdalverny at gmail.com
</A><BR>
<I>Sat Dec 10 20:25:09 CET 2011</I>
<P><UL>
<LI>Previous message: <A HREF="010333.html">[Mageia-dev] [soft-commits] [2359] coding style update (perl_checker)
</A></li>
<LI>Next message: <A HREF="010342.html">[Mageia-dev] [soft-commits] [2359] coding style update (perl_checker)
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#10340">[ date ]</a>
<a href="thread.html#10340">[ thread ]</a>
<a href="subject.html#10340">[ subject ]</a>
<a href="author.html#10340">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On Sat, Dec 10, 2011 at 18:59, Thierry Vignaud
<<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">thierry.vignaud at gmail.com</A>> wrote:
><i> On 10 December 2011 18:29,  <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at mageia.org</A>> wrote:
</I>>><i> coding style update (perl_checker)
</I>><i>
</I>><i> uh? Tools.pm doesn't currently pass perl_checker
</I>
Right; but I couldn't see why that was a syntax error at that point
(and the script did work). Anyway, now it looks much better (but for
used modules or "not recognised yet").
><i> just do sg like this:
</I>><i> [...]
</I>><i>    if ((@info{qw(name version release variant arch medium build
</I>><i> ext)}) = $name =~
</I>><i>        m/^(Mageia)-(\d+)-((?:alpha|beta|RC)\d*)?(-(?:.*))?-(i586|x86_64|dual)?(?:-(CD|DVD|BD))?(?:-(build_\w+))?\.(.*)$/)
</I>><i> {
</I>><i>        $info{full} = $name;
</I>><i>    }
</I>><i> [...]
</I>
Looks much more compact, thanks. Added a "else { %info = (); }" to
satisfy the expected behaviour (empty array returned if no match).
>><i>  open(my $file, "temp_media_on_iso.log") if -r "temp_media_on_iso.log";
</I>>><i>
</I>>><i>  while ($media = <$file>) {
</I>><i>
</I>><i> just reuse cat_() from MDK::Common (simpler, easier to read)
</I>
Thanks!
By the way, is there a "best" Web-based doc for MDK Perl libraries?
(could find one, but not at once, and I didn't count many). Or shall
we think about it?
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="010333.html">[Mageia-dev] [soft-commits] [2359] coding style update (perl_checker)
</A></li>
<LI>Next message: <A HREF="010342.html">[Mageia-dev] [soft-commits] [2359] coding style update (perl_checker)
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#10340">[ date ]</a>
<a href="thread.html#10340">[ thread ]</a>
<a href="subject.html#10340">[ subject ]</a>
<a href="author.html#10340">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
