diff options
Diffstat (limited to 'zarb-ml/mageia-sysadm/2011-January/002017.html')
-rw-r--r-- | zarb-ml/mageia-sysadm/2011-January/002017.html | 158 |
1 files changed, 158 insertions, 0 deletions
diff --git a/zarb-ml/mageia-sysadm/2011-January/002017.html b/zarb-ml/mageia-sysadm/2011-January/002017.html new file mode 100644 index 000000000..45d068063 --- /dev/null +++ b/zarb-ml/mageia-sysadm/2011-January/002017.html @@ -0,0 +1,158 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-sysadm] [279] add missing parentheses in open calls + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-sysadm%40mageia.org?Subject=Re%3A%20%5BMageia-sysadm%5D%20%5B279%5D%20add%20missing%20parentheses%20in%20open%20calls&In-Reply-To=%3C20110113124241.E302A42329%40valstar.mageia.org%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="002016.html"> + <LINK REL="Next" HREF="002022.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-sysadm] [279] add missing parentheses in open calls</H1> + <B>root at mageia.org</B> + <A HREF="mailto:mageia-sysadm%40mageia.org?Subject=Re%3A%20%5BMageia-sysadm%5D%20%5B279%5D%20add%20missing%20parentheses%20in%20open%20calls&In-Reply-To=%3C20110113124241.E302A42329%40valstar.mageia.org%3E" + TITLE="[Mageia-sysadm] [279] add missing parentheses in open calls">root at mageia.org + </A><BR> + <I>Thu Jan 13 13:42:41 CET 2011</I> + <P><UL> + <LI>Previous message: <A HREF="002016.html">[Mageia-sysadm] [278] fail early if chroot creation fails ( if some suggests have unsatisfied +</A></li> + <LI>Next message: <A HREF="002022.html">[Mageia-sysadm] [279] add missing parentheses in open calls +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#2017">[ date ]</a> + <a href="thread.html#2017">[ thread ]</a> + <a href="subject.html#2017">[ subject ]</a> + <a href="author.html#2017">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>Revision: 279 +Author: blino +Date: 2011-01-13 13:42:41 +0100 (Thu, 13 Jan 2011) +Log Message: +----------- +add missing parentheses in open calls + +Modified Paths: +-------------- + build_system/iurt/trunk/lib/Iurt/Chroot.pm + build_system/iurt/trunk/lib/Iurt/DKMS.pm + build_system/iurt/trunk/lib/Iurt/Process.pm + build_system/iurt/trunk/lib/Iurt/Urpmi.pm + +Modified: build_system/iurt/trunk/lib/Iurt/Chroot.pm +=================================================================== +--- build_system/iurt/trunk/lib/Iurt/Chroot.pm 2011-01-13 12:40:21 UTC (rev 278) ++++ build_system/iurt/trunk/lib/Iurt/Chroot.pm 2011-01-13 12:42:41 UTC (rev 279) +@@ -287,7 +287,7 @@ + plog('DEBUG', "... dir $dir all $run->{clean_all} prefix $prefix"); + + if ($run->{clean_all}) { +- opendir my $chroot_dir, $dir; ++ opendir(my $chroot_dir, $dir); + foreach (readdir $chroot_dir) { + next if !-d "$dir/$_" || /\.{1,2}/; + plog("cleaning old chroot for $_ in $dir"); + +Modified: build_system/iurt/trunk/lib/Iurt/DKMS.pm +=================================================================== +--- build_system/iurt/trunk/lib/Iurt/DKMS.pm 2011-01-13 12:40:21 UTC (rev 278) ++++ build_system/iurt/trunk/lib/Iurt/DKMS.pm 2011-01-13 12:42:41 UTC (rev 279) +@@ -67,7 +67,7 @@ + my $media_ok = $run->{dkms}{media} ? $media =~ /$run->{dkms}{media}/ : 1; + my $kmedia_ok = $run->{dkms}{kmedia} ? $media =~ /$run->{dkms}{kmedia}/ : 1; + plog("searching in $path"); +- opendir my $rpmdh, $path; ++ opendir(my $rpmdh, $path); + foreach my $rpm (readdir $rpmdh) { + if ($rpm =~ /^dkms-(.*)-([^-]+-[^-]+)\.[^.]+\.rpm/) { + # we only check for kernel or modules in this media + +Modified: build_system/iurt/trunk/lib/Iurt/Process.pm +=================================================================== +--- build_system/iurt/trunk/lib/Iurt/Process.pm 2011-01-13 12:40:21 UTC (rev 278) ++++ build_system/iurt/trunk/lib/Iurt/Process.pm 2011-01-13 12:42:41 UTC (rev 279) +@@ -44,7 +44,7 @@ + if (-f $pidfile) { + my (@stat) = stat $pidfile; + +- open my $test_PID, $pidfile; ++ open(my $test_PID, $pidfile); + my $pid = <$test_PID>; + close $test_PID; + + +Modified: build_system/iurt/trunk/lib/Iurt/Urpmi.pm +=================================================================== +--- build_system/iurt/trunk/lib/Iurt/Urpmi.pm 2011-01-13 12:40:21 UTC (rev 278) ++++ build_system/iurt/trunk/lib/Iurt/Urpmi.pm 2011-01-13 12:42:41 UTC (rev 279) +@@ -157,7 +157,7 @@ + + if (-d $local_media) { + mkdir("$chroot_tmp/iurt_media/"); +- opendir my $dir, $local_media; ++ opendir(my $dir, $local_media); + my $next; + foreach my $f (readdir $dir) { + $f =~ /(\.rpm|^hdlist.cz)$/ or next; +@@ -268,7 +268,7 @@ + my $program_name = $run->{program_name}; + my $local_media = $self->{local_media}; + +- opendir my $dir, $local_media; ++ opendir(my $dir, $local_media); + plog(1, "get local provides ($local_media)"); + require URPM; + my $urpm = new URPM; +-------------- next part -------------- +An HTML attachment was scrubbed... +URL: </pipermail/mageia-sysadm/attachments/20110113/84da35a8/attachment-0001.html> +</PRE> + + + + + + + + + + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="002016.html">[Mageia-sysadm] [278] fail early if chroot creation fails ( if some suggests have unsatisfied +</A></li> + <LI>Next message: <A HREF="002022.html">[Mageia-sysadm] [279] add missing parentheses in open calls +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#2017">[ date ]</a> + <a href="thread.html#2017">[ thread ]</a> + <a href="subject.html#2017">[ subject ]</a> + <a href="author.html#2017">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-sysadm">More information about the Mageia-sysadm +mailing list</a><br> +</body></html> |