diff options
Diffstat (limited to 'zarb-ml/mageia-dev/2013-March/023465.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2013-March/023465.html | 152 |
1 files changed, 152 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2013-March/023465.html b/zarb-ml/mageia-dev/2013-March/023465.html new file mode 100644 index 000000000..f661db378 --- /dev/null +++ b/zarb-ml/mageia-dev/2013-March/023465.html @@ -0,0 +1,152 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck. + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20RFC%3A%20Patch%20e2fsprogs%20to%20not%20print%20the%20%22clean%22%20message%0A%09on%20fsck.&In-Reply-To=%3C51407298.7060602%40colin.guthr.ie%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="023462.html"> + <LINK REL="Next" HREF="023467.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck.</H1> + <B>Colin Guthrie</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20RFC%3A%20Patch%20e2fsprogs%20to%20not%20print%20the%20%22clean%22%20message%0A%09on%20fsck.&In-Reply-To=%3C51407298.7060602%40colin.guthr.ie%3E" + TITLE="[Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck.">mageia at colin.guthr.ie + </A><BR> + <I>Wed Mar 13 13:35:36 CET 2013</I> + <P><UL> + <LI>Previous message: <A HREF="023462.html">[Mageia-dev] Freeze push : freeciv +</A></li> + <LI>Next message: <A HREF="023467.html">[Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck. +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#23465">[ date ]</a> + <a href="thread.html#23465">[ thread ]</a> + <a href="subject.html#23465">[ subject ]</a> + <a href="author.html#23465">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>Hi, + +I would like to propose that we push a patch to e2fsprogs to make it not +print out the "clean" message when it checks the filesystem. + +In my current boot (which is an experiment without initrds), it prints +this message over the top of plymouth and stays during the nice fade +transition to gdm and generally makes the boot ugly. + +I believe only the e2fsprogs print this message and the others do not +e.g. see this comparison with XFS: + +[<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at jimmy</A> ~]# dd if=/dev/zero of=xfs.img bs=1M count=100 >/dev/null +2>&1; mkfs.xfs xfs.img >/dev/null 2>&1; xfs_check xfs.img +[<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">root at jimmy</A> ~]# dd if=/dev/zero of=ext4.img bs=1M count=100 >/dev/null +2>&1; mkfs.ext4 -F ext4.img >/dev/null 2>&1; fsck.ext4 -a ext4.img +ext4.img: clean, 11/25688 files, 8896/102400 blocks + + + +My patch would propose to not print the "clean" message when the -a +option was passed. This is similar logic which prevents showing the +version when -a is passed. + +I've not tested this but I will before committing if no-one disapproves +of this approach. + +--- e2fsprogs-1.42.7/e2fsck/unix.c.orig 2013-03-13 10:57:22.349126868 +0000 ++++ e2fsprogs-1.42.7/e2fsck/unix.c 2013-03-13 12:33:08.340522834 +0000 +@@ -421,13 +421,14 @@ + } + + /* Print the summary message when we're skipping a full check */ +- log_out(ctx, _("%s: clean, %u/%u files, %llu/%llu blocks"), +- ctx->device_name, +- fs->super->s_inodes_count - fs->super->s_free_inodes_count, +- fs->super->s_inodes_count, +- ext2fs_blocks_count(fs->super) - +- ext2fs_free_blocks_count(fs->super), +- ext2fs_blocks_count(fs->super)); ++ if (!(ctx->options & E2F_OPT_PREEN)) ++ log_out(ctx, _("%s: clean, %u/%u files, %llu/%llu blocks"), ++ ctx->device_name, ++ fs->super->s_inodes_count - fs->super->s_free_inodes_count, ++ fs->super->s_inodes_count, ++ ext2fs_blocks_count(fs->super) - ++ ext2fs_free_blocks_count(fs->super), ++ ext2fs_blocks_count(fs->super)); + next_check = 100000; + if (fs->super->s_max_mnt_count > 0) { + next_check = fs->super->s_max_mnt_count - fs->super->s_mnt_count; + + +-- + +Colin Guthrie +colin(at)mageia.org +<A HREF="http://colin.guthr.ie/">http://colin.guthr.ie/</A> + +Day Job: + Tribalogic Limited <A HREF="http://www.tribalogic.net/">http://www.tribalogic.net/</A> +Open Source: + Mageia Contributor <A HREF="http://www.mageia.org/">http://www.mageia.org/</A> + PulseAudio Hacker <A HREF="http://www.pulseaudio.org/">http://www.pulseaudio.org/</A> + Trac Hacker <A HREF="http://trac.edgewall.org/">http://trac.edgewall.org/</A> +</PRE> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="023462.html">[Mageia-dev] Freeze push : freeciv +</A></li> + <LI>Next message: <A HREF="023467.html">[Mageia-dev] RFC: Patch e2fsprogs to not print the "clean" message on fsck. +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#23465">[ date ]</a> + <a href="thread.html#23465">[ thread ]</a> + <a href="subject.html#23465">[ subject ]</a> + <a href="author.html#23465">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |