diff options
Diffstat (limited to 'zarb-ml/mageia-dev/2012-May/015685.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2012-May/015685.html | 99 |
1 files changed, 99 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2012-May/015685.html b/zarb-ml/mageia-dev/2012-May/015685.html new file mode 100644 index 000000000..7e0281851 --- /dev/null +++ b/zarb-ml/mageia-dev/2012-May/015685.html @@ -0,0 +1,99 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] [soft-commits] [4522] - fix updates installation. + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4522%5D%20-%20fix%20updates%20installation.&In-Reply-To=%3CCAONrEtYtmmt9-A%3DYAHw38x5yWZOtv2ruu9Rnw7e-V%3Dr3UX9ySg%40mail.gmail.com%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="015682.html"> + <LINK REL="Next" HREF="015684.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] [soft-commits] [4522] - fix updates installation.</H1> + <B>Thierry Vignaud</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20%5Bsoft-commits%5D%20%5B4522%5D%20-%20fix%20updates%20installation.&In-Reply-To=%3CCAONrEtYtmmt9-A%3DYAHw38x5yWZOtv2ruu9Rnw7e-V%3Dr3UX9ySg%40mail.gmail.com%3E" + TITLE="[Mageia-dev] [soft-commits] [4522] - fix updates installation.">thierry.vignaud at gmail.com + </A><BR> + <I>Tue May 15 19:33:31 CEST 2012</I> + <P><UL> + <LI>Previous message: <A HREF="015682.html">[Mageia-dev] [soft-commits] [4522] - fix updates installation. +</A></li> + <LI>Next message: <A HREF="015684.html">[Mageia-dev] Installer setting sshd UsePAM to no +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#15685">[ date ]</a> + <a href="thread.html#15685">[ thread ]</a> + <a href="subject.html#15685">[ subject ]</a> + <a href="author.html#15685">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>On 15 May 2012 17:52, Thierry Vignaud <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">thierry.vignaud at gmail.com</A>> wrote: +>><i> - fix updates installation. installUpdates was relying on +</I>>><i> urpmi_add_all_media +</I>>><i>   return value different than 0, which was always 0 due to the 'undef $wait' +</I>>><i>   line +</I>><i> +</I>><i> This is bogus: +</I>><i> - if we don't have rpmdrake installed +</I>><i> - if we're in the text mode install. +</I>><i> +</I>><i> What you wanted was probably this: +</I>><i> +</I>><i>    my $val = run_program::rooted($::prefix, $binary, '>>', $log_file, +</I>><i> '2>>', $log_file, @options); +</I>><i>    undef $wait; +</I>><i>    $val; +</I>><i> } +</I>><i> +</I>><i> Also your description in NEWS is ... undescriptive +</I>><i> "fix detecting if adding update media succeeded" would have been better +</I> +Also, again perl-install/NEWS is for drakxtools and install/NEWS is for drakx +installer. +You changed code only used by the installer, hence it should have been +in install/NEWS not NEWS +</PRE> + + + + + + + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="015682.html">[Mageia-dev] [soft-commits] [4522] - fix updates installation. +</A></li> + <LI>Next message: <A HREF="015684.html">[Mageia-dev] Installer setting sshd UsePAM to no +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#15685">[ date ]</a> + <a href="thread.html#15685">[ thread ]</a> + <a href="subject.html#15685">[ subject ]</a> + <a href="author.html#15685">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |