diff options
Diffstat (limited to 'zarb-ml/mageia-dev/2011-September/007749.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2011-September/007749.html | 110 |
1 files changed, 110 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2011-September/007749.html b/zarb-ml/mageia-dev/2011-September/007749.html new file mode 100644 index 000000000..39106f9d8 --- /dev/null +++ b/zarb-ml/mageia-dev/2011-September/007749.html @@ -0,0 +1,110 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] perl-Sys-Mmap package review + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20perl-Sys-Mmap%20package%20review&In-Reply-To=%3C4E600703.9000001%40zen.co.uk%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="007719.html"> + <LINK REL="Next" HREF="007750.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] perl-Sys-Mmap package review</H1> + <B>Barry Jackson</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20perl-Sys-Mmap%20package%20review&In-Reply-To=%3C4E600703.9000001%40zen.co.uk%3E" + TITLE="[Mageia-dev] perl-Sys-Mmap package review">zen25000 at zen.co.uk + </A><BR> + <I>Fri Sep 2 00:28:19 CEST 2011</I> + <P><UL> + <LI>Previous message: <A HREF="007719.html">[Mageia-dev] perl-Sys-Mmap package review +</A></li> + <LI>Next message: <A HREF="007750.html">[Mageia-dev] perl-Sys-Mmap package review +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#7749">[ date ]</a> + <a href="thread.html#7749">[ thread ]</a> + <a href="subject.html#7749">[ subject ]</a> + <a href="author.html#7749">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>On 31/08/11 23:17, Guillaume Rousse wrote: +><i> Le 31/08/2011 15:20, Barry Jackson a écrit : +</I>>><i> Hello, +</I>>><i> Would someone please review the attached src.rpm for the above, with a +</I>>><i> view to committing it. +</I>><i> Here you have... +</I>><i> +</I>Many thanks Guillaume + +><i> You'd better use an author-neutral URL for the sources, such as +</I>><i> <A HREF="http://www.cpan.org/modules/by-module/Sys/%{upstream_name">http://www.cpan.org/modules/by-module/Sys/%{upstream_name</A>}-%{upstream_version}.tar.gz +</I>><i> +</I>><i> This way, if another maintainer submit a new version, the URL will stay +</I>><i> valid (and automatic update tool will work). +</I>><i> +</I>Yes - I learned something +><i> The runtime depency on perl is useless: you can't install mageia without +</I>><i> perl anyway, and the minimal version isn't very helpful either. +</I>><i> +</I>Done +><i> But you do need a build dependency (buildrequires) on perl-devel, as it +</I>><i> is a native perl package, you won't be able to build without it. +</I>><i> +</I>Done +><i> you should not include the debug files (the .debug, and the source +</I>><i> files), they will be automatically included in the implicit +</I>><i> perl-Sys-Mmap-debug package. Especially as the path you're using here is +</I>><i> x86_64-specific :) So just forget them. +</I>><i> +</I>><i> You should not own the %{perl_vendorlib} directory (it belongs to perl +</I>><i> package), but just the subdirectory %{perl_vendorlib}/Sys, which is the +</I>><i> base directory for your package files. +</I>><i> +</I>Thanks - that explains the problem with the debug etc. as well - they +were being listed as installed but not packaged hence my comment and +their inclusion ;) + > +><i> The %clean section isn't needed anymore with rpm 4.8 +</I>><i> +</I>OK sth else I learned. +><i> Usually, the document files (%doc macro) are listed first, but that's +</I>><i> purely cosmetic. +</I>Moved. + +Some of your above comments would also apply to the current +perl-Sys-Mknod.spec which I used as a template ;) + +Updated version attached. + +Barry. +-------------- next part -------------- +An embedded and charset-unspecified text was scrubbed... +Name: perl-Sys-Mmap.spec +URL: </pipermail/mageia-dev/attachments/20110901/68dfb8ac/attachment-0001.ksh> +</PRE> + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="007719.html">[Mageia-dev] perl-Sys-Mmap package review +</A></li> + <LI>Next message: <A HREF="007750.html">[Mageia-dev] perl-Sys-Mmap package review +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#7749">[ date ]</a> + <a href="thread.html#7749">[ thread ]</a> + <a href="subject.html#7749">[ subject ]</a> + <a href="author.html#7749">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |