diff options
Diffstat (limited to 'zarb-ml/mageia-dev/2011-September/007719.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2011-September/007719.html | 91 |
1 files changed, 91 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2011-September/007719.html b/zarb-ml/mageia-dev/2011-September/007719.html new file mode 100644 index 000000000..ecf51ab92 --- /dev/null +++ b/zarb-ml/mageia-dev/2011-September/007719.html @@ -0,0 +1,91 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] perl-Sys-Mmap package review + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20perl-Sys-Mmap%20package%20review&In-Reply-To=%3C4E5EB317.9020907%40gmail.com%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="007737.html"> + <LINK REL="Next" HREF="007749.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] perl-Sys-Mmap package review</H1> + <B>Guillaume Rousse</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20perl-Sys-Mmap%20package%20review&In-Reply-To=%3C4E5EB317.9020907%40gmail.com%3E" + TITLE="[Mageia-dev] perl-Sys-Mmap package review">guillomovitch at gmail.com + </A><BR> + <I>Thu Sep 1 00:17:59 CEST 2011</I> + <P><UL> + <LI>Previous message: <A HREF="007737.html">[Mageia-dev] [135989] +</A></li> + <LI>Next message: <A HREF="007749.html">[Mageia-dev] perl-Sys-Mmap package review +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#7719">[ date ]</a> + <a href="thread.html#7719">[ thread ]</a> + <a href="subject.html#7719">[ subject ]</a> + <a href="author.html#7719">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>Le 31/08/2011 15:20, Barry Jackson a écrit : +><i> Hello, +</I>><i> Would someone please review the attached src.rpm for the above, with a +</I>><i> view to committing it. +</I>Here you have... + +You'd better use an author-neutral URL for the sources, such as +<A HREF="http://www.cpan.org/modules/by-module/Sys/%{upstream_name">http://www.cpan.org/modules/by-module/Sys/%{upstream_name</A>}-%{upstream_version}.tar.gz +This way, if another maintainer submit a new version, the URL will stay +valid (and automatic update tool will work). + +The runtime depency on perl is useless: you can't install mageia without +perl anyway, and the minimal version isn't very helpful either. + +But you do need a build dependency (buildrequires) on perl-devel, as it +is a native perl package, you won't be able to build without it. + +you should not include the debug files (the .debug, and the source +files), they will be automatically included in the implicit +perl-Sys-Mmap-debug package. Especially as the path you're using here is +x86_64-specific :) So just forget them. + +You should not own the %{perl_vendorlib} directory (it belongs to perl +package), but just the subdirectory %{perl_vendorlib}/Sys, which is the +base directory for your package files. + +The %clean section isn't needed anymore with rpm 4.8 + +Usually, the document files (%doc macro) are listed first, but that's +purely cosmetic. +-- +Guillaume +</PRE> + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="007737.html">[Mageia-dev] [135989] +</A></li> + <LI>Next message: <A HREF="007749.html">[Mageia-dev] perl-Sys-Mmap package review +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#7719">[ date ]</a> + <a href="thread.html#7719">[ thread ]</a> + <a href="subject.html#7719">[ subject ]</a> + <a href="author.html#7719">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |