diff options
Diffstat (limited to 'zarb-ml/mageia-dev/2011-June/005525.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2011-June/005525.html | 207 |
1 files changed, 207 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2011-June/005525.html b/zarb-ml/mageia-dev/2011-June/005525.html new file mode 100644 index 000000000..506f35dc4 --- /dev/null +++ b/zarb-ml/mageia-dev/2011-June/005525.html @@ -0,0 +1,207 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] get-skype package for submission + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF61F3B.7020408%40zen.co.uk%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="005495.html"> + <LINK REL="Next" HREF="005526.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] get-skype package for submission</H1> + <B>Barry Jackson</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF61F3B.7020408%40zen.co.uk%3E" + TITLE="[Mageia-dev] get-skype package for submission">zen25000 at zen.co.uk + </A><BR> + <I>Mon Jun 13 16:31:23 CEST 2011</I> + <P><UL> + <LI>Previous message: <A HREF="005495.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI>Next message: <A HREF="005526.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#5525">[ date ]</a> + <a href="thread.html#5525">[ thread ]</a> + <a href="subject.html#5525">[ subject ]</a> + <a href="author.html#5525">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>On 13/06/11 13:24, Anssi Hannula wrote: +><i> On 12.06.2011 02:37, Barry Jackson wrote: +</I>>><i> On 11/06/11 18:03, Anssi Hannula wrote: +</I>>>><i> +</I>>>><i> - Best to add a comment in the %post script to remind that any new files +</I>>>><i> need to have a %ghost entry created. +</I>>>><i> (btw: an alternative idea is to create a post-script and the filelist +</I>>>><i> at the same time in a single for loop in %build/%install, so that +</I>>>><i> the lists can never get out of sync as they are created from a single +</I>>>><i> list; however, your current solution is adequate as well) +</I>>><i> +</I>>><i> Note added - keep it simple. +</I>>><i> +</I>><i> +</I>><i> You added the note in the %files section, not in %post. The issue only +</I>><i> happens if someone updates %post but not %files, so it doesn't make +</I>><i> sense to put the reminder in %files :) +</I>><i> +</I> +OK moved + +>>><i> - You don't check for failures. If the mktemp call fails, you extract +</I>>>><i> the tarball into /root etc.etc.. You need to check for failures on +</I>>>><i> the mktemp/mkdir/cd commands (mktemp failure can be detected by +</I>>>><i> checking if $newtmp string is empty), or alternatively run "set -e" +</I>>>><i> to make the shell exit on failures (this leaves the tmpdir polluted, +</I>>>><i> but it doesn't matter as much as it is an uncommon failure case and +</I>>>><i> /tmp is cleaned periodically anyway). +</I>>><i> +</I>>><i> Added some checks - with clean-up of previously created dirs etc on fail. +</I>><i> +</I>>><i> mkdir %{mytmp} +</I>>><i> [[ -d %{mytmp} ]] || exit 1 +</I>>><i> cd %{mytmp} +</I>><i> +</I>><i> cd is not guaranteed to work even if %mytmp exists. Add "|| exit 1". +</I>><i> +</I> +OK - done. + +>><i> cd ${tmpextdir} +</I>>><i> tar jxf %{mytmp}/skype-%{version}.tar.bz2 +</I>><i> +</I>><i> Same here... +</I>><i> +</I>><i> Well, actually these two aren't that serious, since they can't be +</I>><i> exploited by non-root anyway. I'm somewhat ok with them, as long as your +</I>><i> mentor is as well and no one else objects. +</I>><i> +</I> +I need a mentor ;) + +><i> Note that your "if ! [[ -d %{tmpdir} ]]; then" check is not 100% +</I>><i> necessary, as %tmpdir not existing is unlikely and causes no side effects. +</I>><i> +</I> +I added that as the dir is created by tar, so if the tarball had the +wrong content the dir may not be created with the correct name. +Unlikely as you say. + +><i> Other nits: +</I>><i> - Use better variable names- %mytmp, $tmpextdir, %tmpdir are confusing. +</I> +Changed to tmp_download_dir, tmp_extract_dir and tmp_skype_dir + +><i> - The description starts with an empty line. Remove it. +</I> +Gone + +><i> +</I> +I have started writing a script to generate the .txt files but can't +decide whether it should go as far as downloading the source from Skype +or simply be run on an extracted skype-<version> folder. +A first draft of this is attached. +I assume this would ultimately be added as a SOURCE file with notes in +the package. + +Barry +-------------- next part -------------- +An embedded and charset-unspecified text was scrubbed... +Name: get-skype.spec +URL: </pipermail/mageia-dev/attachments/20110613/2c715ab6/attachment.ksh> +-------------- next part -------------- +An embedded and charset-unspecified text was scrubbed... +Name: skype-txt-gen +URL: </pipermail/mageia-dev/attachments/20110613/2c715ab6/attachment-0001.ksh> +</PRE> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="005495.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI>Next message: <A HREF="005526.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#5525">[ date ]</a> + <a href="thread.html#5525">[ thread ]</a> + <a href="subject.html#5525">[ subject ]</a> + <a href="author.html#5525">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |