diff options
Diffstat (limited to 'zarb-ml/mageia-dev/2011-June/005393.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2011-June/005393.html | 201 |
1 files changed, 201 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2011-June/005393.html b/zarb-ml/mageia-dev/2011-June/005393.html new file mode 100644 index 000000000..ecef6bb06 --- /dev/null +++ b/zarb-ml/mageia-dev/2011-June/005393.html @@ -0,0 +1,201 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] get-skype package for submission + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF2B14C.3000402%40zen.co.uk%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="005381.html"> + <LINK REL="Next" HREF="005397.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] get-skype package for submission</H1> + <B>Barry Jackson</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF2B14C.3000402%40zen.co.uk%3E" + TITLE="[Mageia-dev] get-skype package for submission">zen25000 at zen.co.uk + </A><BR> + <I>Sat Jun 11 02:05:32 CEST 2011</I> + <P><UL> + <LI>Previous message: <A HREF="005381.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI>Next message: <A HREF="005397.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#5393">[ date ]</a> + <a href="thread.html#5393">[ thread ]</a> + <a href="subject.html#5393">[ subject ]</a> + <a href="author.html#5393">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>On 10/06/11 18:06, Anssi Hannula wrote: + +><i> I didn't test it, but the problems I see now: +</I>><i> +</I>><i> 1. The MD5SUM isn't checked, IMO it should be. +</I> +I was just discussing that on IRC with Ahmad ;) +I now have that working OK + +><i> 2. On error you exit with "|| exit 1" but leave +</I>><i> the files in /tmp, polluting it. +</I> +OK - will fix + +><i> 3. You cp files to %_datadir using a wildcard (*), but these +</I>><i> files may not be removed on uninstallation as you only have filename +</I>><i> lists for avatars/sounds/langs. While it may work now (I didn't +</I>><i> test, I hope you did), this will cause unnoticed problems when the +</I>><i> skype tarball contents change. +</I> +The wildcard is used to move the remaining files which are all +individually handled by touch and the dir is removed by a %ghost. +I was just saving spec lines. + +Yes it does work fine and all files/dirs are removed on uninstall. + +The tarball contents can't change or the md5sum would fail :\ + +><i> 4. Provide the script/commandline used to create the filelist files. +</I> +Do you mean the avatars.txt etc. +It was all done semi-manually, but I will write a script if necessary. +It did cross my mind, but it was quicker to just copy/paste into txt files. +I was assuming I could maintain it manually. + +><i> 5. Versionize the filelist files to make sure they are renegerated +</I>><i> when the package is updated to a new version (avatars-%version.txt) +</I> +OK - again I was expecting to maintain it manually. + +><i> 6. Your usage of /tmp seems unsafe security-wise. What if some user +</I>><i> has created something under /tmp/skype-%version already? +</I> +Hmm.. point taken + +><i> Instead use mktemp to create a temporary directory. +</I> +OK ... but: +I can't figure out how to get a temp filename into a %define +If I use +%define mytmp $(mktemp -d -q) +then every reference to the %define generates a new tmp file. +How can I assign the output of a command expansion to a %define so it's +evaluated only once on assignment? +I can use a variable in %pre but that is invisible in %post as it's in +another shell so I'm sorta stuck on that for now :( + +><i> 7. You never remove the tarball, and the tarball is not %ghost. +</I> +Will do - that was temporary for testing. + +><i> +</I>><i> Also BTW, here is a package of mine for gootleearth from 2006 that uses +</I>><i> a similar system: +</I>><i> <A HREF="http://www.zarb.org/cgi-bin/viewvc.cgi/plf/SPECS/non-free/googleearth/">http://www.zarb.org/cgi-bin/viewvc.cgi/plf/SPECS/non-free/googleearth/</A> +</I>><i> No need to make it like that, just pointing it out in case there are +</I>><i> some ideas you'd like to use. +</I>><i> +</I> +I'll take a look - thanks + +</PRE> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="005381.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI>Next message: <A HREF="005397.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#5393">[ date ]</a> + <a href="thread.html#5393">[ thread ]</a> + <a href="subject.html#5393">[ subject ]</a> + <a href="author.html#5393">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |