diff options
| author | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
|---|---|---|
| committer | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
| commit | 1be510f9529cb082f802408b472a77d074b394c0 (patch) | |
| tree | b175f9d5fcb107576dabc768e7bd04d4a3e491a0 /zarb-ml/mageia-dev/2012-October/019366.html | |
| parent | fa5098cf210b23ab4f419913e28af7b1b07dafb2 (diff) | |
| download | archives-master.tar archives-master.tar.gz archives-master.tar.bz2 archives-master.tar.xz archives-master.zip | |
Diffstat (limited to 'zarb-ml/mageia-dev/2012-October/019366.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2012-October/019366.html | 175 |
1 files changed, 175 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2012-October/019366.html b/zarb-ml/mageia-dev/2012-October/019366.html new file mode 100644 index 000000000..e9773e831 --- /dev/null +++ b/zarb-ml/mageia-dev/2012-October/019366.html @@ -0,0 +1,175 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] NEED REVIEW: drakdisk refresh feature + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20NEED%20REVIEW%3A%20drakdisk%20refresh%20feature&In-Reply-To=%3C2410689.GUl2MPd1Rc%40localhost%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="019351.html"> + <LINK REL="Next" HREF="019329.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] NEED REVIEW: drakdisk refresh feature</H1> + <B>AL13N</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20NEED%20REVIEW%3A%20drakdisk%20refresh%20feature&In-Reply-To=%3C2410689.GUl2MPd1Rc%40localhost%3E" + TITLE="[Mageia-dev] NEED REVIEW: drakdisk refresh feature">alien at rmail.be + </A><BR> + <I>Mon Oct 15 23:25:08 CEST 2012</I> + <P><UL> + <LI>Previous message: <A HREF="019351.html">[Mageia-dev] NEED REVIEW: drakdisk refresh feature +</A></li> + <LI>Next message: <A HREF="019329.html">[Mageia-dev] liblzma bug +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#19366">[ date ]</a> + <a href="thread.html#19366">[ thread ]</a> + <a href="subject.html#19366">[ subject ]</a> + <a href="author.html#19366">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>Op maandag 15 oktober 2012 15:05:28 schreef Pascal Terjan: +><i> On Sat, Oct 13, 2012 at 6:52 PM, AL13N <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">alien at rmail.be</A>> wrote: +</I>><i> > Hi all, +</I>><i> > +</I>><i> > This is a first patch, concerning the drakdisk feature +</I>><i> > <A HREF="https://wiki.mageia.org/en/Feature:DiskDrakeRedesign">https://wiki.mageia.org/en/Feature:DiskDrakeRedesign</A> +</I>><i> > +</I>><i> > the patch does the following: +</I>><i> > - group the functionality to actually get all the disks in a function +</I>><i> > - pass a ref to the function as the do_force_reload parameter to +</I>><i> > interactive - make a Refresh function that returns "force_reload" +</I>><i> > - add a button in the gtk +</I>><i> > +</I>><i> > what it still needs for the first stage of this feature: +</I>><i> > - a button for the curses one +</I>><i> > - remove the abort message if no disks are found, but add a text in place +</I>><i> > of the disk tabs to say there are no disks and telling you can refresh +</I>><i> > after plugging in a disk. +</I>><i> > +</I>><i> > +</I>><i> > attached is a small patch for /soft/drakx +</I>><i> > +</I>><i> > can *anyone* tell me if i'm on the right track, or if i'm doing ugly +</I>><i> > stuff, or if i'm forgetting important parts? +</I>><i> +</I>><i> Sorry for not looing at it faster but after one month travelling my +</I>><i> home was burgled 10 days ago which mean I could not yet come back to a +</I>><i> normal life... +</I> +that is no worries, i hope you'll be better soon-ish. + +><i> How is it different from the "Reload partition table" action hidden +</I>><i> behind "More" (which for some reason was per disk even if it reloads +</I>><i> them all) and only displayed during install? +</I>><i> There is nothing obviously wrong, most of the work will be to make +</I>><i> sure every part of the code handles this correctly (mostly +</I>><i> raid/lvm/...) and interface also recreates tabs correctly etc... +</I>><i> It has been broken/fixed various times and if this is to be displayed +</I>><i> more visibly it should be properly tested +</I> +i realized this afterwards, and i think you're right, perhaps i should handle +it a bit better: + +-> actively look for new devices (or size-changed devices) and handle those; +and thus not change all the changes you've made already. + +The point of this is more like stepping stone towards the real things: ie: not +aborting if there are no disks. and later adding installable network-based +disks (for diskless systems). + +And also, if your one of your hotplugged disks isn't correctly in it, i'd like +to refresh it, so the 4th one is detected and so i can add it to the raid, for +instance. instead of exiting the installer, etc... + +in any case, it seems like someone found that it showed gray for a all disks, +so it might not be that good after all... + +but it would be nice for me though if i could pick your brain about the code +and the way of programming though... it's not always easy to get around this +kind of code. + +Can i ask you in the future to look at this from time to time? + +also, i fail to correctly grasp the purpose of the $do_force_reload variable. +in some forms, it's used, and some it doesn't. but the function that is +supposed to be parsed into that, it not clear what it should return. (to me) + +Thanks for the feedback already. + +AL13N +</PRE> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="019351.html">[Mageia-dev] NEED REVIEW: drakdisk refresh feature +</A></li> + <LI>Next message: <A HREF="019329.html">[Mageia-dev] liblzma bug +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#19366">[ date ]</a> + <a href="thread.html#19366">[ thread ]</a> + <a href="subject.html#19366">[ subject ]</a> + <a href="author.html#19366">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |