diff options
| author | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
|---|---|---|
| committer | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
| commit | 1be510f9529cb082f802408b472a77d074b394c0 (patch) | |
| tree | b175f9d5fcb107576dabc768e7bd04d4a3e491a0 /zarb-ml/mageia-dev/2012-June/016854.html | |
| parent | fa5098cf210b23ab4f419913e28af7b1b07dafb2 (diff) | |
| download | archives-master.tar archives-master.tar.gz archives-master.tar.bz2 archives-master.tar.xz archives-master.zip | |
Diffstat (limited to 'zarb-ml/mageia-dev/2012-June/016854.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2012-June/016854.html | 190 |
1 files changed, 190 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2012-June/016854.html b/zarb-ml/mageia-dev/2012-June/016854.html new file mode 100644 index 000000000..b2b22e4f1 --- /dev/null +++ b/zarb-ml/mageia-dev/2012-June/016854.html @@ -0,0 +1,190 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] What is Mageia's policy reagarding filesize display? (units/base 2 vs base 10) + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20What%20is%20Mageia%27s%20policy%20reagarding%20filesize%0A%20display%3F%20%28units/base%202%20vs%20base%2010%29&In-Reply-To=%3CCAOPHaVS2YixRiPxhck8wW7Ox6OO8WgCAKHfftCbDsPq6ZUAeiw%40mail.gmail.com%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="016850.html"> + <LINK REL="Next" HREF="016851.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] What is Mageia's policy reagarding filesize display? (units/base 2 vs base 10)</H1> + <B>Christian Lohmaier</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20What%20is%20Mageia%27s%20policy%20reagarding%20filesize%0A%20display%3F%20%28units/base%202%20vs%20base%2010%29&In-Reply-To=%3CCAOPHaVS2YixRiPxhck8wW7Ox6OO8WgCAKHfftCbDsPq6ZUAeiw%40mail.gmail.com%3E" + TITLE="[Mageia-dev] What is Mageia's policy reagarding filesize display? (units/base 2 vs base 10)">lohmaier+mageia at googlemail.com + </A><BR> + <I>Tue Jun 26 19:01:30 CEST 2012</I> + <P><UL> + <LI>Previous message: <A HREF="016850.html">[Mageia-dev] What is Mageia's policy reagarding filesize display? (units/base 2 vs base 10) +</A></li> + <LI>Next message: <A HREF="016851.html">[Mageia-dev] What is Mageia's policy reagarding filesize display? (units/base 2 vs base 10) +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#16854">[ date ]</a> + <a href="thread.html#16854">[ thread ]</a> + <a href="subject.html#16854">[ subject ]</a> + <a href="author.html#16854">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>On Tue, Jun 26, 2012 at 6:13 PM, Oliver Burger +<<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">oliver.bgr at googlemail.com</A>> wrote: +><i> At the moment we have +</I>><i> the bash showing values in base 2 with the unit K, +</I>><i> dolphin showing them in base 2 with the unit KiB, +</I>><i> pcmanfm showing them in base 2 with the unit KB. +</I>><i> +</I>><i> So patching nautilus to use base 2 woul make for a more common behaviour of +</I>><i> the distro, but it will create work for our GNOME maintainer since he would +</I>><i> have to maintain that patch for every future version. +</I> +To get a better idea of the "effort" it would take: This is the patch + +diff -ru nautilus-3.4.1_orig/libnautilus-private/nautilus-file.c +nautilus-3.4.1/libnautilus-private/nautilus-file.c +--- nautilus-3.4.1_orig/libnautilus-private/nautilus-file.c 2012-04-13 +19:01:03.000000000 +0200 ++++ nautilus-3.4.1/libnautilus-private/nautilus-file.c 2012-06-26 +16:13:48.649538611 +0200 +@@ -5847,7 +5847,7 @@ + if (file->details->size == -1) { + return NULL; + } +- return g_format_size (file->details->size); ++ return g_format_size_full (file->details->size, G_FORMAT_SIZE_IEC_UNITS); + } + + /** +@@ -5885,7 +5885,7 @@ + return NULL; + } + +- return g_format_size_full (file->details->size, G_FORMAT_SIZE_LONG_FORMAT); ++ return g_format_size_full (file->details->size, +G_FORMAT_SIZE_IEC_UNITS & G_FORMAT_SIZE_LONG_FORMAT); + } + + +@@ -5945,7 +5945,7 @@ + * directly if desired. + */ + if (report_size) { +- return g_format_size (total_size); ++ return g_format_size_full (total_size, G_FORMAT_SIZE_IEC_UNITS); + } + + return format_item_count_for_display (report_directory_count +@@ -6675,7 +6675,7 @@ + + res = NULL; + if (file->details->free_space != (guint64)-1) { +- res = g_format_size (file->details->free_space); ++ res = g_format_size_full (file->details->free_space, +G_FORMAT_SIZE_IEC_UNITS); + } + + return res; +diff -ru nautilus-3.4.1_orig/src/nautilus-view.c +nautilus-3.4.1/src/nautilus-view.c +--- nautilus-3.4.1_orig/src/nautilus-view.c 2012-04-13 19:01:03.000000000 +0200 ++++ nautilus-3.4.1/src/nautilus-view.c 2012-06-26 16:13:48.652538574 +0200 +@@ -2826,7 +2826,7 @@ + if (non_folder_size_known) { + char *size_string; + +- size_string = g_format_size (non_folder_size); ++ size_string = g_format_size_full (non_folder_size, G_FORMAT_SIZE_IEC_UNITS); + /* This is marked for translation in case a localiser + * needs to use something other than parentheses. The + * first message gives the number of items selected; + + +><i> And it could break any other thing in GNOME since GNOME apps are quite +</I>><i> interweaved with one another and you never know, what app uses nautilus in +</I>><i> parts for what. +</I> +See above. It is not a massive change in the internals of nautilus. +This is nautilus-only. + +And unless glib breaks its API the patch will continue to work. Both +g_format_size and g_format_size_full return a human-readable string, +just the default units differ. If you'd use + +g_format_size(size); is the very same as +g_format_size_full(size, G_FORMAT_SIZE_DEFAULT) + +So this is purely switching the base, nothing else. No custom "hacks", +no black magic. + +ciao +Christian +</PRE> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="016850.html">[Mageia-dev] What is Mageia's policy reagarding filesize display? (units/base 2 vs base 10) +</A></li> + <LI>Next message: <A HREF="016851.html">[Mageia-dev] What is Mageia's policy reagarding filesize display? (units/base 2 vs base 10) +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#16854">[ date ]</a> + <a href="thread.html#16854">[ thread ]</a> + <a href="subject.html#16854">[ subject ]</a> + <a href="author.html#16854">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |