diff options
| author | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
|---|---|---|
| committer | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
| commit | 1be510f9529cb082f802408b472a77d074b394c0 (patch) | |
| tree | b175f9d5fcb107576dabc768e7bd04d4a3e491a0 /zarb-ml/mageia-dev/2012-June/016584.html | |
| parent | fa5098cf210b23ab4f419913e28af7b1b07dafb2 (diff) | |
| download | archives-master.tar archives-master.tar.gz archives-master.tar.bz2 archives-master.tar.xz archives-master.zip | |
Diffstat (limited to 'zarb-ml/mageia-dev/2012-June/016584.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2012-June/016584.html | 136 |
1 files changed, 136 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2012-June/016584.html b/zarb-ml/mageia-dev/2012-June/016584.html new file mode 100644 index 000000000..7523d27b1 --- /dev/null +++ b/zarb-ml/mageia-dev/2012-June/016584.html @@ -0,0 +1,136 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] Collaboration policy + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20Collaboration%20policy&In-Reply-To=%3C4FDE573F.7020808%40colin.guthr.ie%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="016510.html"> + <LINK REL="Next" HREF="016661.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] Collaboration policy</H1> + <B>Colin Guthrie</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20Collaboration%20policy&In-Reply-To=%3C4FDE573F.7020808%40colin.guthr.ie%3E" + TITLE="[Mageia-dev] Collaboration policy">mageia at colin.guthr.ie + </A><BR> + <I>Mon Jun 18 00:16:31 CEST 2012</I> + <P><UL> + <LI>Previous message: <A HREF="016510.html">[Mageia-dev] Collaboration policy +</A></li> + <LI>Next message: <A HREF="016661.html">[Mageia-dev] Collaboration policy +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#16584">[ date ]</a> + <a href="thread.html#16584">[ thread ]</a> + <a href="subject.html#16584">[ subject ]</a> + <a href="author.html#16584">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>'Twas brillig, and Olivier Blin at 14/06/12 22:25 did gyre and gimble: +><i> David Walser <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">luigiwalser at yahoo.com</A>> writes: +</I>><i> +</I>>><i> Olivier Blin <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">mageia at ...</A>> writes: +</I>>>><i> Crediting patchs from others by only mentionning the source +</I>>>><i> (i.e. Mandriva, Fedora, XBMC, ...) is not enough IMHO. +</I>>>><i> +</I>>>><i> If we want to give proper credits, we should also mention the author of +</I>>>><i> the patch. +</I>>><i> +</I>>><i> It doesn't say we don't give credit to the patch author. It just says in our +</I>>><i> package changelog (a.k.a. our SVN commit messages), you mention where you got +</I>>><i> the patch from, because at that level you want to be concise and that's a much +</I>>><i> more useful piece of information. +</I>><i> +</I>><i> It says that we prefer to mention "source" over "author". +</I>><i> That's not good enough IMHO if we want to be ok with credits. +</I>><i> The "source" is not the one retaining the copyright on a change, only +</I>><i> the author owns this. +</I>><i> And mentionning an author's name is the minimum reward when +</I>><i> cherry-picking a change. +</I> +Well IMO, this is a trade off that relates to practical usefulness. + +The options for the commit message are: + 1. Mention the source + 2. Mention the author + 3. Mention both source+author + +IMO 3 is too verbose for package changelogs, but I agree it would be +nice to be able to do this if it were made concise. + +I also think that 2 is not ideal as this would then make it harder to +record the source. We'd either have to write a comment in the spec above +the PatchNN: line or put something into the patch itself to indicate the +source. This is typically a good idea anyway (I try to put any fedora +patches etc. in their own little section of the spec). If patches are +generated from git then you don't really want to add unmanaged extra +info in the patch file as when it is regenerated, this information would +be lost. + +The opposite is not true - if option 1 were picked, then the author +would typically be included already in the patch itself if it is a git +formatted patch. I accept this is not always the case, so this isn't a +fool-proof alternative. + + + +So, in the end, I'm not against mentioning the author directly in commit +messages, but I think it's somewhat impractical and thus it is my +opinion that it should not be in the message. + +It is, of course, open to discussion so further opinions on this topic +are more than welcome. + +Cheers + +Col + + + + +-- + +Colin Guthrie +colin(at)mageia.org +<A HREF="http://colin.guthr.ie/">http://colin.guthr.ie/</A> + +Day Job: + Tribalogic Limited <A HREF="http://www.tribalogic.net/">http://www.tribalogic.net/</A> +Open Source: + Mageia Contributor <A HREF="http://www.mageia.org/">http://www.mageia.org/</A> + PulseAudio Hacker <A HREF="http://www.pulseaudio.org/">http://www.pulseaudio.org/</A> + Trac Hacker <A HREF="http://trac.edgewall.org/">http://trac.edgewall.org/</A> + + +</PRE> + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="016510.html">[Mageia-dev] Collaboration policy +</A></li> + <LI>Next message: <A HREF="016661.html">[Mageia-dev] Collaboration policy +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#16584">[ date ]</a> + <a href="thread.html#16584">[ thread ]</a> + <a href="subject.html#16584">[ subject ]</a> + <a href="author.html#16584">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |