diff options
| author | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
|---|---|---|
| committer | Nicolas Vigier <boklm@mageia.org> | 2013-04-14 13:46:12 +0000 |
| commit | 1be510f9529cb082f802408b472a77d074b394c0 (patch) | |
| tree | b175f9d5fcb107576dabc768e7bd04d4a3e491a0 /zarb-ml/mageia-dev/2011-June/005381.html | |
| parent | fa5098cf210b23ab4f419913e28af7b1b07dafb2 (diff) | |
| download | archives-master.tar archives-master.tar.gz archives-master.tar.bz2 archives-master.tar.xz archives-master.zip | |
Diffstat (limited to 'zarb-ml/mageia-dev/2011-June/005381.html')
| -rw-r--r-- | zarb-ml/mageia-dev/2011-June/005381.html | 177 |
1 files changed, 177 insertions, 0 deletions
diff --git a/zarb-ml/mageia-dev/2011-June/005381.html b/zarb-ml/mageia-dev/2011-June/005381.html new file mode 100644 index 000000000..b4c42085d --- /dev/null +++ b/zarb-ml/mageia-dev/2011-June/005381.html @@ -0,0 +1,177 @@ +<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN"> +<HTML> + <HEAD> + <TITLE> [Mageia-dev] get-skype package for submission + </TITLE> + <LINK REL="Index" HREF="index.html" > + <LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF24F1B.4070000%40iki.fi%3E"> + <META NAME="robots" CONTENT="index,nofollow"> + <META http-equiv="Content-Type" content="text/html; charset=us-ascii"> + <LINK REL="Previous" HREF="005395.html"> + <LINK REL="Next" HREF="005393.html"> + </HEAD> + <BODY BGCOLOR="#ffffff"> + <H1>[Mageia-dev] get-skype package for submission</H1> + <B>Anssi Hannula</B> + <A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20get-skype%20package%20for%20submission&In-Reply-To=%3C4DF24F1B.4070000%40iki.fi%3E" + TITLE="[Mageia-dev] get-skype package for submission">anssi.hannula at iki.fi + </A><BR> + <I>Fri Jun 10 19:06:35 CEST 2011</I> + <P><UL> + <LI>Previous message: <A HREF="005395.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI>Next message: <A HREF="005393.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#5381">[ date ]</a> + <a href="thread.html#5381">[ thread ]</a> + <a href="subject.html#5381">[ subject ]</a> + <a href="author.html#5381">[ author ]</a> + </LI> + </UL> + <HR> +<!--beginarticle--> +<PRE>On 10.06.2011 02:56, Barry Jackson wrote: +><i> I have been working on a package to install Skype current stable release +</I>><i> and now feel that it is ready for submission for approval. +</I>><i> +</I>><i> It has already been improved/corrected/adapted many times following +</I>><i> discussions on #mageia-mentoring where I have been given lots of help. +</I>><i> +</I>><i> The idea evolved here <A HREF="https://bugs.mageia.org/show_bug.cgi?id=154">https://bugs.mageia.org/show_bug.cgi?id=154</A> +</I>><i> where the current version is available as an attachment. +</I>><i> <A HREF="https://bugs.mageia.org/attachment.cgi?id=551">https://bugs.mageia.org/attachment.cgi?id=551</A> +</I>><i> +</I>><i> It has been a challenge and I have learned a lot in working on this. :) +</I> +I didn't test it, but the problems I see now: + +1. The MD5SUM isn't checked, IMO it should be. +2. On error you exit with "|| exit 1" but leave + the files in /tmp, polluting it. +3. You cp files to %_datadir using a wildcard (*), but these + files may not be removed on uninstallation as you only have filename + lists for avatars/sounds/langs. While it may work now (I didn't + test, I hope you did), this will cause unnoticed problems when the + skype tarball contents change. +4. Provide the script/commandline used to create the filelist files. +5. Versionize the filelist files to make sure they are renegerated + when the package is updated to a new version (avatars-%version.txt) +6. Your usage of /tmp seems unsafe security-wise. What if some user + has created something under /tmp/skype-%version already? + Instead use mktemp to create a temporary directory. +7. You never remove the tarball, and the tarball is not %ghost. + +Also BTW, here is a package of mine for gootleearth from 2006 that uses +a similar system: +<A HREF="http://www.zarb.org/cgi-bin/viewvc.cgi/plf/SPECS/non-free/googleearth/">http://www.zarb.org/cgi-bin/viewvc.cgi/plf/SPECS/non-free/googleearth/</A> +No need to make it like that, just pointing it out in case there are +some ideas you'd like to use. + +-- +Anssi Hannula +</PRE> + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +<!--endarticle--> + <HR> + <P><UL> + <!--threads--> + <LI>Previous message: <A HREF="005395.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI>Next message: <A HREF="005393.html">[Mageia-dev] get-skype package for submission +</A></li> + <LI> <B>Messages sorted by:</B> + <a href="date.html#5381">[ date ]</a> + <a href="thread.html#5381">[ thread ]</a> + <a href="subject.html#5381">[ subject ]</a> + <a href="author.html#5381">[ author ]</a> + </LI> + </UL> + +<hr> +<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev +mailing list</a><br> +</body></html> |