diff options
| author | Pascal Rigaux <pixel@mandriva.com> | 2004-10-13 08:47:26 +0000 |
|---|---|---|
| committer | Pascal Rigaux <pixel@mandriva.com> | 2004-10-13 08:47:26 +0000 |
| commit | 7227ed63b1548299c570c30b57e7b45c612b610b (patch) | |
| tree | 43a0e54034b05aaaf4a4e94f4863cde8ccb262d4 | |
| parent | a69658dc4995acef787592b9c50539d7fc2c29c5 (diff) | |
| download | perl-MDK-Common-7227ed63b1548299c570c30b57e7b45c612b610b.tar perl-MDK-Common-7227ed63b1548299c570c30b57e7b45c612b610b.tar.gz perl-MDK-Common-7227ed63b1548299c570c30b57e7b45c612b610b.tar.bz2 perl-MDK-Common-7227ed63b1548299c570c30b57e7b45c612b610b.tar.xz perl-MDK-Common-7227ed63b1548299c570c30b57e7b45c612b610b.zip | |
$#x == -1 is better written @x == 0
| -rw-r--r-- | perl_checker.src/parser_helper.ml | 7 | ||||
| -rw-r--r-- | perl_checker.src/test/suggest_better.t | 2 |
2 files changed, 7 insertions, 2 deletions
diff --git a/perl_checker.src/parser_helper.ml b/perl_checker.src/parser_helper.ml index 39a4590..306fc3f 100644 --- a/perl_checker.src/parser_helper.ml +++ b/perl_checker.src/parser_helper.ml @@ -702,8 +702,11 @@ let cook_call_op op para pos = | "||=", e :: _ | "&&=", e :: _ -> if is_not_a_scalar e then warn_rule (sprintf "\"%s\" is only useful with a scalar" op) - | "==", [Call_op("last_array_index", _, _); Num("0", _)] -> - warn_rule "$#x == 0 is better written @x == 1" + | "==", [Call_op("last_array_index", _, _); Num(n, _)] -> + warn_rule (sprintf "$#x == %s is better written @x == %d" n (1 + int_of_string n)) + | "==", [Call_op("last_array_index", _, _); Call_op("- unary", [Num (n, _)], _)] -> + warn_rule (sprintf "$#x == -%s is better written @x == %d" n (1 - int_of_string n)) + | "||", e :: _ when is_always_true e -> warn_rule "<constant> || ... is the same as <constant>" | "&&", e :: _ when is_always_false e -> warn_rule "<constant> && ... is the same as <constant>" diff --git a/perl_checker.src/test/suggest_better.t b/perl_checker.src/test/suggest_better.t index 9fc4f1c..4b8d2d5 100644 --- a/perl_checker.src/test/suggest_better.t +++ b/perl_checker.src/test/suggest_better.t @@ -60,6 +60,8 @@ $l[$#l] you can replace $#l with -1 $#l == 0 $#x == 0 is better written @x == 1 +$#l == -1 $#x == -1 is better written @x == 0 + $#l < 0 change your expression to use @xxx instead of $#xxx $l[@l] = 1 "$a[@a] = ..." is better written "push @a, ..." |