diff options
| author | Pascal Rigaux <pixel@mandriva.com> | 2001-08-14 13:54:48 +0000 |
|---|---|---|
| committer | Pascal Rigaux <pixel@mandriva.com> | 2001-08-14 13:54:48 +0000 |
| commit | 1a5b978da98890aab1ff1d6200ca290e1bab0dc8 (patch) | |
| tree | 5df2325321dcb45498a2843dd729bb1e5ea22fe6 | |
| parent | c086774ae7078d1932884ab51b0c82fdf5ba721f (diff) | |
| download | perl-MDK-Common-1a5b978da98890aab1ff1d6200ca290e1bab0dc8.tar perl-MDK-Common-1a5b978da98890aab1ff1d6200ca290e1bab0dc8.tar.gz perl-MDK-Common-1a5b978da98890aab1ff1d6200ca290e1bab0dc8.tar.bz2 perl-MDK-Common-1a5b978da98890aab1ff1d6200ca290e1bab0dc8.tar.xz perl-MDK-Common-1a5b978da98890aab1ff1d6200ca290e1bab0dc8.zip | |
new check: "using $_ in a sub is generally bad news"
| -rwxr-xr-x | perl_checker | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/perl_checker b/perl_checker index d1cd082..fe94764 100755 --- a/perl_checker +++ b/perl_checker @@ -63,6 +63,10 @@ if (/\blocal\b.*\|\|=/) { err(q(never use ``local $var ||= <val>'', write ``local $var = $var || <val>''), info()); } +if (/\bsub\b\s*\{[^{}]*\$_(?!\[)/) { + warn_(q(using $_ in a sub is generally bad news), info()) if !/local\s+\$_/; +} + if (/^\s*package ([\w:]+)/) { $package = $1; $path{$package} ||= ($ARGV =~ m|(.*/)|)[0]; |