Fix detecting network for adding button in "Sources" page to configure network (mga#28740)

1 files changed, 10 insertions, 3 deletions

diff --git a/src/ui.py b/src/ui.py
index 5ac6982..5852a2c 100644
--- a/src/ui.py
+++ b/src/ui.py
@@ -42,6 +42,7 @@ from PyQt6.QtGui import (
     QLinearGradient,
     QColorConstants,
 )
+from PyQt6.QtNetwork import QNetworkInformation
 import webbrowser
 import subprocess
 from functools import partial
@@ -442,7 +443,8 @@ class Sources(SlidePage):
         content_label.setStyleSheet("font-size: 14px; color: white;")
         layout.addWidget(content_label)
         ns = NetworkState()
-        if not ns.isOffLine:
+        with_net_button = not (ns.reachability() == QNetworkInformation.Reachability.Online) 
+        if with_net_button:
             net_layout = QHBoxLayout()
             net_layout.addStretch(1)
             network_button = MyPushButton(_("Sources", "Configure network"))
@@ -456,7 +458,6 @@ class Sources(SlidePage):
                     ],
                 )
             )
-            layout.addLayout(net_layout)
         button_layout = QHBoxLayout()
         button_layout.addStretch(1)
         configure_button = MyPushButton(_("Sources", "Edit software sources") + " *")
@@ -470,7 +471,13 @@ class Sources(SlidePage):
         )
         button_layout.addWidget(configure_button)
         button_layout.addStretch(1)
-        layout.addLayout(button_layout)
+        if with_net_button:
+            button_box = QHBoxLayout()
+            button_box.addLayout(net_layout)
+            button_box.addLayout(button_layout)
+            layout.addLayout(button_box)
+        else:
+            layout.addLayout(button_layout)
         layout.addStretch(0)
 
         self.setLayout(layout)