diff options
| author | Pascal Rigaux <pixel@mandriva.com> | 2003-04-22 09:45:00 +0000 |
|---|---|---|
| committer | Pascal Rigaux <pixel@mandriva.com> | 2003-04-22 09:45:00 +0000 |
| commit | ddf404afa8a0ccd0694cc5e60d9ace07d712b68b (patch) | |
| tree | 551e78c3d423619d650e3925a8f8094b448cae4b /ldetect.spec | |
| parent | 1048fa9cb404faf12ff1b850aa81f32891d5fca9 (diff) | |
| download | ldetect-ddf404afa8a0ccd0694cc5e60d9ace07d712b68b.tar ldetect-ddf404afa8a0ccd0694cc5e60d9ace07d712b68b.tar.gz ldetect-ddf404afa8a0ccd0694cc5e60d9ace07d712b68b.tar.bz2 ldetect-ddf404afa8a0ccd0694cc5e60d9ace07d712b68b.tar.xz ldetect-ddf404afa8a0ccd0694cc5e60d9ace07d712b68b.zip | |
- Use read() instead of fread() to read from "/proc/bus/pci/%02x/%02x.%d".
Thanks a lot to Tom Cox for finding this bug:
The proc.c module in the kernel source clearly states that
reading more than 64 bytes can cause problems. The pci.c
module in the ldetect library uses the buffered fread()
function. This function always reads in blocks, so when
run as root, the read always tried to read more than the
user requested amount.
This should fix freezes when doing a full probe
Diffstat (limited to 'ldetect.spec')
| -rw-r--r-- | ldetect.spec | 15 |
1 files changed, 14 insertions, 1 deletions
diff --git a/ldetect.spec b/ldetect.spec index a91e396..399c720 100644 --- a/ldetect.spec +++ b/ldetect.spec @@ -1,5 +1,5 @@ Name: ldetect -Version: 0.4.8 +Version: 0.4.9 Release: 1mdk Summary: Light hardware detection library Source: %name.tar.bz2 @@ -49,6 +49,19 @@ rm -rf $RPM_BUILD_ROOT %_libdir/* %changelog +* Tue Apr 22 2003 Pixel <pixel@mandrakesoft.com> 0.4.9-1mdk +- Use read() instead of fread() to read from "/proc/bus/pci/%02x/%02x.%d". + Thanks a lot to Tom Cox for finding this bug: + + The proc.c module in the kernel source clearly states that + reading more than 64 bytes can cause problems. The pci.c + module in the ldetect library uses the buffered fread() + function. This function always reads in blocks, so when + run as root, the read always tried to read more than the + user requested amount. + + This should fix freezes when doing a full probe + * Mon Jan 6 2003 Thierry Vignaud <tvignaud@mandrakesoft.com> 0.4.8-1mdk - require an usbutils recent enough to have working hub class - fix hubs detection |