- check for newer/current revisions in default section when submitted to another section (bug #30635)

1 files changed, 19 insertions, 1 deletions

diff --git a/lib/Youri/Submit/Check/Recency.pm b/lib/Youri/Submit/Check/Recency.pm
index f8aa5b7..840e709 100644
--- a/lib/Youri/Submit/Check/Recency.pm
+++ b/lib/Youri/Submit/Check/Recency.pm
@@ -25,13 +25,31 @@ sub run {
 
     my @revisions = $repository->get_revisions($package, $target, $define, undef, sub { return $_[0]->compare($package) >= 0 });
     if (@revisions) {
+        my $section = $repository->_get_section($package, $target, $define);
         push(
             @errors,
-            "Current or newer revision(s) already exists for $target: " .
+            "Current or newer revision(s) already exists in $section for $target: " .
                 join(', ', @revisions)
         );
     }
 
+    my $defined_section = $define->{section};
+
+    # if the user provided a section, check also in the default section
+    if ($defined_section) {
+        $define->{section} = undef;
+        my @default_revisions = $repository->get_revisions($package, $target, $define, undef, sub { return $_[0]->compare($package) >= 0 });
+        if (@default_revisions) {
+            my $section = $repository->_get_section($package, $target, $define);
+            push(
+                @errors,
+                "Current or newer revision(s) already exists in $section for $target: " .
+                    join(', ', @default_revisions)
+            );
+        }
+        $define->{section} = $defined_section;
+    }
+
     return @errors;
 }