diff options
author | Michael Scherer <misc@mageia.org> | 2011-04-15 11:32:23 +0000 |
---|---|---|
committer | Michael Scherer <misc@mageia.org> | 2011-04-15 11:32:23 +0000 |
commit | 11b6ea8738a68f2615b0a8b5095396cc2ed14176 (patch) | |
tree | 0a9a19726e61778e7c9fc70351ba12b66005bae9 | |
parent | 22b5da7e0cf4bab33bb7f1395c98817cced3ec5f (diff) | |
download | iurt-11b6ea8738a68f2615b0a8b5095396cc2ed14176.tar iurt-11b6ea8738a68f2615b0a8b5095396cc2ed14176.tar.gz iurt-11b6ea8738a68f2615b0a8b5095396cc2ed14176.tar.bz2 iurt-11b6ea8738a68f2615b0a8b5095396cc2ed14176.tar.xz iurt-11b6ea8738a68f2615b0a8b5095396cc2ed14176.zip |
- use file::slurp rather than reading the file ourself ( simpler and more efficient )
-rwxr-xr-x | ulri | 9 |
1 files changed, 2 insertions, 7 deletions
@@ -43,6 +43,7 @@ use File::Path 'make_path'; use File::Temp 'mktemp'; use Filesys::Df qw(df); use Data::Dumper; +use File::Slurp qw(read_file); my %run; my $program_name = 'ulri'; @@ -507,13 +508,7 @@ foreach my $prefix (keys %pkg_tree) { $text .= "\nFailure details available in $fpath/log\n"; $text .= "Reason:\n"; - open my $FP, "$fail_dir/$prefix/log/status.log"; - local $_; - while (<$FP>) { - $text .= $_; - } - close $FP; - + $text .= read_file("$fail_dir/$prefix/log/status.log"); $text .= "\nLog files generated:\n"; opendir my $DP1, "$fail_dir/$prefix/log/"; |