aboutsummaryrefslogtreecommitdiffstats
path: root/tests/uploads/filespec_test.php
diff options
context:
space:
mode:
authorFyorl <gaelreth@gmail.com>2012-07-08 02:15:48 +0100
committerFyorl <gaelreth@gmail.com>2012-07-09 14:08:20 +0100
commitd89af53f6311d9f4cec60d136cf017df9e1a36cd (patch)
treefba0bdb8f92b82f4c96230f5b340f070e3b55778 /tests/uploads/filespec_test.php
parentaf8020b3885266a963583b465be58b557c928368 (diff)
downloadforums-d89af53f6311d9f4cec60d136cf017df9e1a36cd.tar
forums-d89af53f6311d9f4cec60d136cf017df9e1a36cd.tar.gz
forums-d89af53f6311d9f4cec60d136cf017df9e1a36cd.tar.bz2
forums-d89af53f6311d9f4cec60d136cf017df9e1a36cd.tar.xz
forums-d89af53f6311d9f4cec60d136cf017df9e1a36cd.zip
[ticket/10941] Added some comments for clarification
PHPBB3-10941
Diffstat (limited to 'tests/uploads/filespec_test.php')
-rw-r--r--tests/uploads/filespec_test.php8
1 files changed, 8 insertions, 0 deletions
diff --git a/tests/uploads/filespec_test.php b/tests/uploads/filespec_test.php
index fe642ea24c..c3e3ddf8f2 100644
--- a/tests/uploads/filespec_test.php
+++ b/tests/uploads/filespec_test.php
@@ -37,6 +37,9 @@ class phpbb_filespec_test extends phpbb_test_case
$config['rand_seed'] = '';
$config['rand_seed_last_update'] = time() + 600;
+ // This config value is normally pulled from the database which is set
+ // to this value at install time.
+ // See: phpBB/install/schemas/schema_data.sql
$config['mime_triggers'] = 'body|head|html|img|plaintext|a href|pre|script|table|title';
$user = new phpbb_mock_user();
@@ -104,6 +107,9 @@ class phpbb_filespec_test extends phpbb_test_case
public function additional_checks_variables()
{
+ // False here just indicates the file is too large and fails the
+ // filespec::additional_checks method because of it. All other code
+ // paths in that method are covered elsewhere.
return array(
array('gif', true),
array('jpg', false),
@@ -129,6 +135,8 @@ class phpbb_filespec_test extends phpbb_test_case
public function check_content_variables()
{
+ // False here indicates that a file is non-binary and contains
+ // disallowed content that makes IE report the mimetype incorrectly.
return array(
array('gif', true),
array('jpg', true),