diff options
author | Andreas Fischer <bantu@phpbb.com> | 2014-03-13 00:53:07 +0100 |
---|---|---|
committer | Andreas Fischer <bantu@phpbb.com> | 2014-03-13 00:53:07 +0100 |
commit | e123b0c0a0791ac68b6099c2942eba8f6acbf56b (patch) | |
tree | dec899290087b9329e917646d1b1a70180e3d5f3 /tests/test_framework | |
parent | d3ddf29e59c9670ef62c11a6eef3821b1b6f3334 (diff) | |
download | forums-e123b0c0a0791ac68b6099c2942eba8f6acbf56b.tar forums-e123b0c0a0791ac68b6099c2942eba8f6acbf56b.tar.gz forums-e123b0c0a0791ac68b6099c2942eba8f6acbf56b.tar.bz2 forums-e123b0c0a0791ac68b6099c2942eba8f6acbf56b.tar.xz forums-e123b0c0a0791ac68b6099c2942eba8f6acbf56b.zip |
[ticket/12176] Reword comment about config entries.
PHPBB3-12176
Diffstat (limited to 'tests/test_framework')
-rw-r--r-- | tests/test_framework/phpbb_functional_test_case.php | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/tests/test_framework/phpbb_functional_test_case.php b/tests/test_framework/phpbb_functional_test_case.php index 857112f29e..5dfe07d380 100644 --- a/tests/test_framework/phpbb_functional_test_case.php +++ b/tests/test_framework/phpbb_functional_test_case.php @@ -424,10 +424,12 @@ class phpbb_functional_test_case extends phpbb_test_case } /* - * We need add some configs into the config array here, otherwise - * the set_config() function will try to add the value to the database, - * because some DBMS return 0 for sql_affectedrows() when a row was found, - * but not changed. + * Add required config entries to the config array to prevent + * set_config() sending an INSERT query for already existing entries, + * resulting in a SQL error. + * This is because set_config() first sends an UPDATE query, then checks + * sql_affectedrows() which can be 0 (e.g. on MySQL) when the new + * data is already there. */ $config['newest_user_colour'] = ''; $config['rand_seed'] = ''; |