[ticket/11548] Run array_map on complete error array and not just colour_error

Up to now the array_map() that turns error messages into the localized output
was only ran if the group's color was set. With this patch it'll run the
array_map() on the complete error array if it's not empty.

PHPBB3-11548

1 files changed, 50 insertions, 0 deletions

diff --git a/tests/functional/ucp_groups_test.php b/tests/functional/ucp_groups_test.php
index 9c6b1edc5e..7c50f7bb24 100644
--- a/tests/functional/ucp_groups_test.php
+++ b/tests/functional/ucp_groups_test.php
@@ -18,4 +18,54 @@ class phpbb_functional_ucp_groups_test extends phpbb_functional_common_groups_te
 	{
 		return 'ucp.php?i=groups&mode=manage&action=edit';
 	}
+
+	// Enable all avatars in the ACP
+	private function enable_all_avatars()
+	{
+		$this->add_lang('acp/board');
+
+		$crawler = $this->request('GET', 'adm/index.php?i=board&mode=avatar&sid=' . $this->sid);
+		// Check the default entries we should have
+		$this->assertContains($this->lang('ALLOW_REMOTE'), $crawler->text());
+		$this->assertContains($this->lang('ALLOW_AVATARS'), $crawler->text());
+		$this->assertContains($this->lang('ALLOW_LOCAL'), $crawler->text());
+
+		// Now start setting the needed settings
+		$form = $crawler->selectButton($this->lang('SUBMIT'))->form();
+		$form['config[allow_avatar_local]']->select(1);
+		$form['config[allow_avatar_remote]']->select(1);
+		$form['config[allow_avatar_remote_upload]']->select(1);
+		$crawler = $this->client->submit($form);
+		$this->assertContains($this->lang('CONFIG_UPDATED'), $crawler->text());
+	}
+
+	public function group_avatar_min_max_data()
+	{
+		return array(
+			array('uploadurl', 'foo', 'TOO_SHORT'),
+			array('uploadurl', 'foobar', 'AVATAR_URL_INVALID'),
+			array('uploadurl', str_repeat('f', 256), 'TOO_LONG'),
+			array('remotelink', 'foo', 'TOO_SHORT'),
+			array('remotelink', 'foobar', 'AVATAR_URL_INVALID'),
+			array('remotelink', str_repeat('f', 256), 'TOO_LONG'),
+		);
+	}
+
+	/**
+	* @dataProvider group_avatar_min_max_data
+	*/
+	public function test_group_avatar_min_max($form_name, $input, $expected)
+	{
+		$this->login();
+		$this->admin_login();
+		$this->add_lang(array('ucp', 'acp/groups'));
+		$this->enable_all_avatars();
+
+		$crawler = $this->request('GET', $this->get_url() . '&g=5&sid=' . $this->sid);
+		$this->assert_response_success();
+		$form = $crawler->selectButton($this->lang('SUBMIT'))->form();
+		$form[$form_name]->setValue($input);
+		$crawler = $this->client->submit($form);
+		$this->assertContains($this->lang($expected), $crawler->text());
+	}
 }