diff options
| author | Oleg Pudeyev <oleg@bsdpower.com> | 2012-12-01 20:12:31 -0500 |
|---|---|---|
| committer | Oleg Pudeyev <oleg@bsdpower.com> | 2012-12-01 23:09:29 -0500 |
| commit | d0338531cb2a3a386a3894a1b1b081025f53ea05 (patch) | |
| tree | 72df633aa76e17d891ef24398602b1836a44d09a /phpBB | |
| parent | ac9c4d7d59ea458834cb64b9c9020c3de8fe90a2 (diff) | |
| download | forums-d0338531cb2a3a386a3894a1b1b081025f53ea05.tar forums-d0338531cb2a3a386a3894a1b1b081025f53ea05.tar.gz forums-d0338531cb2a3a386a3894a1b1b081025f53ea05.tar.bz2 forums-d0338531cb2a3a386a3894a1b1b081025f53ea05.tar.xz forums-d0338531cb2a3a386a3894a1b1b081025f53ea05.zip | |
[ticket/11162] An implementation that actually works.
PHPBB3-11162
Diffstat (limited to 'phpBB')
| -rw-r--r-- | phpBB/includes/functions.php | 73 |
1 files changed, 68 insertions, 5 deletions
diff --git a/phpBB/includes/functions.php b/phpBB/includes/functions.php index 8608c6ca4f..13690e79bb 100644 --- a/phpBB/includes/functions.php +++ b/phpBB/includes/functions.php @@ -1311,12 +1311,75 @@ function tz_select($default = '', $truncate = false) */ function phpbb_update_rows_avoiding_duplicates($db, $table, $column, $from_values, $to_value) { - $db->sql_return_on_error(true); - $condition = $db->sql_in_set($column, $from_values); - $db->sql_query('UPDATE ' . $table . ' SET ' . $column . ' = ' . (int) $to_value. ' WHERE ' . $condition); - $db->sql_return_on_error(false); + $sql = "SELECT $column, user_id + FROM $table + WHERE " . $db->sql_in_set($column, $from_values); + $result = $db->sql_query($sql); + + $old_user_ids = array(); + while ($row = $db->sql_fetchrow($result)) + { + $old_user_ids[$row[$column]][] = $row['user_id']; + } + $db->sql_freeresult($result); + + $sql = "SELECT $column, user_id + FROM $table + WHERE $column = '" . (int) $to_value . "'"; + $result = $db->sql_query($sql); + + $new_user_ids = array(); + while ($row = $db->sql_fetchrow($result)) + { + $new_user_ids[$row[$column]][] = $row['user_id']; + } + $db->sql_freeresult($result); - $db->sql_query('DELETE FROM ' . $table . ' WHERE ' . $condition); + $queries = array(); + $any_found = false; + foreach ($from_values as $from_value) + { + if (!isset($old_user_ids[$from_value])) + { + continue; + } + $any_found = true; + if (empty($new_user_ids)) + { + $sql = "UPDATE $table + SET $column = " . (int) $to_value. " + WHERE $column = '" . $db->sql_escape($from_value) . "'"; + $queries[] = $sql; + } + else + { + $different_user_ids = array_diff($old_user_ids[$from_value], $new_user_ids[$to_value]); + if (!empty($different_user_ids)) + { + $sql = "UPDATE $table + SET $column = " . (int) $to_value. " + WHERE $column = '" . $db->sql_escape($from_value) . "' + AND " . $db->sql_in_set('user_id', $different_user_ids); + $queries[] = $sql; + } + } + } + + if ($any_found) + { + //$db->sql_transaction('begin'); + + foreach ($queries as $sql) + { + $db->sql_query($sql); + } + + $sql = "DELETE FROM $table + WHERE " . $db->sql_in_set($column, $from_values); + $db->sql_query($sql); + + //$db->sql_transaction('commit'); + } } // Functions handling topic/post tracking/marking |