diff options
| author | rxu <rxu@mail.ru> | 2012-01-14 15:50:47 +0800 |
|---|---|---|
| committer | rxu <rxu@mail.ru> | 2012-01-14 16:09:04 +0800 |
| commit | cb7bb31129a38cbdbeb682e869e51b1199b43bfb (patch) | |
| tree | 3766bca42824473dcf97af794b4bb5cad6bbc400 /phpBB/search.php | |
| parent | c9733ad7195995a9f28ecbbc8aa3e94a05527114 (diff) | |
| download | forums-cb7bb31129a38cbdbeb682e869e51b1199b43bfb.tar forums-cb7bb31129a38cbdbeb682e869e51b1199b43bfb.tar.gz forums-cb7bb31129a38cbdbeb682e869e51b1199b43bfb.tar.bz2 forums-cb7bb31129a38cbdbeb682e869e51b1199b43bfb.tar.xz forums-cb7bb31129a38cbdbeb682e869e51b1199b43bfb.zip | |
[ticket/10532] Adjust total match count and limit
Set a variable for the limit of total matches count.
Adjust total match count to limit to provide proper $start value calculation.
Adjust $start value if no matches were found.
PHPBB3-10532
Diffstat (limited to 'phpBB/search.php')
| -rw-r--r-- | phpBB/search.php | 27 |
1 files changed, 21 insertions, 6 deletions
diff --git a/phpBB/search.php b/phpBB/search.php index 07be438ab4..3956478371 100644 --- a/phpBB/search.php +++ b/phpBB/search.php @@ -469,14 +469,18 @@ if ($keywords || $author || $author_id || $search_id || $submit) $per_page = ($show_results == 'posts') ? $config['posts_per_page'] : $config['topics_per_page']; $total_match_count = 0; + // Set limit for the $total_match_count to reduce server load + $total_matches_limit = 1000; + $found_more_search_matches = false; + if ($search_id) { if ($sql || $search_id == 'unreadposts') { if ($sql) { - // only return up to 1000 ids (the last one will be removed later) - $result = $db->sql_query_limit($sql, 1001); + // Only return up to $total_matches_limit+1 ids (the last one will be removed later) + $result = $db->sql_query_limit($sql, ($total_matches_limit + 1)); while ($row = $db->sql_fetchrow($result)) { @@ -486,11 +490,19 @@ if ($keywords || $author || $author_id || $search_id || $submit) } else if ($search_id == 'unreadposts') { - $id_ary = array_keys(get_unread_topics($user->data['user_id'], $sql_where, $sql_sort, 1001)); + // Only return up to $total_matches_limit+1 ids (the last one will be removed later) + $id_ary = array_keys(get_unread_topics($user->data['user_id'], $sql_where, $sql_sort, ($total_matches_limit + 1))); } if ($total_match_count = sizeof($id_ary)) { + // Limit the number to $total_matches_limit for pre-made searches + if ($total_match_count > $total_matches_limit) + { + $found_more_search_matches = true; + $total_match_count = $total_matches_limit; + } + // Make sure $start is set to the last page if it exceeds the amount if ($start < 0 || $start >= $total_match_count) { @@ -498,6 +510,11 @@ if ($keywords || $author || $author_id || $search_id || $submit) } $id_ary = array_slice($id_ary, $start, $per_page); } + else + { + // Set $start to 0 if no matches were found + $start = 0; + } } else { @@ -550,10 +567,8 @@ if ($keywords || $author || $author_id || $search_id || $submit) $icons = $cache->obtain_icons(); // Output header - if ($search_id && ($total_match_count > 1000)) + if ($found_more_search_matches) { - // limit the number to 1000 for pre-made searches - $total_match_count--; $l_search_matches = sprintf($user->lang['FOUND_MORE_SEARCH_MATCHES'], $total_match_count); } else |