diff options
| author | Meik Sievertsen <acydburn@phpbb.com> | 2008-08-22 12:52:48 +0000 |
|---|---|---|
| committer | Meik Sievertsen <acydburn@phpbb.com> | 2008-08-22 12:52:48 +0000 |
| commit | 6c763cd8b65c1b63d57fb0f176d2c98a44076df1 (patch) | |
| tree | bdc638c998285ad49a0876b2e5394ea31845649a /phpBB/install/install_install.php | |
| parent | 88c324a2a3d705cd44ce749af44079849ca091e7 (diff) | |
| download | forums-6c763cd8b65c1b63d57fb0f176d2c98a44076df1.tar forums-6c763cd8b65c1b63d57fb0f176d2c98a44076df1.tar.gz forums-6c763cd8b65c1b63d57fb0f176d2c98a44076df1.tar.bz2 forums-6c763cd8b65c1b63d57fb0f176d2c98a44076df1.tar.xz forums-6c763cd8b65c1b63d57fb0f176d2c98a44076df1.zip | |
change the way we do chmodd'ing. I know, my implementation really sucked... good we have motivated community members who point this out. ;) Thanks to faw for providing a way better function and for discussing and also abiding to our needs. :) LEW21 should maybe credited too... he gave the inspiration without knowing it.
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@8780 89ea8834-ac86-4346-8a33-228a782c2dd0
Diffstat (limited to 'phpBB/install/install_install.php')
| -rw-r--r-- | phpBB/install/install_install.php | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/phpBB/install/install_install.php b/phpBB/install/install_install.php index 7959552413..cfa74fba03 100644 --- a/phpBB/install/install_install.php +++ b/phpBB/install/install_install.php @@ -438,14 +438,13 @@ class install_install extends module if (!file_exists($phpbb_root_path . $dir)) { @mkdir($phpbb_root_path . $dir, 0777); - phpbb_chmod($phpbb_root_path . $dir, 'rwrite'); + phpbb_chmod($phpbb_root_path . $dir, CHMOD_READ | CHMOD_WRITE); } // Now really check if (file_exists($phpbb_root_path . $dir) && is_dir($phpbb_root_path . $dir)) { - // Make writeable only for apache user - phpbb_chmod($phpbb_root_path . $dir, 'rwrite'); + phpbb_chmod($phpbb_root_path . $dir, CHMOD_READ | CHMOD_WRITE); $exists = true; } @@ -875,7 +874,7 @@ class install_install extends module } @fclose($fp); - phpbb_chmod($phpbb_root_path . 'cache/install_lock', 'write-all'); + @chmod($phpbb_root_path . 'cache/install_lock', 0777); $load_extensions = implode(',', $load_extensions); @@ -928,8 +927,8 @@ class install_install extends module if ($written) { - // Readable by apache user/group, not by any other means - phpbb_chmod($phpbb_root_path . 'config.' . $phpEx, 'rread'); + // We may revert back to chmod() if we see problems with users not able to change their config.php file directly + phpbb_chmod($phpbb_root_path . 'config.' . $phpEx, CHMOD_READ); } } |