aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes/acp/acp_permissions.php
diff options
context:
space:
mode:
authorTristan Darricau <github@nicofuma.fr>2014-05-10 01:53:51 +0200
committerTristan Darricau <github@nicofuma.fr>2014-05-10 01:53:51 +0200
commit9b9c048702fe669220e6e001e140e2daa6d0f0a2 (patch)
treebdd98b14f306768c305c191a8eb9138a986cd491 /phpBB/includes/acp/acp_permissions.php
parentd4fc060bcd61228fdf78da4f2d290a7a17546c46 (diff)
downloadforums-9b9c048702fe669220e6e001e140e2daa6d0f0a2.tar
forums-9b9c048702fe669220e6e001e140e2daa6d0f0a2.tar.gz
forums-9b9c048702fe669220e6e001e140e2daa6d0f0a2.tar.bz2
forums-9b9c048702fe669220e6e001e140e2daa6d0f0a2.tar.xz
forums-9b9c048702fe669220e6e001e140e2daa6d0f0a2.zip
[ticket/12109] Bug when setting permissions with "Select all users"
https://tracker.phpbb.com/browse/PHPBB3-12109 PHPBB3-12109
Diffstat (limited to 'phpBB/includes/acp/acp_permissions.php')
-rw-r--r--phpBB/includes/acp/acp_permissions.php24
1 files changed, 16 insertions, 8 deletions
diff --git a/phpBB/includes/acp/acp_permissions.php b/phpBB/includes/acp/acp_permissions.php
index 1924e2075b..12304b9e66 100644
--- a/phpBB/includes/acp/acp_permissions.php
+++ b/phpBB/includes/acp/acp_permissions.php
@@ -330,14 +330,6 @@ class acp_permissions
}
}
- // Setting permissions screen
- $s_hidden_fields = build_hidden_fields(array(
- 'user_id' => $user_id,
- 'group_id' => $group_id,
- 'forum_id' => $forum_id,
- 'type' => $permission_type)
- );
-
// Go through the screens/options needed and present them in correct order
foreach ($permission_victim as $victim)
{
@@ -470,6 +462,14 @@ class acp_permissions
// If there are more than 5 forums selected the admin is not able to select all users/groups too.
// We need to see if the number of forums can be increased or need to be decreased.
+ // Setting permissions screen
+ $s_hidden_fields = build_hidden_fields(array(
+ 'user_id' => $user_id,
+ 'group_id' => $group_id,
+ 'forum_id' => $forum_id,
+ 'type' => $permission_type)
+ );
+
$template->assign_vars(array(
'U_ACTION' => $this->u_action,
'ANONYMOUS_USER_ID' => ANONYMOUS,
@@ -506,6 +506,14 @@ class acp_permissions
return;
}
+ // Setting permissions screen
+ $s_hidden_fields = build_hidden_fields(array(
+ 'user_id' => $user_id,
+ 'group_id' => $group_id,
+ 'forum_id' => $forum_id,
+ 'type' => $permission_type)
+ );
+
// Do not allow forum_ids being set and no other setting defined (will bog down the server too much)
if (sizeof($forum_id) && !sizeof($user_id) && !sizeof($group_id))
{