aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes/acp/acp_board.php
diff options
context:
space:
mode:
authorNils Adermann <naderman@naderman.de>2011-06-05 09:52:17 +0200
committerNils Adermann <naderman@naderman.de>2011-06-05 09:52:17 +0200
commit26e052bb26a683bff17d86ae2beecc66ffcd93cf (patch)
tree29b98ad640f3c4e2446c9b4169aca94a68347d82 /phpBB/includes/acp/acp_board.php
parent8155bc5a9dbbe5ad6a9ceb722baf4587db8f3689 (diff)
downloadforums-26e052bb26a683bff17d86ae2beecc66ffcd93cf.tar
forums-26e052bb26a683bff17d86ae2beecc66ffcd93cf.tar.gz
forums-26e052bb26a683bff17d86ae2beecc66ffcd93cf.tar.bz2
forums-26e052bb26a683bff17d86ae2beecc66ffcd93cf.tar.xz
forums-26e052bb26a683bff17d86ae2beecc66ffcd93cf.zip
[ticket/10067] Add separator to h_radio to place options on individual lines
The previous mechanism for account activation resulted in two h_radio calls with identical id attributes for two elements. PHPBB3/10067
Diffstat (limited to 'phpBB/includes/acp/acp_board.php')
-rw-r--r--phpBB/includes/acp/acp_board.php17
1 files changed, 9 insertions, 8 deletions
diff --git a/phpBB/includes/acp/acp_board.php b/phpBB/includes/acp/acp_board.php
index 8f7d08cc8f..d38c4d58ba 100644
--- a/phpBB/includes/acp/acp_board.php
+++ b/phpBB/includes/acp/acp_board.php
@@ -769,18 +769,19 @@ class acp_board
{
global $user, $config;
- $radio_ary = array(USER_ACTIVATION_DISABLE => 'ACC_DISABLE', USER_ACTIVATION_NONE => 'ACC_NONE');
- $radio_text = h_radio('config[require_activation]', $radio_ary, $value, $key);
+ $radio_ary = array(
+ USER_ACTIVATION_DISABLE => 'ACC_DISABLE',
+ USER_ACTIVATION_NONE => 'ACC_NONE',
+ );
+
if ($config['email_enable'])
{
- $radio_ary = array(USER_ACTIVATION_SELF => 'ACC_USER', USER_ACTIVATION_ADMIN => 'ACC_ADMIN');
- // With longer labels the four options no longer fit
- // onto a single line. Separate them onto two lines.
- // This also requires two h_radio calls to generate HTML.
- $radio_text .= '<br /><br />';
- $radio_text .= h_radio('config[require_activation]', $radio_ary, $value, $key);
+ $radio_ary[USER_ACTIVATION_SELF] = 'ACC_USER';
+ $radio_ary[USER_ACTIVATION_ADMIN] = 'ACC_ADMIN';
}
+ $radio_text = h_radio('config[require_activation]', $radio_ary, $value, 'require_activation', $key, '<br />');
+
return $radio_text;
}