diff options
| author | Joas Schilling <nickvergessen@gmx.de> | 2013-07-11 11:52:12 +0200 |
|---|---|---|
| committer | Joas Schilling <nickvergessen@gmx.de> | 2013-07-11 11:52:12 +0200 |
| commit | cdb13fc7be4771bc89da624fe0b5f38b0cc3ccd1 (patch) | |
| tree | 94a0f337e980f1c017a1b4d144426e233999a7cd | |
| parent | bdb7ec0ceb3210955b2457bfe6fe469b1781d8d6 (diff) | |
| download | forums-cdb13fc7be4771bc89da624fe0b5f38b0cc3ccd1.tar forums-cdb13fc7be4771bc89da624fe0b5f38b0cc3ccd1.tar.gz forums-cdb13fc7be4771bc89da624fe0b5f38b0cc3ccd1.tar.bz2 forums-cdb13fc7be4771bc89da624fe0b5f38b0cc3ccd1.tar.xz forums-cdb13fc7be4771bc89da624fe0b5f38b0cc3ccd1.zip | |
[ticket/9657] Correctly use " vs ' and variables in queries
PHPBB3-9657
| -rw-r--r-- | phpBB/includes/content_visibility.php | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/phpBB/includes/content_visibility.php b/phpBB/includes/content_visibility.php index ac827bd822..88f57a0020 100644 --- a/phpBB/includes/content_visibility.php +++ b/phpBB/includes/content_visibility.php @@ -126,11 +126,11 @@ class phpbb_content_visibility else { // The user is just a normal user - return "$table_alias{$mode}_visibility = " . ITEM_APPROVED . ' + return $table_alias . $mode . '_visibility = ' . ITEM_APPROVED . ' AND ' . $db->sql_in_set($table_alias . 'forum_id', $forum_ids, false, true); } - $where_sql .= "($table_alias{$mode}_visibility = " . ITEM_APPROVED . ' + $where_sql .= '(' . $table_alias . $mode . '_visibility = ' . ITEM_APPROVED . ' AND ' . $db->sql_in_set($table_alias . 'forum_id', $forum_ids) . '))'; return $where_sql; @@ -157,12 +157,12 @@ class phpbb_content_visibility if (sizeof($exclude_forum_ids)) { - $where_sqls[] = '(' . $db->sql_in_set($table_alias . 'forum_id', $exclude_forum_ids, true) . " - AND $table_alias{$mode}_visibility = " . ITEM_APPROVED . ')'; + $where_sqls[] = '(' . $db->sql_in_set($table_alias . 'forum_id', $exclude_forum_ids, true) . ' + AND ' . $table_alias . $mode . '_visibility = ' . ITEM_APPROVED . ')'; } else { - $where_sqls[] = "$table_alias{$mode}_visibility = " . ITEM_APPROVED; + $where_sqls[] = $table_alias . $mode . '_visibility = ' . ITEM_APPROVED; } if (sizeof($approve_forums)) |