diff options
| author | Joas Schilling <nickvergessen@gmx.de> | 2013-07-30 00:46:18 +0200 |
|---|---|---|
| committer | Joas Schilling <nickvergessen@gmx.de> | 2013-07-30 00:46:18 +0200 |
| commit | 69feffec8b4be93dab6d0163cb5782404ead6b4e (patch) | |
| tree | 6663bfc3801d62fc93c19e5765f6b04b42305ba3 | |
| parent | 935001b7a2bb89a7429b535ec745757275ae76d6 (diff) | |
| parent | dd875f13e875a726c9ea4654a90a74878658e423 (diff) | |
| download | forums-69feffec8b4be93dab6d0163cb5782404ead6b4e.tar forums-69feffec8b4be93dab6d0163cb5782404ead6b4e.tar.gz forums-69feffec8b4be93dab6d0163cb5782404ead6b4e.tar.bz2 forums-69feffec8b4be93dab6d0163cb5782404ead6b4e.tar.xz forums-69feffec8b4be93dab6d0163cb5782404ead6b4e.zip | |
Merge remote-tracking branch 'Elsensee/ticket/10917-2' into develop-olympus
* Elsensee/ticket/10917-2:
[ticket/10917] Variable used only once so delete it
[ticket/10917] Revert use of phpbb wrapper
| -rw-r--r-- | phpBB/install/install_update.php | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/phpBB/install/install_update.php b/phpBB/install/install_update.php index 9ac17e7579..2f3ee1c55a 100644 --- a/phpBB/install/install_update.php +++ b/phpBB/install/install_update.php @@ -58,7 +58,6 @@ class install_update extends module var $new_location; var $latest_version; var $current_version; - var $unequal_version; var $update_to_version; @@ -76,7 +75,6 @@ class install_update extends module $this->tpl_name = 'install_update'; $this->page_title = 'UPDATE_INSTALLATION'; - $this->unequal_version = false; $this->old_location = $phpbb_root_path . 'install/update/old/'; $this->new_location = $phpbb_root_path . 'install/update/new/'; @@ -195,8 +193,6 @@ class install_update extends module // Check if the update files are actually meant to update from the current version if ($this->current_version != $this->update_info['version']['from']) { - $this->unequal_version = true; - $template->assign_vars(array( 'S_ERROR' => true, 'ERROR_MSG' => sprintf($user->lang['INCOMPATIBLE_UPDATE_FILES'], $this->current_version, $this->update_info['version']['from'], $this->update_info['version']['to']), @@ -204,10 +200,8 @@ class install_update extends module } // Check if the update files stored are for the latest version... - if (phpbb_version_compare($this->latest_version, $this->update_info['version']['to'], '>')) + if (version_compare(strtolower($this->latest_version), strtolower($this->update_info['version']['to']), '>')) { - $this->unequal_version = true; - $template->assign_vars(array( 'S_WARNING' => true, 'WARNING_MSG' => sprintf($user->lang['OLD_UPDATE_FILES'], $this->update_info['version']['from'], $this->update_info['version']['to'], $this->latest_version)) @@ -294,7 +288,7 @@ class install_update extends module ); // Print out version the update package updates to - if ($this->unequal_version) + if ($this->latest_version != $this->update_info['version']['to']) { $template->assign_var('PACKAGE_VERSION', $this->update_info['version']['to']); } |