aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul S. Owen <psotfx@users.sourceforge.net>2001-03-09 14:04:48 +0000
committerPaul S. Owen <psotfx@users.sourceforge.net>2001-03-09 14:04:48 +0000
commit68dd148f6cc43add65baa1c05d75e2823810e262 (patch)
tree01d05bf774df3f56c5549b56f402247e134dada7
parenta5173dd59b52e90984b02a818df8c6e39aa2321d (diff)
downloadforums-68dd148f6cc43add65baa1c05d75e2823810e262.tar
forums-68dd148f6cc43add65baa1c05d75e2823810e262.tar.gz
forums-68dd148f6cc43add65baa1c05d75e2823810e262.tar.bz2
forums-68dd148f6cc43add65baa1c05d75e2823810e262.tar.xz
forums-68dd148f6cc43add65baa1c05d75e2823810e262.zip
Reduced query number, changed parameter names
git-svn-id: file:///svn/phpbb/trunk@87 89ea8834-ac86-4346-8a33-228a782c2dd0
-rw-r--r--phpBB/viewtopic.php343
1 files changed, 171 insertions, 172 deletions
diff --git a/phpBB/viewtopic.php b/phpBB/viewtopic.php
index e93da664f5..e6708853c4 100644
--- a/phpBB/viewtopic.php
+++ b/phpBB/viewtopic.php
@@ -20,79 +20,72 @@
*
*
***************************************************************************/
- include('extension.inc');
+include('extension.inc');
include('common.'.$phpEx);
+$topic_id = $HTTP_GET_VARS[POST_TOPIC_URL];
+
$is_moderator = 0;
-if(!isset($forum_id) || !isset($topic_id))
+if(!isset($topic_id))
{
error_die($db, GENERAL_ERROR, "You have reached this page in error, please go back and try again");
}
-$sql = "SELECT f.forum_type, f.forum_name, u.username, u.user_id
- FROM ".FORUMS_TABLE." f, ".FORUM_MODS_TABLE." fm, ".USERS_TABLE." u
- WHERE f.forum_id = '$forum_id'
- AND fm.forum_id = '$forum_id'
- AND u.user_id = fm.user_id";
+
+$sql = "SELECT t.topic_title, t.topic_status, t.topic_replies,
+ f.forum_type, f.forum_name, f.forum_id, u.username, u.user_id
+ FROM ".TOPICS_TABLE." t, ".FORUMS_TABLE." f, ".FORUM_MODS_TABLE." fm, ".USERS_TABLE." u
+ WHERE t.topic_id = '$topic_id'
+ AND f.forum_id = t.forum_id
+ AND fm.forum_id = t.forum_id
+ AND u.user_id = fm.user_id";
if(!$result = $db->sql_query($sql))
{
error_die($db, QUERY_ERROR);
}
-
-//
-// Add checking for private forums here
-//
-
if(!$total_rows = $db->sql_numrows($result))
{
error_die($db, GENERAL_ERROR, "The forum you selected does not exist. Please go back and try again.");
}
-
$forum_row = $db->sql_fetchrowset($result);
+
+$forum_id = $forum_row[0]["forum_id"];
$forum_name = stripslashes($forum_row[0]["forum_name"]);
for($x = 0; $x < $total_rows; $x++)
{
- $moderators[] = array("user_id" => $forum_row[$x]["user_id"],
- "username" => $forum_row[$x]["username"]);
- if($userdata["user_id"] == $forum_row[$x]["user_id"])
- {
- $is_moderator = 1;
- }
+ $moderators[] = array("user_id" => $forum_row[$x]["user_id"],
+ "username" => $forum_row[$x]["username"]);
+ if($userdata["user_id"] == $forum_row[$x]["user_id"])
+ {
+ $is_moderator = 1;
+ }
}
-if(!isset($start))
-{
- $start = 0;
-}
-$sql = "SELECT topic_title, topic_status, topic_replies
- FROM ".TOPICS_TABLE."
- WHERE topic_id = '$topic_id'";
+//
+// Add checking for private forums here
+//
-if(!$result = $db->sql_query($sql))
-{
- error_die($db, QUERY_ERROR);
-}
-if(!$topic_info = $db->sql_fetchrowset($result))
-{
- error_die($db, GENERAL_ERROR, "Could not get topic data<br>$sql");
-}
+$page_title = "View Topic - $topic_title";
$topic_title = stripslashes($topic_info[0]["topic_title"]);
$total_replies = $topic_info[0]["topic_replies"] + 1;
-
$pagetype = "viewtopic";
-$page_title = "View Topic - $topic_title";
include('page_header.'.$phpEx);
-$sql = "SELECT u.username, u.user_id, u.user_posts, u.user_from, u.user_website, u.user_icq, u.user_aim, u.user_yim,
- u.user_regdate, u.user_msnm, u.user_viewemail, r.rank_title, r.rank_image,
- p.post_time, p.post_id, pt.post_text
- FROM ".POSTS_TABLE." p
- LEFT JOIN ".USERS_TABLE." u ON p.poster_id = u.user_id
- LEFT JOIN ".RANKS_TABLE." r ON (u.user_rank = r.rank_id) AND NOT (u.user_posts > r.rank_min AND u.user_posts < r.rank_max)
- LEFT JOIN ".POSTS_TEXT_TABLE." pt ON p.post_id = pt.post_id
- WHERE p.topic_id = '$topic_id'
- ORDER BY p.post_time ASC LIMIT $start, $posts_per_page";
+if(!isset($start))
+{
+ $start = 0;
+}
+
+$sql = "SELECT u.username, u.user_id, u.user_posts, u.user_from, u.user_website, u.user_icq, u.user_aim, u.user_yim, u.user_regdate, u.user_msnm, u.user_viewemail, r.rank_title, r.rank_image, p.post_time, p.post_id, pt.post_text
+ FROM ".POSTS_TABLE." p
+ LEFT JOIN ".USERS_TABLE." u ON p.poster_id = u.user_id
+ LEFT JOIN ".RANKS_TABLE." r ON (u.user_rank = r.rank_id)
+ AND NOT (u.user_posts > r.rank_min AND u.user_posts < r.rank_max)
+ LEFT JOIN ".POSTS_TEXT_TABLE." pt ON p.post_id = pt.post_id
+ WHERE p.topic_id = '$topic_id'
+ ORDER BY p.post_time ASC
+ LIMIT $start, $posts_per_page";
if(!$result = $db->sql_query($sql))
{
@@ -108,142 +101,148 @@ $template->set_block("body", "postrow", "posts");
for($x = 0; $x < $total_posts; $x++)
{
- $poster = stripslashes($postrow[$x]["username"]);
- $poster_id = $postrow[$x]["user_id"];
- $poster_rank = stripslashes($postrow[$x]["rank_title"]);
- $rank_image = ($postrow[$x]["rank_image"]) ? "<img src=\"".$postrow[$x]["rank_image"]."\">" : "";
- $post_date = date($date_format, $postrow[$x]["post_time"]);
-
- $poster_posts = $postrow[$x]["user_posts"];
- $poster_from = ($postrow[$x]["user_from"]) ? "$l_from: ".$postrow[$x]["user_from"] : "";
- $poster_joined = $postrow[$x]["user_regdate"];
-
- $profile_img = "<a href=\"profile.$phpEx?mode=viewprofile&user_id=$poster_id\"><img src=\"$image_profile\" alt=\"$l_profileof $poster\" border=\"0\"></a>";
- $email_img = ($postrow[$x]["user_viewemail"] == 1) ? "<a href=\"mailto:".$postrow[$x]["user_email"]."\"><img src=\"$image_email\" alt=\"$l_email $poster\" border=\"0\"></a>" : "";
- $www_img = ($postrow[$x]["user_website"]) ? "<a href=\"".$postrow[$x]["user_website"]."\"><img src=\"$image_www\" alt=\"$l_viewsite\" border=\"0\"></a>" : "";
- if($postrow[$x]["user_icq"])
- {
-
- $icq_status_img = "<a href=\"http://wwp.icq.com/".$postrow[$x]["user_icq"]."#pager\"><img src=\"http://online.mirabilis.com/scripts/online.dll?icq=".$postrow[$x]["user_icq"]."&img=5\" alt=\"$l_icqstatus\" border=\"0\"></a>";
- $icq_add_img = "<a href=\"http://wwp.icq.com/scripts/search.dll?to=".$postrow[$x]["user_icq"]."\"><img src=\"$image_icq\" alt=\"$l_icq\" border=\"0\"></a>";
- }
- else
- {
- $icq_status_img = "";
- $icq_add_img = "";
- }
- $aim_img = ($postrow[$x]["user_aim"]) ? "<a href=\"aim:goim?screenname=".$postrow[$x]["user_aim"]."&message=Hello+Are+you+there?\"><img src=\"$image_aim\" border=\"0\"></a>" : "";
- $msn_img = ($postrow[$x]["user_msnm"]) ? "<a href=\"profile.$phpEx?mode=viewprofile&user_id=$poster_id\"><img src=\"$image_msn\" border=\"0\"></a>" : "";
- $yim_img = ($postrow[$x]["user_yim"]) ? "<a href=\"http://edit.yahoo.com/config/send_webmesg?.target=".$postrow[$x]["user_yim"]."&.src=pg\"><img src=\"$image_yim\" border=\"0\"></a>" : "";
-
- $edit_img = "<a href=\"posting.$phpEx?mode=editpost&post_id=".$postrow[$x]["post_id"]."&topic_id=$topic_id&forum_id=$forum_id\"><img src=\"$image_edit\" alt=\"$l_editdelete\" border=\"0\"></a>";
- $quote_img = "<a href=\"posting.$phpEx?mode=reply&quote=true&post_id=".$postrow[$x]["post_id"]."&topic_id=$topic_id&forum_id=$forum_id\"><img src=\"$image_quote\" alt=\"$l_replyquote\" border=\"0\"></a>";
- $pmsg_img = "<a href=\"priv_msgs.$phpEx?mode=send\"><img src=\"$image_pmsg\" alt=\"$l_sendpmsg\" border=\"0\"></a>";
- if($is_moderator)
- {
- $ip_img = "<a href=\"topicadmin.$phpEx?mode=viewip&user_id=".$poster_id."\"><img src=\"$image_ip\" alt=\"$l_viewip\" border=\"0\"></a>";
- $delpost_img = "<a href=\"topicadmin.$phpEx?mode=delpost$post_id=".$postrow[$x]["post_id"]."\"><img src=\"$image_delpost\" alt=\"$l_delete\" border=\"0\"></a>";
- }
-
- $message = stripslashes($postrow[$x]["post_text"]);
- if(!$allow_html)
- {
- $message = strip_tags($message);
- }
- if($allow_bbcode)
- {
- // do bbcode stuff here
- }
-
- if(!($x % 2))
- {
- $color = "#DDDDDD";
- }
- else
- {
- $color = "#CCCCCC";
- }
-
- $message = eregi_replace("\[addsig]$", "<BR>_________________<BR>" . stripslashes($postrow[$x]["user_sig"]), $message);
-
- $template->set_var(array("TOPIC_TITLE" => $topic_title,
- "L_POSTED" => $l_posted,
- "L_JOINED" => $l_joined,
- "POSTER_NAME" => $poster,
- "POSTER_RANK" => $poster_rank,
- "RANK_IMAGE" => $rank_image,
- "ROW_COLOR" => $color,
- "POSTER_JOINED" => $poster_joined,
- "POSTER_POSTS" => $poster_posts,
- "POSTER_FROM" => $poster_from,
- "POST_DATE" => $post_date,
- "MESSAGE" => $message,
- "PROFILE_IMG" => $profile_img,
- "EMAIL_IMG" => $email_img,
- "WWW_IMG" => $www_img,
- "ICQ_STATUS_IMG" => $icq_status_img,
- "ICQ_ADD_IMG" => $icq_add_img,
- "AIM_IMG" => $aim_img,
- "MSN_IMG" => $msn_img,
- "YIM_IMG" => $yim_img,
- "EDIT_IMG" => $edit_img,
- "QUOTE_IMG" => $quote_img,
- "PMSG_IMG" => $pmsg_img,
- "IP_IMG" => $ip_img,
- "DELPOST_IMG" => $delpost_img));
- $template->parse("posts", "postrow", true);
+ $poster = stripslashes($postrow[$x]["username"]);
+ $poster_id = $postrow[$x]["user_id"];
+ $poster_rank = stripslashes($postrow[$x]["rank_title"]);
+ $rank_image = ($postrow[$x]["rank_image"]) ? "<img src=\"".$postrow[$x]["rank_image"]."\">" : "";
+ $post_date = date($date_format, $postrow[$x]["post_time"]);
+
+ $poster_posts = $postrow[$x]["user_posts"];
+ $poster_from = ($postrow[$x]["user_from"]) ? "$l_from: ".$postrow[$x]["user_from"] : "";
+ $poster_joined = $postrow[$x]["user_regdate"];
+
+ $profile_img = "<a href=\"profile.$phpEx?mode=viewprofile&user_id=$poster_id\"><img src=\"$image_profile\" alt=\"$l_profileof $poster\" border=\"0\"></a>";
+ $email_img = ($postrow[$x]["user_viewemail"] == 1) ? "<a href=\"mailto:".$postrow[$x]["user_email"]."\"><img src=\"$image_email\" alt=\"$l_email $poster\" border=\"0\"></a>" : "";
+ $www_img = ($postrow[$x]["user_website"]) ? "<a href=\"".$postrow[$x]["user_website"]."\"><img src=\"$image_www\" alt=\"$l_viewsite\" border=\"0\"></a>" : "";
+
+ if($postrow[$x]["user_icq"])
+ {
+ $icq_status_img = "<a href=\"http://wwp.icq.com/".$postrow[$x]["user_icq"]."#pager\"><img src=\"http://online.mirabilis.com/scripts/online.dll?icq=".$postrow[$x]["user_icq"]."&img=5\" alt=\"$l_icqstatus\" border=\"0\"></a>";
+ $icq_add_img = "<a href=\"http://wwp.icq.com/scripts/search.dll?to=".$postrow[$x]["user_icq"]."\"><img src=\"$image_icq\" alt=\"$l_icq\" border=\"0\"></a>";
+ }
+ else
+ {
+ $icq_status_img = "";
+ $icq_add_img = "";
+ }
+
+ $aim_img = ($postrow[$x]["user_aim"]) ? "<a href=\"aim:goim?screenname=".$postrow[$x]["user_aim"]."&message=Hello+Are+you+there?\"><img src=\"$image_aim\" border=\"0\"></a>" : "";
+ $msn_img = ($postrow[$x]["user_msnm"]) ? "<a href=\"profile.$phpEx?mode=viewprofile&user_id=$poster_id\"><img src=\"$image_msn\" border=\"0\"></a>" : "";
+ $yim_img = ($postrow[$x]["user_yim"]) ? "<a href=\"http://edit.yahoo.com/config/send_webmesg?.target=".$postrow[$x]["user_yim"]."&.src=pg\"><img src=\"$image_yim\" border=\"0\"></a>" : "";
+
+ $edit_img = "<a href=\"posting.$phpEx?mode=editpost&post_id=".$postrow[$x]["post_id"]."&topic_id=$topic_id&forum_id=$forum_id\"><img src=\"$image_edit\" alt=\"$l_editdelete\" border=\"0\"></a>";
+ $quote_img = "<a href=\"posting.$phpEx?mode=reply&quote=true&post_id=".$postrow[$x]["post_id"]."&topic_id=$topic_id&forum_id=$forum_id\"><img src=\"$image_quote\" alt=\"$l_replyquote\" border=\"0\"></a>";
+ $pmsg_img = "<a href=\"priv_msgs.$phpEx?mode=send\"><img src=\"$image_pmsg\" alt=\"$l_sendpmsg\" border=\"0\"></a>";
+
+ if($is_moderator)
+ {
+ $ip_img = "<a href=\"topicadmin.$phpEx?mode=viewip&user_id=".$poster_id."\"><img src=\"$image_ip\" alt=\"$l_viewip\" border=\"0\"></a>";
+ $delpost_img = "<a href=\"topicadmin.$phpEx?mode=delpost$post_id=".$postrow[$x]["post_id"]."\"><img src=\"$image_delpost\" alt=\"$l_delete\" border=\"0\"></a>";
+ }
+
+ $message = stripslashes($postrow[$x]["post_text"]);
+
+ if(!$allow_html)
+ {
+ $message = strip_tags($message);
+ }
+ if($allow_bbcode)
+ {
+ // do bbcode stuff here
+ }
+
+ if(!($x % 2))
+ {
+ $color = "#DDDDDD";
+ }
+ else
+ {
+ $color = "#CCCCCC";
+ }
+
+ $message = eregi_replace("\[addsig]$", "<BR>_________________<BR>" . stripslashes($postrow[$x]["user_sig"]), $message);
+
+ $template->set_var(array("TOPIC_TITLE" => $topic_title,
+ "L_POSTED" => $l_posted,
+ "L_JOINED" => $l_joined,
+ "POSTER_NAME" => $poster,
+ "POSTER_RANK" => $poster_rank,
+ "RANK_IMAGE" => $rank_image,
+ "ROW_COLOR" => $color,
+ "POSTER_JOINED" => $poster_joined,
+ "POSTER_POSTS" => $poster_posts,
+ "POSTER_FROM" => $poster_from,
+ "POST_DATE" => $post_date,
+ "MESSAGE" => $message,
+ "PROFILE_IMG" => $profile_img,
+ "EMAIL_IMG" => $email_img,
+ "WWW_IMG" => $www_img,
+ "ICQ_STATUS_IMG" => $icq_status_img,
+ "ICQ_ADD_IMG" => $icq_add_img,
+ "AIM_IMG" => $aim_img,
+ "MSN_IMG" => $msn_img,
+ "YIM_IMG" => $yim_img,
+ "EDIT_IMG" => $edit_img,
+ "QUOTE_IMG" => $quote_img,
+ "PMSG_IMG" => $pmsg_img,
+ "IP_IMG" => $ip_img,
+ "DELPOST_IMG" => $delpost_img));
+ $template->parse("posts", "postrow", true);
}
if($total_replies > $posts_per_page)
{
- $times = 0;
- for($x = 0; $x < $total_replies; $x += $posts_per_page)
- {
- $times++;
- }
- $pages = $times . " pages";
-
- $times = 1;
- $pagination = "$l_gotopage (";
-
- $last_page = $start - $posts_per_page;
- if($start > 0)
- {
- $pagination .= "<a href=\"$PHP_SELF?topic_id=$topic_id&forum_id=$forum_id&start=$last_page\">$l_prevpage</a> ";
- }
- for($x = 0; $x < $total_replies; $x += $posts_per_page)
- {
- if($times != 1)
- {
- $pagination .= " | ";
- }
- if($start && ($start == $x))
- {
- $pagination .= $times;
- }
- else if($start == 0 && $x == 0)
- {
- $pagination .= "1";
- }
- else
- {
- $pagination .= "<a href=\"$PHP_SELF?topic_id=$topic_id&forum_id=$forum_id&start=$x\">$times</a>";
- }
- $times++;
- }
- if(($start + $posts_per_page) < $total_replies)
- {
- $next_page = $start + $posts_per_page;
- $pagination .= " <a href=\"$PHP_SELF?topic_id=$topic_id&forum_id=$forum_id&start=$next_page\">$l_nextpage</a>";
- }
- $pagination .= " )";
+ $times = 0;
+ for($x = 0; $x < $total_replies; $x += $posts_per_page)
+ {
+ $times++;
+ }
+ $pages = $times . " pages";
+
+ $times = 1;
+ $pagination = "$l_gotopage (";
+
+ $last_page = $start - $posts_per_page;
+ if($start > 0)
+ {
+ $pagination .= "<a href=\"$PHP_SELF?topic_id=$topic_id&forum_id=$forum_id&start=$last_page\">$l_prevpage</a> ";
+ }
+
+ for($x = 0; $x < $total_replies; $x += $posts_per_page)
+ {
+ if($times != 1)
+ {
+ $pagination .= " | ";
+ }
+ if($start && ($start == $x))
+ {
+ $pagination .= $times;
+ }
+ else if($start == 0 && $x == 0)
+ {
+ $pagination .= "1";
+ }
+ else
+ {
+ $pagination .= "<a href=\"$PHP_SELF?topic_id=$topic_id&forum_id=$forum_id&start=$x\">$times</a>";
+ }
+ $times++;
+ }
+
+ if(($start + $posts_per_page) < $total_replies)
+ {
+ $next_page = $start + $posts_per_page;
+ $pagination .= " <a href=\"$PHP_SELF?topic_id=$topic_id&forum_id=$forum_id&start=$next_page\">$l_nextpage</a>";
+ }
+ $pagination .= " )";
}
else
{
- $pages = "1 page";
+ $pages = "1 page";
}
$template->set_var(array("PAGES" => $pages,
- "PAGINATION" => $pagination));
+ "PAGINATION" => $pagination));
+
$template->pparse("output", array("posts", "body"));
include('page_tail.'.$phpEx);