diff options
| author | Marc Alexander <admin@m-a-styles.de> | 2013-11-06 13:35:20 +0100 |
|---|---|---|
| committer | Marc Alexander <admin@m-a-styles.de> | 2014-04-11 17:21:30 +0200 |
| commit | 5dc3651290b0d6cad28534e6f88cc166f2e0a5b8 (patch) | |
| tree | 68a9061a0d47f164a9ea7a4dddc44be511acdc36 | |
| parent | d5363bd095219c6ca1e5b32efa2fa80239badd30 (diff) | |
| download | forums-5dc3651290b0d6cad28534e6f88cc166f2e0a5b8.tar forums-5dc3651290b0d6cad28534e6f88cc166f2e0a5b8.tar.gz forums-5dc3651290b0d6cad28534e6f88cc166f2e0a5b8.tar.bz2 forums-5dc3651290b0d6cad28534e6f88cc166f2e0a5b8.tar.xz forums-5dc3651290b0d6cad28534e6f88cc166f2e0a5b8.zip | |
[ticket/12004] Support empty routes to app.php/ in path_helper
The symfony routing component allows us to use the path "/" for routes.
Therefore, we should be able to use example.com/app.php/ for controllers.
However, this currently does not properly work. The method get_web_root_path
incorrectly returns phpbb_root_path. Therefore, paths to images or files are
broken.
PHPBB3-12004
| -rw-r--r-- | phpBB/phpbb/path_helper.php | 10 | ||||
| -rw-r--r-- | tests/path_helper/web_root_path_test.php | 7 |
2 files changed, 17 insertions, 0 deletions
diff --git a/phpBB/phpbb/path_helper.php b/phpBB/phpbb/path_helper.php index a8e12c4063..fefef39c51 100644 --- a/phpBB/phpbb/path_helper.php +++ b/phpBB/phpbb/path_helper.php @@ -149,6 +149,16 @@ class path_helper $script_name = $this->symfony_request->getScriptName(); /* + * If the path info is empty but we're using app.php, then we + * might be using an empty route like app.php/ which is + * supported by symfony's routing + */ + if ($path_info === '/' && preg_match('/app\.' . $this->php_ext . '\/$/', $request_uri)) + { + return $this->web_root_path = $this->phpbb_root_path . '../'; + } + + /* * If the path info is empty (single /), then we're not using * a route like app.php/foo/bar */ diff --git a/tests/path_helper/web_root_path_test.php b/tests/path_helper/web_root_path_test.php index 2c22511402..ec04135997 100644 --- a/tests/path_helper/web_root_path_test.php +++ b/tests/path_helper/web_root_path_test.php @@ -116,6 +116,13 @@ class phpbb_path_helper_web_root_path_test extends phpbb_test_case '/phpbb3-fork/phpBB/foo/template', '/phpbb3-fork/phpBB/app.php', ), + array( + $this->phpbb_root_path . 'test.php', + $this->phpbb_root_path . '../test.php', + '/', + '/phpbb3-fork/phpBB/app.php/', + '/phpbb3-fork/phpBB/app.php', + ), ); } |