aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoas Schilling <nickvergessen@gmx.de>2011-07-15 10:23:06 +0200
committerJoas Schilling <nickvergessen@gmx.de>2011-07-15 10:23:06 +0200
commit2231488543bcd309f036f027a353c157d2c903ad (patch)
treec644858316afc2b123f1cb9ffb86b3ddfcd00ead
parent1ace10ab92a19a56bcbfda665c3bd154fd5a1c2c (diff)
downloadforums-2231488543bcd309f036f027a353c157d2c903ad.tar
forums-2231488543bcd309f036f027a353c157d2c903ad.tar.gz
forums-2231488543bcd309f036f027a353c157d2c903ad.tar.bz2
forums-2231488543bcd309f036f027a353c157d2c903ad.tar.xz
forums-2231488543bcd309f036f027a353c157d2c903ad.zip
[ticket/10252] Correctly document behaviour of acl_get_list() for a_ permission
Be careful when using this function with permissions a_, m_, u_ and f_ ! It may not work correctly. When a user group grants an a_* permission, e.g. a_foo, but the user's a_foo permission is set to "Never", then the user does not in fact have the a_ permission. But the user will still be listed as having the a_ permission. PHPBB3-10252
-rw-r--r--phpBB/includes/auth.php8
1 files changed, 8 insertions, 0 deletions
diff --git a/phpBB/includes/auth.php b/phpBB/includes/auth.php
index 5564de2943..0585921426 100644
--- a/phpBB/includes/auth.php
+++ b/phpBB/includes/auth.php
@@ -349,6 +349,14 @@ class auth
/**
* Get permission listing based on user_id/options/forum_ids
+ *
+ * Be careful when using this function with permissions a_, m_, u_ and f_ !
+ * It may not work correctly. When a user group grants an a_* permission,
+ * e.g. a_foo, but the user's a_foo permission is set to "Never", then
+ * the user does not in fact have the a_ permission.
+ * But the user will still be listed as having the a_ permission.
+ *
+ * For more information see: http://tracker.phpbb.com/browse/PHPBB3-10252
*/
function acl_get_list($user_id = false, $opts = false, $forum_id = false)
{